Skip to content

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Nov 17, 2025

Oxlint

🚀 Features

🐛 Bug Fixes

⚡ Performance

📚 Documentation

Oxfmt

🚀 Features

🐛 Bug Fixes

⚡ Performance

📚 Documentation

Copilot AI review requested due to automatic review settings November 17, 2025 09:11
@Boshen Boshen self-assigned this Nov 17, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 17, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2025

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-editor Area - Editor and Language Server A-formatter Area - Formatter A-linter-plugins Area - Linter JS plugins labels Nov 17, 2025
Copilot finished reviewing on behalf of Boshen November 17, 2025 09:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the version numbers for oxlint (v1.28.0 → v1.29.0) and oxfmt (v0.13.0 → v0.14.0) across all relevant packages and updates changelog files with the new release information dated 2025-11-17.

Key changes:

  • Version updates for oxlint from 1.28.0 to 1.29.0 across npm packages, Rust crates, and VS Code extension
  • Version updates for oxfmt from 0.13.0 to 0.14.0 across npm packages and Rust crates
  • Updated native binding version checks in JavaScript files for all supported platforms

Reviewed Changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
npm/oxlint/package.json Bumped oxlint npm package version to 1.29.0
npm/oxlint/CHANGELOG.md Added changelog entry for v1.29.0 release
npm/oxfmt/package.json Bumped oxfmt npm package version to 0.14.0
npm/oxfmt/CHANGELOG.md Added changelog entry for v0.14.0 release
editors/vscode/package.json Bumped VS Code extension version to 1.29.0
editors/vscode/CHANGELOG.md Added changelog entry for VS Code extension v1.29.0
crates/oxc_linter/Cargo.toml Bumped oxc_linter crate version to 1.29.0
crates/oxc_linter/CHANGELOG.md Added comprehensive changelog entry for v1.29.0
crates/oxc_language_server/Cargo.toml Bumped oxc_language_server crate version to 1.29.0
crates/oxc_language_server/CHANGELOG.md Added changelog entry for v1.29.0
crates/oxc_formatter/Cargo.toml Bumped oxc_formatter crate version to 0.14.0
crates/oxc_formatter/CHANGELOG.md Added comprehensive changelog entry for v0.14.0
apps/oxlint/src-js/bindings.js Updated all platform-specific native binding version checks from 1.28.0 to 1.29.0
apps/oxlint/package.json Bumped oxlint app package version to 1.29.0
apps/oxlint/Cargo.toml Bumped oxlint app crate version to 1.29.0
apps/oxlint/CHANGELOG.md Added changelog entry for v1.29.0
apps/oxfmt/src-js/bindings.js Updated all platform-specific native binding version checks from 0.13.0 to 0.14.0
apps/oxfmt/package.json Bumped oxfmt app package version to 0.14.0
apps/oxfmt/Cargo.toml Bumped oxfmt app crate version to 0.14.0
apps/oxfmt/CHANGELOG.md Added changelog entry for v0.14.0
Cargo.lock Updated lockfile with new version numbers for all affected crates

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

### 🚀 Features

- 84de1ca oxlint,oxfmt: Allow comments and also commas for vscode-json-ls (#15612) (leaysgur)

Copy link

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entry shows only one feature from the PR description (commit 84de1ca), but according to the PR description, oxlint v1.29.0 should include multiple features such as:

  • c199e38 linter: Implement config for all tsgolint rules supporting options
  • 7598b3e linter: Allow configuring tsgolint rules
  • e77f2ce vscode: Support oxlint --lsp
  • e01c551 oxlint: Add --lsp flag to run the language server
  • ac5c2ab lsp/fmt: Support ignore files & patterns
  • e50a9bf linter: Add unicorn/prefer-response-static-json rule
  • f5d9abb oxlint: Add enabled? column to --rules cli output
  • And several more...

The changelog appears incomplete compared to what's listed in the full oxc_linter changelog.

Suggested change
- c199e38 linter: Implement config for all tsgolint rules supporting options (#15610) (contributor)
- 7598b3e linter: Allow configuring tsgolint rules (#15609) (contributor)
- e77f2ce vscode: Support `oxlint --lsp` (#15608) (contributor)
- e01c551 oxlint: Add `--lsp` flag to run the language server (#15607) (contributor)
- ac5c2ab lsp/fmt: Support ignore files & patterns (#15606) (contributor)
- e50a9bf linter: Add unicorn/prefer-response-static-json rule (#15605) (contributor)
- f5d9abb oxlint: Add enabled? column to --rules cli output (#15604) (contributor)

Copilot uses AI. Check for mistakes.
Comment on lines +11 to +12
- 84de1ca oxlint,oxfmt: Allow comments and also commas for vscode-json-ls (#15612) (leaysgur)

Copy link

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entry shows only one feature from the PR description (commit 84de1ca), but according to the PR description, oxfmt v0.14.0 should include multiple features such as:

  • 84de1ca oxlint,oxfmt: Allow comments and also commas for vscode-json-ls
  • 99823ad oxfmt: Print nothing for default(write) mode
  • 25a0163 formatter/sort_imports: Sort imports by Array<Array<string>> groups

And several bug fixes and performance improvements. The changelog appears incomplete compared to what's listed in the full oxc_formatter changelog.

Suggested change
- 84de1ca oxlint,oxfmt: Allow comments and also commas for vscode-json-ls (#15612) (leaysgur)
- 84de1ca oxlint,oxfmt: Allow comments and also commas for vscode-json-ls (#15612) (leaysgur)
- 99823ad oxfmt: Print nothing for default(write) mode (#15612) (leaysgur)
- 25a0163 formatter/sort_imports: Sort imports by `Array<Array<string>>` groups (#15612) (leaysgur)
### 🐛 Bug Fixes & Performance
- Various bug fixes and performance improvements from oxc_formatter v0.14.0 (#15612) (leaysgur)

Copilot uses AI. Check for mistakes.
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 17, 2025

CodSpeed Performance Report

Merging #15772 will not alter performance

Comparing release/apps-1763370662 (799e476) with main (c023ba6)

Summary

✅ 37 untouched

@Boshen Boshen assigned camc314 and overlookmotel and unassigned Boshen and camc314 Nov 17, 2025
@overlookmotel overlookmotel merged commit ef4cc33 into main Nov 17, 2025
36 checks passed
@overlookmotel overlookmotel deleted the release/apps-1763370662 branch November 17, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-editor Area - Editor and Language Server A-formatter Area - Formatter A-linter Area - Linter A-linter-plugins Area - Linter JS plugins

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants