feat(formatter/sort-imports): Support options.groups

[leaysgur]

Part of #14253

Now user can specify own groups like:

groups: [
  "type",
  ["external", "builtin"]
]

• Parse config
• Implementation
• Test
• Refactor for readability
• Refactor for performance
• Report non-defaults?

Sorry for the large diffs. Yes, it's incredibly complicated. 😓

[leaysgur]

• test(formatter/sort-imports): Update comments and tests #15896
• feat(formatter/sort-imports): Support options.groups #15831 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #15831 will not alter performance

_{Comparing 11-18-feat_formatter_sort-imports_support_options.groups (4953781) with main (7c46a9e)¹}

Summary

✅ 38 untouched
⏩ 7 skipped²

Footnotes

1. No successful run was found on main (acf9637) during the generation of this report, so 7c46a9e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull Request Overview

This PR adds support for custom options.groups configuration in the experimental sort-imports feature, allowing users to define their own import grouping and ordering strategies (e.g., groups: ["type", ["external", "builtin"]]).

Key Changes:

• Added groups field to SortImportsConfig with custom deserializer supporting both string and string array elements
• Refactored code architecture: split import_unit.rs into three focused modules (group_config.rs, compute_metadata.rs, sortable_imports.rs)
• Enhanced group matching to support complex patterns (e.g., type-external, side-effect-style, parent-type)
• Changed default groups from hardcoded values to Option<Vec<Vec<String>>> (None uses defaults)

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
npm/oxfmt/configuration_schema.json	Added groups property definition to SortImportsConfig schema
crates/oxc_formatter/tests/snapshots/schema_json.snap	Updated snapshot to reflect schema changes
napi/playground/src/lib.rs	Removed TODO comment and now uses configured groups from options
crates/oxc_formatter/src/service/oxfmtrc.rs	Added custom deserializer for groups field and test coverage
crates/oxc_formatter/src/options.rs	Changed groups from required Vec to Option, updated default implementation
crates/oxc_formatter/src/ir_transform/sort_imports/mod.rs	Refactored to use new module structure, parse groups on initialization
crates/oxc_formatter/src/ir_transform/sort_imports/source_line.rs	Added lifetime parameter, improved specifier detection logic
crates/oxc_formatter/src/ir_transform/sort_imports/partitioned_chunk.rs	Integrated new sorting logic with group configuration
crates/oxc_formatter/src/ir_transform/sort_imports/group_config.rs	New module defining group names, selectors, and modifiers with parsing
crates/oxc_formatter/src/ir_transform/sort_imports/compute_metadata.rs	New module for import metadata computation and group matching
crates/oxc_formatter/src/ir_transform/sort_imports/sortable_imports.rs	New module implementing sorting algorithm with side-effect preservation
crates/oxc_formatter/tests/ir_transform/sort_imports.rs	Added comprehensive tests for custom group configurations
crates/oxc_formatter/tests/ir_transform/_sort-imports-tests.ref.snap	Removed TypeScript test cases (migrated to Rust tests)
crates/oxc_formatter/examples/sort_imports.rs	Updated to use None for default groups

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[graphite-app]

Merge activity

• Nov 20, 9:01 AM UTC: leaysgur added this pull request to the Graphite merge queue.
• Nov 20, 9:14 AM UTC: Merged by the Graphite merge queue.