fix(formatter): inconsistent CallExpression and NewExpression around member chain and logical expression

[Dunqing]

Follow up prettier/prettier#18171

[Dunqing]

• fix(formatter): comments in export class decorators are printing incorrectly #15897
• fix(formatter): correct a few minor mismatched typescript tests #15894
• fix(formatter): improve formatting for default type on type parameters #15893
• fix(formatter): inconsistent printing of class extends and interface extends #15892
• fix(formatter): inconsistent CallExpression and NewExpression around member chain and logical expression #15858 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #15858 will not alter performance

_{Comparing 11-19-fix_formatter_inconsistent_callexpression_and_newexpression_around_member_chain_and_logical_expression (47c5388) with main (7c46a9e)¹}

Summary

✅ 38 untouched
⏩ 7 skipped²

Footnotes

1. No successful run was found on main (acf9637) during the generation of this report, so 7c46a9e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull Request Overview

This PR fixes formatting inconsistencies in CallExpression and NewExpression when they involve member chains and logical expressions. The changes improve Prettier compatibility by correctly identifying whether a node is part of the callee or arguments, and by adding NewExpression to contexts that previously only handled CallExpression.

Key changes:

• Fixed member expression layout logic to correctly check if a node is within the callee (not arguments) of a NewExpression
• Added NewExpression support to JSX element wrap state detection
• Added NewExpression to binary-like expression indentation rules for consistency with CallExpression

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
crates/oxc_formatter/src/write/member_expression.rs	Fixed bug where is_argument_span was incorrectly used instead of checking if the node is within the callee span
crates/oxc_formatter/src/write/jsx/element.rs	Added NewExpression handling to prevent wrapping JSX elements in arguments
crates/oxc_formatter/src/write/binary_like_expression.rs	Added NewExpression to the list of parent nodes that should not indent binary-like expressions
tasks/prettier_conformance/snapshots/prettier.ts.snap.md	Updated compatibility metrics showing 2 more tests now pass (545/601)
tasks/prettier_conformance/snapshots/prettier.js.snap.md	Updated compatibility metrics showing 4 more tests now pass (711/758)
crates/oxc_formatter/tests/fixtures/ts/static-members/argument.ts.snap	Snapshot showing corrected formatting of member chains in NewExpression arguments
crates/oxc_formatter/tests/fixtures/js/logicals/indent.js.snap	Snapshot showing corrected indentation of logical expressions in NewExpression

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[graphite-app]

Merge activity

• Nov 20, 9:09 AM UTC: leaysgur added this pull request to the Graphite merge queue.
• Nov 20, 9:22 AM UTC: Merged by the Graphite merge queue.