fix(oxlint/lsp): don't register `textDocument/formatting` capability #15882

Sysix · 2025-11-19T18:35:47Z

Refactored the language server, so the ServerCapability can modified by each tool.
Before, we just registered the textDocument/formatting capability, if the client supports it dynamically.

Now we tell the client at the beginning if the request is supported, skipping the dynamic registration. Improving integration with client that does only support static registration.

And only of course when we use the formatter tool ;) Skipping it for oxlint --lsp

Sysix · 2025-11-19T18:36:03Z

fix(oxlint/lsp): don't register textDocument/formatting capability #15882 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull Request Overview

This PR refactors the language server to allow tools (linter, formatter) to directly modify server capabilities during initialization, replacing the previous approach of dynamic capability registration. The main goal is to improve compatibility with LSP clients that only support static capability registration.

Key Changes:

Modified the ToolBuilder trait to expose a server_capabilities method that allows tools to declare their capabilities upfront
Removed dynamic registration of textDocument/formatting capability in favor of static declaration
Each tool now independently adds its capabilities (linter adds code actions/commands, formatter adds document formatting)

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`crates/oxc_language_server/src/tool.rs`	Replaced `provided_commands` and `provided_code_action_kinds` methods with a unified `server_capabilities` method for modifying capabilities directly
`crates/oxc_language_server/src/linter/server_linter.rs`	Implemented `server_capabilities` to add code action kinds and execute commands, with comprehensive test coverage for various capability scenarios
`crates/oxc_language_server/src/formatter/server_formatter.rs`	Implemented `server_capabilities` to enable document formatting provider, with basic test coverage
`crates/oxc_language_server/src/capabilities.rs`	Simplified by removing client capability checks for code actions and commands, converting `server_capabilities` to a standalone function
`crates/oxc_language_server/src/backend.rs`	Updated initialization to call `server_capabilities` on each tool builder and removed dynamic formatting registration logic

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

camc314 · 2025-11-21T15:22:34Z

Merge activity

Nov 21, 3:22 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Nov 21, 3:22 PM UTC: camc314 added this pull request to the Graphite merge queue.
Nov 21, 3:27 PM UTC: Merged by the Graphite merge queue.

…15882) Refactored the language server, so the `ServerCapability` can modified by each tool. Before, we just registered the `textDocument/formatting` capability, if the client supports it dynamically. Now we tell the client at the beginning if the request is supported, skipping the dynamic registration. Improving integration with client that does only support static registration. And only of course when we use the formatter tool ;) Skipping it for `oxlint --lsp`

In #15882 we removed the dynamic formatting registration and registered them statically. LSP Clients could only support static formatting registration and the checks would fail. When someone formats, while not saving, the unsaved changes would disappear. Removed the checks, so it always saves the content in the file system. Later the Linter will use the file system too when supporting [textDocument/diagnostic](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_diagnostic)

# Oxlint ### 💥 BREAKING CHANGES - cbb27fd ast: [**BREAKING**] Add `TSGlobalDeclaration` type (#15712) (overlookmotel) ### 🚀 Features - 72660f7 linter: Support auto generate config document for tuple lint option (#15904) (Duc Nghiem Xuan) - 0c1f82b linter/plugins: Add `tokens` property to `Program` (#16020) (overlookmotel) - 9e61beb linter/plugins: Implement `SourceCode#getFirstToken()` (#16002) (Arsh) - 9a548dd linter/plugins: Implement `SourceCode#getLastTokens()` (#16000) (Arsh) - 0b6cb11 linter/plugins: Implement `SourceCode#getFirstTokens()` (#15976) (Arsh) - 166781e linter/plugins: Implement `SourceCode#getTokenAfter()` (#15973) (Arsh) - 6ae232b linter: Expose type errors via tsgolint (#15917) (camc314) - 2bfdd26 linter/plugins: Implement `SourceCode#getTokensAfter()` (#15971) (Arsh) - 45fffc1 linter/plugins: Implement `SourceCode#getTokenBefore()` (#15956) (Arsh) - 776e473 linter/plugins: Implement `SourceCode#getTokensBefore()` (#15955) (Arsh) - 595867a oxlint: Generate markdownDescription fields for oxlint JSON schema. (#15959) (connorshea) - 5569317 vscode: Add quick actions to status bar tooltip (#15962) (Sysix) - 986cac1 linter/plugins: Token-related `SourceCode` APIs (TS ESLint implementation) (#15861) (Arsh) - a21f9e4 linter: Implement unicorn/prefer-bigint-literals rule (#15923) (Michiel Vrins) - 4b9d8d2 linter/type-aware: Include range with tsconfig diagnostics (#15916) (camc314) - 220d01e editor: Improve the status bar item for the VS Code extension by adding a tooltip. (#15819) (connorshea) ### 🐛 Bug Fixes - 2bd3cb6 apps, editors, napi: Fix `oxlint-disable` comments (#16014) (overlookmotel) - 81f5360 linter/prefer-number-properties: Get fixer to replace entire call expr (#15979) (camc314) - e4ba07f language_server: Always write to memory file system (#15975) (Sysix) - a8a2032 linter: Support missing `range` for internal diagnostics (#15964) (camc314) - 619a226 oxlint/lsp: Don't register `textDocument/formatting` capability (#15882) (Sysix) - 6ab1a20 linter: Fix no_useless_spread producing invalid syntax when removing empty object spreads (#15905) (camc314) - be4b6df linter: Unicorn/prefer-string-replace-all incorrectly escapes backslashes (#15901) (camc314) - 9fa9ef2 linter: Gracefully fail when using import plugin, large file counf and JS plugins (#15864) (camc314) - c027398 linter/plugins: Correct bindings package names glob in TSDown config (#15871) (overlookmotel) - b622ef8 linter: Fix `oxc/bad_array_method_on_arguments` rule behavior. (#15854) (connorshea) - aa06c3f linter: Recognize NewExpression as value context in no-unused-private-class-members (#15843) (camc314) - e89c5ba typescript/prefer-namespace-keyword: Skip nested `TSModuleDeclaration`s (#15806) (overlookmotel) - 646d020 linter/exhaustive-dependencies: Prevent is_callee_of_call_expr flag from leaking into nested expressions (#15832) (camc314) - 46bd6bd linter/plugins: Pin `@typescript-eslint/scope-manager` dependency (#15807) (overlookmotel) - fba31fa linter: Patch `@typescript-eslint/scope manager` (#15214) (Arsh) - 50307c1 linter/jest: Ignore `expect` identifier in argument position (#15785) (camc314) ### ⚡ Performance - 024b48a linter/plugins: Lazy-load tokens parsing code (#16011) (overlookmotel) - 15365c9 linter/plugins: Reduce var assignments (#15953) (overlookmotel) - 84d1f4f linter/plugins: Downgrade some checks to debug-only (#15922) (overlookmotel) - a49f704 linter/typescript: Avoid searching source text unless required (#15805) (overlookmotel) ### 📚 Documentation - ceffa5a linter: Add config option docs for various rules. (#16024) (connorshea) - 9a0ed13 linter: Fix config option docs for eslint/operator-assignment rule. (#16030) (connorshea) - 0b18005 linter: Add config docs generation for rules with Regex arguments (#15978) (connorshea) - 48d18e0 linter: Improve diagnostic message for promise/catch-or-return rule (#15980) (connorshea) - 6c72e84 linter: Use backticks for code elements across more rule diagnostics (#15958) (connorshea) - a63dad7 linter/plugins: Add comment (#15952) (overlookmotel) - 81ea642 vscode: Use markdownDescription for better formatting in VSCode Settings (#15889) (connorshea) - db6a110 linter/plugins: Fix JSDoc comment (#15884) (overlookmotel) - 1487271 linter: Add config option docs for `jsdoc/require-param` and `jsdoc/require-returns` rules (#15857) (connorshea) - fbf0fd4 linter/plugins: Add JSDoc comments to `Plugin` and `Rule` types (#15815) (overlookmotel) - ac5e4b5 linter/plugins: Add JSDoc comments and improve comments (#15814) (overlookmotel) - 9b7b083 linter: Fix error in `curly` `"all"` example (#15801) (camc314) - 65a3520 linter: Improve diagnostic for consistent-type-definitions rule. (#15752) (connorshea) ### 🛡️ Security - f9b9276 deps: Update dependency rolldown to v1.0.0-beta.51 (#15856) (renovate[bot]) # Oxfmt ### 💥 BREAKING CHANGES - a937890 formatter: [**BREAKING**] Default to `lineWidth: 100` (#15933) (leaysgur) - 03d5f5a formatter/sort-imports: [**BREAKING**] Change default order to `natural` with `natord` crate (#15828) (leaysgur) - cbb27fd ast: [**BREAKING**] Add `TSGlobalDeclaration` type (#15712) (overlookmotel) ### 🚀 Features - 7818e22 formatter/sort-imports: Support `options.groups` (#15831) (leaysgur) - f9a502c oxfmt: `oxfmt --lsp` support (#15765) (leaysgur) ### 🐛 Bug Fixes - 4817486 formatter: Revert `FormatElement::BestFitting` printing logic (#16028) (Dunqing) - 5562dd6 formatter: Incorrect formatting method chain with trailing comments (#16027) (Dunqing) - 6d14c8b formatter: Comments in export class decorators are printing incorrectly (#15897) (Dunqing) - 683c764 formatter: Correct a few minor mismatched typescript tests (#15894) (Dunqing) - c11cc07 formatter: Improve formatting for default type on type parameters (#15893) (Dunqing) - 0bff596 formatter: Handle JSX expresssion dangling comment (#15890) (leaysgur) - 16a9dc8 formatter: Inconsistent printing of class extends and interface extends (#15892) (Dunqing) - 300b496 formatter: Inconsistent CallExpression and NewExpression around member chain and logical expression (#15858) (Dunqing) ### ⚡ Performance - 65174cc formatter: Reduce the size of `TextWidth` to 4 byte (#15827) (Dunqing) - 4fe3aac formatter: Use `ArenaVec` and `ArenaBox` (#15420) (Dunqing) Co-authored-by: overlookmotel <557937+overlookmotel@users.noreply.github.com>

github-actions bot added A-editor Area - Editor and Language Server C-bug Category - Bug labels Nov 19, 2025

Sysix force-pushed the 11-19-fix_oxlint_lsp_don_t_register_textdocument_formatting_capability branch from b4a6fdf to 45a6921 Compare November 19, 2025 18:50

Sysix requested a review from Copilot November 19, 2025 19:11

Copilot started reviewing on behalf of Sysix November 19, 2025 19:12 View session

Copilot finished reviewing on behalf of Sysix November 19, 2025 19:14

Copilot AI reviewed Nov 19, 2025

View reviewed changes

Sysix marked this pull request as ready for review November 19, 2025 19:17

Sysix requested a review from camc314 as a code owner November 19, 2025 19:17

camc314 approved these changes Nov 21, 2025

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Nov 21, 2025

camc314 self-assigned this Nov 21, 2025

graphite-app bot force-pushed the 11-19-fix_oxlint_lsp_don_t_register_textdocument_formatting_capability branch from 45a6921 to 619a226 Compare November 21, 2025 15:22

graphite-app bot merged commit 619a226 into main Nov 21, 2025
21 checks passed

graphite-app bot deleted the 11-19-fix_oxlint_lsp_don_t_register_textdocument_formatting_capability branch November 21, 2025 15:27

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 21, 2025

Sysix mentioned this pull request Nov 22, 2025

fix(language_server): always write to memory file system #15975

Merged

This was referenced Nov 24, 2025

release(apps): oxlint v1.30.0 && oxfmt v0.15.0 #16039

Closed

release(apps): oxlint v1.30.0 && oxfmt v0.15.0 #16047

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(oxlint/lsp): don't register `textDocument/formatting` capability #15882

fix(oxlint/lsp): don't register `textDocument/formatting` capability #15882

Uh oh!

Sysix commented Nov 19, 2025 •

edited

Loading

Uh oh!

Sysix commented Nov 19, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

camc314 commented Nov 21, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix(oxlint/lsp): don't register textDocument/formatting capability #15882

fix(oxlint/lsp): don't register textDocument/formatting capability #15882

Uh oh!

Conversation

Sysix commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sysix commented Nov 19, 2025

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

camc314 commented Nov 21, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(oxlint/lsp): don't register `textDocument/formatting` capability #15882

fix(oxlint/lsp): don't register `textDocument/formatting` capability #15882

Sysix commented Nov 19, 2025 •

edited

Loading

camc314 commented Nov 21, 2025 •

edited by graphite-app bot

Loading