Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preprocessor, planner: inline processing by default for single-consumer cte #37800

Merged
merged 13 commits into from
Sep 28, 2022
Merged

preprocessor, planner: inline processing by default for single-consumer cte #37800

merged 13 commits into from
Sep 28, 2022

Conversation

elsa0520
Copy link
Contributor

@elsa0520 elsa0520 commented Sep 14, 2022 •
edited
Loading

What problem does this PR solve?

This pr mainly does an optimization of inline CTE.
When there is only one consumer of CTE, the CTE is inlined by default. (Except recursive CTE )

Issue Number: close #36295

Problem Summary:

What is changed and how it works?

There are two changes:

  1. Added the count processing of CTE consumers in AST perprocessor.
  2. When the AST is converted into a logical plan, inline processing is performed for the CTE whose count is 1.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 14, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fixdb
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 14, 2022
@elsa0520 elsa0520 changed the title ast, planner: inline processing by default for single-consumer cte preprocessor, planner: inline processing by default for single-consumer cte Sep 14, 2022
winoros
winoros reviewed Sep 15, 2022
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pushed diff missed that push the new slice into the stack when we meet a new query block?

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 15, 2022
@elsa0520
Copy link
Contributor Author

The pushed diff missed that push the new slice into the stack when we meet a new query block?

Some code forgot to submit 😭

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 19, 2022
@elsa0520 elsa0520 marked this pull request as ready for review September 19, 2022 06:09
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2022
@elsa0520
Copy link
Contributor Author

elsa0520 commented Sep 19, 2022 •
edited
Loading

How to rerun check_dev_2 ？L
Looking at the error log, it seems to be a problem with the master itself, not this pr.

@time-and-fate
Copy link
Member

/run-check_dev_2

@elsa0520
Copy link
Contributor Author

/run-check_dev_2

Thanks ~

fixdb
fixdb reviewed Sep 22, 2022
View reviewed changes
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this, it should be safe to inline this, right?

with x as (select * from (select b from t for update) s)
select * from x where b = 1;

@elsa0520
Copy link
Contributor Author

/run-mysql-test tidb-test=pr/1976

@elsa0520
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 27, 2022
@fixdb
Copy link
Contributor

fixdb commented Sep 27, 2022

@elsa0520 issue #36295

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 27, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Sep 27, 2022
@elsa0520
Copy link
Contributor Author

/run-mysql-test tidb-test=pr/1976

2 similar comments
@elsa0520
Copy link
Contributor Author

/run-mysql-test tidb-test=pr/1976

@elsa0520
Copy link
Contributor Author

/run-mysql-test tidb-test=pr/1976

@wuhuizuo
Copy link
Contributor

/run-check-dev

4 similar comments
@wuhuizuo
Copy link
Contributor

/run-check-dev

@wuhuizuo
Copy link
Contributor

/run-check-dev

@wuhuizuo
Copy link
Contributor

/run-check-dev

@wuhuizuo
Copy link
Contributor

/run-check-dev

@chrysan
Copy link
Contributor

chrysan commented Sep 28, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 69ba7fe

@fixdb
Copy link
Contributor

fixdb commented Sep 28, 2022

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 28, 2022
@ti-chi-bot
Copy link
Member

@fixdb: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@fixdb
Copy link
Contributor

fixdb commented Sep 28, 2022

/run-mysql-test

@chrysan
Copy link
Contributor

chrysan commented Sep 28, 2022

/run-mysql-test

@time-and-fate
Copy link
Member

/run-mysql-test tidb-test=pr/1976

@AilinKid AilinKid merged commit 150813d into pingcap:master Sep 28, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Sep 28, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [2] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 2, success 15, total 17 18 min New failing
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 4 min 24 sec New failing
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 16 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 26 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 47 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 32 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 52 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 2 min 52 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 43 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

morgo added a commit to morgo/tidb that referenced this pull request Oct 4, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into sessionctx-code-i…
06bcee9 
…mprovements

* upstream/master: (56 commits)
  expression: make a copy when retrieving json path expression from cache (pingcap#38285)
  executor: make unit test TestIssue21732 stable (pingcap#38278)
  variables: enable variable hook to access storage (pingcap#38227)
  docs: update roadmap description (pingcap#38253)
  systable: Adapt with TiFlash system table update (pingcap#38191)
  planner, util/ranger: restrict mem usage for index join inner ranges (pingcap#38129)
  planner: separate cost model ver1/ver2 into different files (part 2) (pingcap#38273)
  metrics: Add IOPs, Disk Throughput to the overview dashboard (pingcap#38270)
  planner: refine index join range display for clustered index (pingcap#38259)
  *: delete `mInFlashbackCluster` related codes (pingcap#38241)
  session: turn the transaction to pessimistic mode when retrying (pingcap#38130)
  executor: enable race for executor/aggfuncs (pingcap#38262)
  planner: reopen CTE in apply only when correlate (pingcap#38214)
  planner: enable revive (pingcap#36649)
  *: add foreign key constraint check when execute update statement (pingcap#38156)
  *: DATA RACE in the temptable.AttachLocalTemporaryTableInfoSchema (pingcap#38237)
  executor,sessionctx: enable coprocessor paging and make TestCoprocessorPagingSize stable (pingcap#38161)
  domain: fix data race in the Domain.bindHandle (pingcap#38223)
  test: add information if test failed (pingcap#38234)
  preprocessor, planner: inline processing by default for single-consumer cte (pingcap#37800)
  ...
@YangKeao YangKeao mentioned this pull request Nov 8, 2023
Closed
@kennedy8312 kennedy8312 mentioned this pull request Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fixdb fixdb fixdb approved these changes

@winoros winoros winoros approved these changes

@AilinKid AilinKid AilinKid approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Planner should automatically inline CTE if it has only 1 consumer
9 participants
@elsa0520 @ti-chi-bot @time-and-fate @fixdb @winoros @wuhuizuo @chrysan @sre-bot @AilinKid