domain: fix data race in the Domain.bindHandle #38223
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
| @@ -124,6 +124,25 @@ func NewBindHandle(ctx sessionctx.Context) *BindHandle { | |||
| return handle | |||
| } | |||
|
|
|||
| // Reset is to reset the BindHandle and clean old info. | |||
| func (h *BindHandle) Reset(ctx sessionctx.Context) { | |||
There was a problem hiding this comment.
It likes similar with NewBindHandle, maybe could combine those two functions.
There was a problem hiding this comment.
OK, I remove the same code in the NewBindHandle. It is replaced with BindHandle.Reset.
hawkingrei
force-pushed
the
data_race_in_the_domain
branch
from
d91b9e5
to
9094772
Compare
ti-chi-bot
added
size/M
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
hawkingrei
force-pushed
the
data_race_in_the_domain
branch
from
9094772
to
9474343
Compare
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 0d2d37a
|
ti-chi-bot
added
the
status/can-merge
hawkingrei
added
needs-cherry-pick-release-6.1
|
In response to a cherrypick label: cannot checkout |
|
In response to a cherrypick label: cannot checkout |
|
In response to a cherrypick label: cannot checkout |
TiDB MergeCI notify🔴 Bad News! [1] CI still failing after this pr merged.
|
|
/run-check-dev2 |
…mprovements * upstream/master: (56 commits) expression: make a copy when retrieving json path expression from cache (pingcap#38285) executor: make unit test TestIssue21732 stable (pingcap#38278) variables: enable variable hook to access storage (pingcap#38227) docs: update roadmap description (pingcap#38253) systable: Adapt with TiFlash system table update (pingcap#38191) planner, util/ranger: restrict mem usage for index join inner ranges (pingcap#38129) planner: separate cost model ver1/ver2 into different files (part 2) (pingcap#38273) metrics: Add IOPs, Disk Throughput to the overview dashboard (pingcap#38270) planner: refine index join range display for clustered index (pingcap#38259) *: delete `mInFlashbackCluster` related codes (pingcap#38241) session: turn the transaction to pessimistic mode when retrying (pingcap#38130) executor: enable race for executor/aggfuncs (pingcap#38262) planner: reopen CTE in apply only when correlate (pingcap#38214) planner: enable revive (pingcap#36649) *: add foreign key constraint check when execute update statement (pingcap#38156) *: DATA RACE in the temptable.AttachLocalTemporaryTableInfoSchema (pingcap#38237) executor,sessionctx: enable coprocessor paging and make TestCoprocessorPagingSize stable (pingcap#38161) domain: fix data race in the Domain.bindHandle (pingcap#38223) test: add information if test failed (pingcap#38234) preprocessor, planner: inline processing by default for single-consumer cte (pingcap#37800) ...
Signed-off-by: Weizhen Wang wangweizhen@pingcap.com
What problem does this PR solve?
Issue Number: close #38062
Problem Summary:
What is changed and how it works?
Check List
Tests
enable race for unit test
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.