Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: turn the transaction to pessimistic mode when retrying #38130

Merged
merged 2 commits into from
Sep 30, 2022
Merged

session: turn the transaction to pessimistic mode when retrying #38130

merged 2 commits into from
Sep 30, 2022

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Sep 23, 2022 •
edited
Loading

Signed-off-by: Jack Yu jackysp@gmail.com

What problem does this PR solve?

Issue Number: close #38136

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@jackysp
session: turn the transaction to pessimistic mode when retrying
91a6998 
Signed-off-by: Jack Yu <jackysp@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 23, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • coocood
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 23, 2022
@jackysp jackysp marked this pull request as ready for review September 23, 2022 11:39
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2022
@jackysp jackysp requested a review from coocood September 23, 2022 11:40
@jackysp jackysp added the sig/transaction SIG:Transaction label Sep 23, 2022
@jackysp jackysp requested a review from winoros September 26, 2022 04:49
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 27, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 27, 2022
@jackysp
Copy link
Member Author

jackysp commented Sep 30, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 91a6998

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 30, 2022
@ti-chi-bot ti-chi-bot merged commit d4f4c81 into pingcap:master Sep 30, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Sep 30, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [2] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🔴 failed 2, success 35, total 37 37 min Existing failure
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 15 min Existing failure
idc-jenkins-ci-tidb/tics-test 🔴 failed 1, success 0, total 1 4 min 31 sec Existing failure
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 28 min Fixed
idc-jenkins-ci-tidb/sqllogic-test-2 ✅ all 28 tests passed 4 min 50 sec Fixed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 21 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 2 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 2 min 48 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

morgo added a commit to morgo/tidb that referenced this pull request Oct 4, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into sessionctx-code-i…
06bcee9 
…mprovements

* upstream/master: (56 commits)
  expression: make a copy when retrieving json path expression from cache (pingcap#38285)
  executor: make unit test TestIssue21732 stable (pingcap#38278)
  variables: enable variable hook to access storage (pingcap#38227)
  docs: update roadmap description (pingcap#38253)
  systable: Adapt with TiFlash system table update (pingcap#38191)
  planner, util/ranger: restrict mem usage for index join inner ranges (pingcap#38129)
  planner: separate cost model ver1/ver2 into different files (part 2) (pingcap#38273)
  metrics: Add IOPs, Disk Throughput to the overview dashboard (pingcap#38270)
  planner: refine index join range display for clustered index (pingcap#38259)
  *: delete `mInFlashbackCluster` related codes (pingcap#38241)
  session: turn the transaction to pessimistic mode when retrying (pingcap#38130)
  executor: enable race for executor/aggfuncs (pingcap#38262)
  planner: reopen CTE in apply only when correlate (pingcap#38214)
  planner: enable revive (pingcap#36649)
  *: add foreign key constraint check when execute update statement (pingcap#38156)
  *: DATA RACE in the temptable.AttachLocalTemporaryTableInfoSchema (pingcap#38237)
  executor,sessionctx: enable coprocessor paging and make TestCoprocessorPagingSize stable (pingcap#38161)
  domain: fix data race in the Domain.bindHandle (pingcap#38223)
  test: add information if test failed (pingcap#38234)
  preprocessor, planner: inline processing by default for single-consumer cte (pingcap#37800)
  ...
@winoros winoros mentioned this pull request Oct 25, 2022
Closed
@xuyifangreeneyes
Copy link
Contributor

/cherry-pick release-6.1-20220824

@ti-chi-bot ti-chi-bot mentioned this pull request May 29, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

@xuyifangreeneyes: new pull request created to branch release-6.1-20220824: #44239.

In response to this:

/cherry-pick release-6.1-20220824

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request May 29, 2023
@ti-chi-bot
session: turn the transaction to pessimistic mode when retrying (#38130…
8c1282e 
…) (#44239)

close #38136
winoros pushed a commit to winoros/tidb that referenced this pull request Jul 3, 2023
@jackysp @winoros
session: turn the transaction to pessimistic mode when retrying (ping…
0b6571a 
…cap#38130)

close pingcap#38136
@winoros winoros mentioned this pull request Jul 3, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jul 3, 2023
@winoros
session: turn the transaction to pessimistic mode when retrying (#38130…
3eaac08 
…) (#45114)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@coocood coocood coocood approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/transaction SIG:Transaction size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some internal transactions cost too much time in transaction retry
6 participants
@jackysp @ti-chi-bot @sre-bot @xuyifangreeneyes @coocood @winoros