planner, util/ranger: restrict mem usage for index join inner ranges #38129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
ti-chi-bot
removed
the
needs-rebase
14 tasks
ti-chi-bot
added
size/XXL
Yisaer
reviewed
Sep 27, 2022
Comment on lines
349
to
365
| ijCase := &indexJoinTestCase{ | ||
| innerKeys: []*expression.Column{dsSchema.Columns[1], dsSchema.Columns[3]}, | ||
| pushedDownConds: "a in (1, 3) and c in ('aaa', 'bbb')", | ||
| otherConds: "", | ||
| ranges: "[[1 NULL \"aa\" NULL,1 NULL \"aa\" NULL] [1 NULL \"bb\" NULL,1 NULL \"bb\" NULL] [3 NULL \"aa\" NULL,3 NULL \"aa\" NULL] [3 NULL \"bb\" NULL,3 NULL \"bb\" NULL]]", | ||
| idxOff2KeyOff: "[-1 0 -1 1 -1]", | ||
| accesses: "[in(Column#1, 1, 3) in(Column#3, aaa, bbb)]", | ||
| remained: "[in(Column#3, aaa, bbb)]", | ||
| compareFilters: "<nil>", | ||
| } | ||
| ijHelper := testAnalyzeLookUpFilters(t, ijCtx, ijCase) | ||
| checkRangeFallbackAndReset(t, ctx, false) | ||
| ijCase.rangeMaxSize = ijHelper.chosenRanges.Range().MemUsage() - 1 | ||
| ijCase.ranges = "[[1 NULL \"aa\",1 NULL \"aa\"] [1 NULL \"bb\",1 NULL \"bb\"] [3 NULL \"aa\",3 NULL \"aa\"] [3 NULL \"bb\",3 NULL \"bb\"]]" | ||
| ijCase.idxOff2KeyOff = "[-1 0 -1 -1 -1]" | ||
| ijHelper = testAnalyzeLookUpFilters(t, ijCtx, ijCase) | ||
| checkRangeFallbackAndReset(t, ctx, true) |
There was a problem hiding this comment.
Can we use table drive here to make code clear
Yisaer
approved these changes
Sep 29, 2022
time-and-fate
approved these changes
Sep 30, 2022
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 767d720
|
ti-chi-bot
added
the
status/can-merge
|
/run-check_dev_2 |
TiDB MergeCI notify✅ Well Done! New fixed [1] after this pr merged.
|
morgo
added a commit
to morgo/tidb
that referenced
this pull request
Oct 4, 2022
…mprovements * upstream/master: (56 commits) expression: make a copy when retrieving json path expression from cache (pingcap#38285) executor: make unit test TestIssue21732 stable (pingcap#38278) variables: enable variable hook to access storage (pingcap#38227) docs: update roadmap description (pingcap#38253) systable: Adapt with TiFlash system table update (pingcap#38191) planner, util/ranger: restrict mem usage for index join inner ranges (pingcap#38129) planner: separate cost model ver1/ver2 into different files (part 2) (pingcap#38273) metrics: Add IOPs, Disk Throughput to the overview dashboard (pingcap#38270) planner: refine index join range display for clustered index (pingcap#38259) *: delete `mInFlashbackCluster` related codes (pingcap#38241) session: turn the transaction to pessimistic mode when retrying (pingcap#38130) executor: enable race for executor/aggfuncs (pingcap#38262) planner: reopen CTE in apply only when correlate (pingcap#38214) planner: enable revive (pingcap#36649) *: add foreign key constraint check when execute update statement (pingcap#38156) *: DATA RACE in the temptable.AttachLocalTemporaryTableInfoSchema (pingcap#38237) executor,sessionctx: enable coprocessor paging and make TestCoprocessorPagingSize stable (pingcap#38161) domain: fix data race in the Domain.bindHandle (pingcap#38223) test: add information if test failed (pingcap#38234) preprocessor, planner: inline processing by default for single-consumer cte (pingcap#37800) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #37176
Problem Summary:
What is changed and how it works?
Restrict mem usage for index join inner ranges. Part 4 of #37176.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.