Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

variables: enable variable hook to access storage #38227

Merged
merged 2 commits into from
Sep 30, 2022
Merged

variables: enable variable hook to access storage #38227

merged 2 commits into from
Sep 30, 2022

Conversation

YangKeao
Copy link
Member

Signed-off-by: YangKeao yangkeao@chunibyo.icu

What problem does this PR solve?

This PR enables variable hooks to access storage.

Issue Number: close #38225

Problem Summary:

As described in #38225, current system variable cannot call pd services in the hook, which is just needed by the external-timestamp-read feature.

What is changed and how it works?

Add a new interface HookEvent (which has already been implemented by session), and assign it to the SessionVars.

The only concern is about the cycle initialization. It's ugly and tiring.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@YangKeao YangKeao requested a review from a team as a code owner September 28, 2022 10:15
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 28, 2022
@YangKeao YangKeao force-pushed the add-session-context-to-variable-hook branch from 94c627c to e4b9ea0 Compare September 28, 2022 10:24
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 29, 2022
@YangKeao YangKeao added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 29, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 29, 2022
@YangKeao YangKeao force-pushed the add-session-context-to-variable-hook branch from e4b9ea0 to 61dc300 Compare September 29, 2022 09:46
@YangKeao
define and add HookContext for sessionVars
ce1fdb9 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao YangKeao force-pushed the add-session-context-to-variable-hook branch from 61dc300 to ce1fdb9 Compare September 29, 2022 11:31
@YangKeao
Copy link
Member Author

YangKeao commented Sep 29, 2022 •
edited
Loading

/test

@YangKeao
Copy link
Member Author

/run-all-tests

bb7133
bb7133 approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 30, 2022
@YangKeao
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@YangKeao: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@YangKeao
Copy link
Member Author

@xhe @bb7133 Could you help me to /merge this PR?

@YangKeao YangKeao mentioned this pull request Sep 30, 2022
Merged
20 tasks
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ce1fdb9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 30, 2022
@ti-chi-bot ti-chi-bot merged commit 5c4b328 into pingcap:master Sep 30, 2022
@morgo
Copy link
Contributor

morgo commented Oct 4, 2022

I don't think this is required. See #38182 for an example on how to access storage.

If the Setter func calls a noop, you can overwrite the noop from another part of code (such as domain) to have the required context.

morgo added a commit to morgo/tidb that referenced this pull request Oct 4, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into sessionctx-code-i…
06bcee9 
…mprovements

* upstream/master: (56 commits)
  expression: make a copy when retrieving json path expression from cache (pingcap#38285)
  executor: make unit test TestIssue21732 stable (pingcap#38278)
  variables: enable variable hook to access storage (pingcap#38227)
  docs: update roadmap description (pingcap#38253)
  systable: Adapt with TiFlash system table update (pingcap#38191)
  planner, util/ranger: restrict mem usage for index join inner ranges (pingcap#38129)
  planner: separate cost model ver1/ver2 into different files (part 2) (pingcap#38273)
  metrics: Add IOPs, Disk Throughput to the overview dashboard (pingcap#38270)
  planner: refine index join range display for clustered index (pingcap#38259)
  *: delete `mInFlashbackCluster` related codes (pingcap#38241)
  session: turn the transaction to pessimistic mode when retrying (pingcap#38130)
  executor: enable race for executor/aggfuncs (pingcap#38262)
  planner: reopen CTE in apply only when correlate (pingcap#38214)
  planner: enable revive (pingcap#36649)
  *: add foreign key constraint check when execute update statement (pingcap#38156)
  *: DATA RACE in the temptable.AttachLocalTemporaryTableInfoSchema (pingcap#38237)
  executor,sessionctx: enable coprocessor paging and make TestCoprocessorPagingSize stable (pingcap#38161)
  domain: fix data race in the Domain.bindHandle (pingcap#38223)
  test: add information if test failed (pingcap#38234)
  preprocessor, planner: inline processing by default for single-consumer cte (pingcap#37800)
  ...
@YangKeao YangKeao mentioned this pull request Oct 8, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@bb7133 bb7133 bb7133 approved these changes

@lcwangchao lcwangchao Awaiting requested review from lcwangchao

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enable variable hook to access store
6 participants
@YangKeao @ti-chi-bot @hawkingrei @morgo @bb7133 @xhebox