add basic support for duplicate code and extract procedure #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re-upload When user uploads project file, project will auto-save before loading
…ent-error Fix "TouchEvent is not defined" error
Make the requiredProjectId work with the online editor
This was intended as a safety check but it causes problems with some tests.
Add a helper function to check if GUI is running in Scratch Desktop
…ibrary-update-fixes Sprite and costume library fixes
Show error ID if available from Raven and report react errors
…torage Update scratch-storage package
…add-city-and-bedroom-assets Add city and bedroom assets
They were not being marked as clean when loaded from the server, causing remixes that included only minimal (or no) changes to take a very long time as it waited for hundreds of network requests to resolve. Mark them as clean when loaded from the server so we know they do not need to be resaved
This prevents unnecassary changes that do not matter to the player view because they were made by the project in progress (i.e. made by running the blocks, or by cloud var updates)
This is because when switching from project to editor view, this component gets unmounted and then remounted, but the componentDidMount seems to happen before the componentWillUnmount. Because it is dealing with a global variable, it is unsafe to always unset the beforeunload when unmounting.
…-select Revert "Adds BorderedMenuItem and use it for delete menu"
The previous change that made the images laid out using absolute meant that the close button was layered below the sprite image, making it now clickable
…button Fix delete button on sprite tiles
…ocks update scratch-blocks for languages.
…h-l10n-3.1.20190117191816 Update scratch-l10n to the latest version 🚀
…k-squishes Fix backpack squishing
We were emitting drops when getMouseOverIndex was null, which could happen either when the drop is outside the container, or there were zero boxes to check for ordering. Treat these two cases separately, and continue to not emit drops when outside the container.
…eord Fix sound reorder crash
…-4359-delete-select Add BorderedMenuItem and use it for delete menu, with updated style
…connect-errors Peripheral disconnect status using new runtime/vm event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.