hardware_interface: fix C++20 structured-binding capture in lambda (fixes #2574) #2832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
LukasMacha97,
bmagyar,
christophfroehlich,
mcbed,
mhubii,
moriarty and
xguay
christophfroehlich
added
the
backport-kilted
christophfroehlich
requested changes
Nov 19, 2025
Member
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
I see this pattern four times in this file, can you please fix them all at once?
saikishor
reviewed
Nov 19, 2025
Member
saikishor
left a comment
saikishor
left a comment
There was a problem hiding this comment.
Too advanced hahaha
I added it as the GCC supported it from 22.04 on. Sure, let's change it
Contributor
Author
|
@christophfroehlich I'm only finding one occurrence of a structured binding capture within a lambda. Could you please clarify if you mean structured bindings in general that should be fixed, or if there's a different pattern I'm missing? |
christophfroehlich
approved these changes
Nov 19, 2025
Member
There was a problem hiding this comment.
I just looked for the & [hw_name, limiters] : pattern, but the problem is the lambda capture which happens only once. sorry for the confusion
christophfroehlich
merged commit 1757bd1
into
ros-controls:master
17 of 18 checks passed
mergify bot
pushed a commit
that referenced
this pull request
Nov 19, 2025
(cherry picked from commit 1757bd1)
mergify bot
pushed a commit
that referenced
this pull request
Nov 19, 2025
(cherry picked from commit 1757bd1)
This was referenced Nov 19, 2025
christophfroehlich
pushed a commit
that referenced
this pull request
Nov 19, 2025
christophfroehlich
pushed a commit
that referenced
this pull request
Nov 19, 2025
robkwan
pushed a commit
to robkwan/ros2_control
that referenced
this pull request
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
-Wc++20-extensionswarning triggered by capturing a structured binding in a lambda.ROS 2 still targets C++17 only (REP-2000). Capturing structured bindings directly is a C++20 extension, so we avoid it by using
.secondexplicitly instead. The unused first element (hw_name / entry.first) is omitted to avoid the separate -Wunused-variable warning/error.No functional change.
Fixes #2574
Tested locally:
colcon build --packages-select hardware_interfacecolcon test --packages-select hardware_interface- all tests pass