Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JTC] Import docs from wiki.ros.org #566

Merged
merged 14 commits into from
May 9, 2023
Merged

[JTC] Import docs from wiki.ros.org #566

merged 14 commits into from
May 9, 2023

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Apr 8, 2023 •
edited
Loading

I found some useful documentation on wiki.ros.org, which I think is still correct for ROS 2. I added the information with citation to the original source.

I was not sure if the ROS 2 implementation has the same behavior on some details, see comments below.

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2023 •
edited
Loading

Codecov Report

Merging #566 (daaff71) into master (e7f9962) will decrease coverage by 3.31%.
The diff coverage is 26.60%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #566      +/-   ##
==========================================
- Coverage   35.78%   32.48%   -3.31%     
==========================================
  Files         189        7     -182     
  Lines       17570      665   -16905     
  Branches    11592      357   -11235     
==========================================
- Hits         6287      216    -6071     
+ Misses        994      157     -837     
+ Partials    10289      292    -9997
Flag Coverage Δ
unittests 32.48% <26.60%> (-3.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontroller/test/test_load_diff_drive_controller.cpp 12.50% <0.00%> (ø)
diff_drive_controller/src/odometry.cpp 42.16% <11.11%> (ø)
diff_drive_controller/src/speed_limiter.cpp 46.55% <11.11%> (ø)
...ive_controller/test/test_diff_drive_controller.cpp 17.62% <12.08%> (ø)
...troller/include/diff_drive_controller/odometry.hpp 20.00% <20.00%> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 39.22% <35.50%> (ø)
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <100.00%> (ø)

... and 189 files with indirect coverage changes

destogl
destogl reviewed Apr 11, 2023
View reviewed changes
joint_trajectory_controller/doc/userdoc.rst Outdated Show resolved Hide resolved
joint_trajectory_controller/doc/userdoc.rst Outdated Show resolved Hide resolved
joint_trajectory_controller/doc/userdoc.rst Outdated Show resolved Hide resolved
joint_trajectory_controller/doc/userdoc.rst Show resolved Hide resolved
joint_trajectory_controller/doc/userdoc.rst Show resolved Hide resolved
joint_trajectory_controller/doc/userdoc.rst Outdated Show resolved Hide resolved
joint_trajectory_controller/doc/userdoc.rst Show resolved Hide resolved
joint_trajectory_controller/doc/userdoc.rst Outdated Show resolved Hide resolved
@christophfroehlich christophfroehlich mentioned this pull request Apr 16, 2023
Open
@christophfroehlich christophfroehlich marked this pull request as draft April 16, 2023 18:21
@christophfroehlich christophfroehlich mentioned this pull request Apr 16, 2023
Closed
@christophfroehlich christophfroehlich marked this pull request as ready for review April 16, 2023 22:31
@mergify
Copy link
Contributor

mergify bot commented Apr 28, 2023

This pull request is in conflict. Could you fix it @christophfroehlich?

@mergify
Copy link
Contributor

mergify bot commented Apr 29, 2023

This pull request is in conflict. Could you fix it @christophfroehlich?

destogl
destogl approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the following up!

@destogl destogl enabled auto-merge (squash) May 9, 2023 17:00
@destogl destogl merged commit 6851df1 into ros-controls:master May 9, 2023
@christophfroehlich christophfroehlich deleted the jtc_improve_docs branch May 9, 2023 17:16
@christophfroehlich christophfroehlich mentioned this pull request May 31, 2023
Merged
@bmagyar
Copy link
Member

bmagyar commented May 31, 2023

@Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented May 31, 2023 •
edited
Loading

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 31, 2023
@christophfroehlich @mergify
[JTC] Import docs from wiki.ros.org (#566)
92adbc6 
* Remove trajectory replacement doc from this PR

Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
(cherry picked from commit 6851df1)

# Conflicts:
#	joint_trajectory_controller/doc/userdoc.rst
@mergify mergify bot mentioned this pull request May 31, 2023
Merged
destogl pushed a commit that referenced this pull request May 31, 2023
@mergify @christophfroehlich
[JTC] Import docs from wiki.ros.org (backport #566) (#634)
c19c33c 
* [JTC] Import docs from wiki.ros.org (#566)

* Remove trajectory replacement doc from this PR

Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
(cherry picked from commit 6851df1)

# Conflicts:
#	joint_trajectory_controller/doc/userdoc.rst

* Fix merge conflicts (#635)

---------

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
@christophfroehlich christophfroehlich restored the jtc_improve_docs branch July 25, 2023 12:45
@christophfroehlich christophfroehlich mentioned this pull request Jul 25, 2023
Merged
@christophfroehlich christophfroehlich deleted the jtc_improve_docs branch July 25, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@destogl destogl destogl approved these changes

@bmagyar bmagyar bmagyar approved these changes

@homalozoa homalozoa Awaiting requested review from homalozoa

@jaron-l jaron-l Awaiting requested review from jaron-l

@malapatiravi malapatiravi Awaiting requested review from malapatiravi

@VX792 VX792 Awaiting requested review from VX792

@aprotyas aprotyas Awaiting requested review from aprotyas

@DasRoteSkelett DasRoteSkelett Awaiting requested review from DasRoteSkelett

@jackcenter jackcenter Awaiting requested review from jackcenter

@mcbed mcbed Awaiting requested review from mcbed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christophfroehlich @codecov-commenter @bmagyar @destogl