Suggest `;` after bare `match` expression E0308 #106601

estebank · 2023-01-08T20:24:29Z

rustbot · 2023-01-08T20:24:34Z

(rustbot has picked a reviewer for you, use r? to override)

cjgillot · 2023-01-11T16:38:23Z

src/test/ui/wf/wf-unsafe-trait-obj-match.stderr

+help: consider using a semicolon here, but this will discard any values in the match arms
+   |
+LL |     };
+   |      +


Should the suggestion be restricted to the case where all the arms have compatible types or unit?

We already have suggestions for those, but if you look at #72634 the issue comes up with a match statement with a single arm diverging to !. We could argue that we should mention "assign the match value to a let binding" or look at every match arm and suggest returning the value 🤔

JohnCSimon · 2023-04-30T03:53:30Z

@estebank Ping from triage: Can you post your status on this PR? This has sat idle for a few months.

estebank · 2023-06-17T00:58:46Z

I'm not quite sure what the next step is here, I'm not sure there's any change needed here beyond rebasing.

Fix rust-lang#72634.

cjgillot · 2023-10-21T08:38:47Z

@bors r+ rollup

bors · 2023-10-21T08:38:49Z

📌 Commit a53f280 has been approved by cjgillot

It is now in the queue for this repository.

…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#106601 (Suggest `;` after bare `match` expression E0308) - rust-lang#116975 (Move `invalid-llvm-passes` test to `invalid-compile-flags` folder) - rust-lang#117019 (fix spans for removing `.await` on `for` expressions) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#106601 - estebank:match-semi, r=cjgillot Suggest `;` after bare `match` expression E0308 Fix rust-lang#72634.

…rms, r=estebank Only point out non-diverging arms for match suggestions Fixes rust-lang#121144 There is no reason to point at diverging arms, which will always coerce to whatever is the match block's evaluated type. This also removes the suggestion from rust-lang#106601, since as I pointed out in rust-lang#72634 (comment) the added suggestion is not firing in the right cases, but instead only when one of the match arms already *actually* evaluates to `()`. r? estebank

Rollup merge of rust-lang#121146 - compiler-errors:ignore-diverging-arms, r=estebank Only point out non-diverging arms for match suggestions Fixes rust-lang#121144 There is no reason to point at diverging arms, which will always coerce to whatever is the match block's evaluated type. This also removes the suggestion from rust-lang#106601, since as I pointed out in rust-lang#72634 (comment) the added suggestion is not firing in the right cases, but instead only when one of the match arms already *actually* evaluates to `()`. r? estebank

rustbot assigned cjgillot Jan 8, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 8, 2023

cjgillot reviewed Jan 11, 2023

View reviewed changes

estebank added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 11, 2023

Suggest ; after bare match expression E0308

a53f280

Fix rust-lang#72634.

estebank force-pushed the match-semi branch from 4d3cec3 to a53f280 Compare October 11, 2023 18:52

estebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 11, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2023

matthiaskrgr mentioned this pull request Oct 21, 2023

Rollup of 3 pull requests #117020

Merged

bors merged commit 05e154f into rust-lang:master Oct 21, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 21, 2023

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 21, 2023

Unrolled build for rust-lang#106601

429245b

Rollup merge of rust-lang#106601 - estebank:match-semi, r=cjgillot Suggest `;` after bare `match` expression E0308 Fix rust-lang#72634.

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

estebank deleted the match-semi branch November 9, 2023 05:13

This was referenced Feb 15, 2024

Poor diagnostics on missing semicolon after match statement #72634

Closed

Only point out non-diverging arms for match suggestions #121146

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Suggest `;` after bare `match` expression E0308 #106601

Suggest `;` after bare `match` expression E0308 #106601

estebank commented Jan 8, 2023

rustbot commented Jan 8, 2023

cjgillot Jan 11, 2023

estebank Jan 11, 2023

JohnCSimon commented Apr 30, 2023

estebank commented Jun 17, 2023

cjgillot commented Oct 21, 2023

bors commented Oct 21, 2023

Suggest ; after bare match expression E0308 #106601

Suggest ; after bare match expression E0308 #106601

Conversation

estebank commented Jan 8, 2023

rustbot commented Jan 8, 2023

cjgillot Jan 11, 2023

Choose a reason for hiding this comment

estebank Jan 11, 2023

Choose a reason for hiding this comment

JohnCSimon commented Apr 30, 2023

estebank commented Jun 17, 2023

cjgillot commented Oct 21, 2023

bors commented Oct 21, 2023

Suggest `;` after bare `match` expression E0308 #106601

Suggest `;` after bare `match` expression E0308 #106601