Initiate the inner usage of `cfg_match` (Compiler) #116312

c410-f3r · 2023-10-01T10:51:27Z

Dogfood to test the implementation and remove dependencies.

rustbot · 2023-10-01T10:51:34Z

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-10-01T10:51:37Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

c410-f3r · 2023-10-01T10:51:52Z

compiler/rustc_data_structures/src/lib.rs

+#![allow(internal_features)]
+#![allow(rustc::default_hash_types)]
+#![allow(rustc::potential_query_instability)]
+#![deny(rustc::diagnostic_outside_of_impl)]
+#![deny(rustc::untranslatable_diagnostic)]
+#![deny(unsafe_op_in_unsafe_fn)]
 #![doc(html_root_url = "https://doc.rust-lang.org/nightly/nightly-rustc/")]
+#![feature(allocator_api)]
 #![feature(array_windows)]
 #![feature(associated_type_bounds)]
 #![feature(auto_traits)]
 #![feature(cell_leak)]
+#![feature(cfg_match)]
 #![feature(core_intrinsics)]
 #![feature(extend_one)]
+#![feature(get_mut_unchecked)]
 #![feature(hash_raw_entry)]
 #![feature(hasher_prefixfree_extras)]
+#![feature(lazy_cell)]
+#![feature(lint_reasons)]
+#![feature(macro_metavar_expr)]
 #![feature(maybe_uninit_uninit_array)]
 #![feature(min_specialization)]
+#![feature(negative_impls)]
 #![feature(never_type)]
-#![feature(type_alias_impl_trait)]
 #![feature(new_uninit)]
-#![feature(lazy_cell)]
+#![feature(ptr_alignment_type)]
 #![feature(rustc_attrs)]
-#![feature(negative_impls)]
+#![feature(strict_provenance)]
 #![feature(test)]
 #![feature(thread_id_value)]
-#![feature(vec_into_raw_parts)]
-#![feature(allocator_api)]
-#![feature(get_mut_unchecked)]
-#![feature(lint_reasons)]
+#![feature(type_alias_impl_trait)]
 #![feature(unwrap_infallible)]
-#![feature(strict_provenance)]
-#![feature(ptr_alignment_type)]
-#![feature(macro_metavar_expr)]
-#![allow(rustc::default_hash_types)]
-#![allow(rustc::potential_query_instability)]
-#![deny(rustc::untranslatable_diagnostic)]
-#![deny(rustc::diagnostic_outside_of_impl)]
-#![allow(internal_features)]
-#![deny(unsafe_op_in_unsafe_fn)]


Alphabetical order

is it worth a tidy-alphabetical comment?

c410-f3r · 2023-10-01T10:53:16Z

compiler/rustc_data_structures/src/marker.rs

-        cfg_if!(
-            // Consistent with `std`
-            // `os_imp::Env` is `!Send` in these platforms
-            if #[cfg(any(unix, target_os = "hermit", target_os = "wasi", target_os = "solid_asp3"))] {
-                impl !DynSend for std::env::VarsOs {}
-            }
-        );


Unnecessary

c410-f3r · 2023-10-01T10:53:18Z

compiler/rustc_span/src/lib.rs

+#![allow(internal_features)]
+#![deny(rustc::diagnostic_outside_of_impl)]
+#![deny(rustc::untranslatable_diagnostic)]
 #![doc(html_root_url = "https://doc.rust-lang.org/nightly/nightly-rustc/")]
 #![feature(array_windows)]
+#![feature(cfg_match)]
 #![feature(if_let_guard)]
-#![feature(negative_impls)]
-#![feature(min_specialization)]
-#![feature(rustc_attrs)]
 #![feature(let_chains)]
-#![feature(round_char_boundary)]
-#![feature(read_buf)]
+#![feature(min_specialization)]
+#![feature(negative_impls)]
 #![feature(new_uninit)]
-#![deny(rustc::untranslatable_diagnostic)]
-#![deny(rustc::diagnostic_outside_of_impl)]
-#![allow(internal_features)]
+#![feature(read_buf)]
+#![feature(round_char_boundary)]
+#![feature(rustc_attrs)]


Alphabetical order

c410-f3r · 2023-10-08T14:08:20Z

r? compiler

b-naber · 2023-10-13T11:37:30Z

@bors r+ rollup

bors · 2023-10-13T11:37:33Z

📌 Commit e4f3f3c has been approved by b-naber

It is now in the queue for this repository.

Initiate the inner usage of `cfg_match` (Compiler) cc rust-lang#115585 Dogfood to test the implementation and remove dependencies.

matthiaskrgr · 2023-10-14T11:47:37Z

@bors r- I think this fails in tidy

bors · 2023-10-17T07:20:21Z

☔ The latest upstream changes (presumably #116822) made this pull request unmergeable. Please resolve the merge conflicts.

c410-f3r · 2023-10-19T22:12:31Z

Should be good now

Mark-Simulacrum · 2023-10-21T17:51:58Z

@bors r+

bors · 2023-10-21T17:52:01Z

📌 Commit 6379013 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#116312 (Initiate the inner usage of `cfg_match` (Compiler)) - rust-lang#116928 (fix bootstrap paths in triagebot.toml) - rust-lang#116955 (Updated README with expandable table of content.) - rust-lang#116981 (update the registers of csky target) - rust-lang#116992 (Mention the syntax for `use` on `mod foo;` if `foo` doesn't exist) - rust-lang#117026 (Fix broken link to Ayu theme in the rustdoc book) - rust-lang#117028 (Remove unnecessary `all` in Box) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116312 - c410-f3r:try, r=Mark-Simulacrum Initiate the inner usage of `cfg_match` (Compiler) cc rust-lang#115585 Dogfood to test the implementation and remove dependencies.

Initiate the inner usage of `cfg_match` (Library) cc rust-lang#115585 Continuation of rust-lang#116312

Initiate the inner usage of `cfg_match` (Library) cc rust-lang#115585 Continuation of rust-lang#116312

rustbot assigned wesleywiser Oct 1, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 1, 2023

c410-f3r force-pushed the try branch from ab0c07a to a09249c Compare October 1, 2023 10:52

c410-f3r commented Oct 1, 2023

View reviewed changes

c410-f3r force-pushed the try branch 2 times, most recently from 3f566d2 to e4f3f3c Compare October 1, 2023 21:27

c410-f3r mentioned this pull request Oct 2, 2023

Initiate the inner usage of cfg_match (Library) #116342

Closed

rustbot assigned b-naber and unassigned wesleywiser Oct 8, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2023

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 13, 2023

Rollup merge of rust-lang#116312 - c410-f3r:try, r=b-naber

95ebc01

Initiate the inner usage of `cfg_match` (Compiler) cc rust-lang#115585 Dogfood to test the implementation and remove dependencies.

matthiaskrgr mentioned this pull request Oct 13, 2023

Rollup of 3 pull requests #116694

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 14, 2023

Rollup merge of rust-lang#116312 - c410-f3r:try, r=b-naber

97a9f6e

Initiate the inner usage of `cfg_match` (Compiler) cc rust-lang#115585 Dogfood to test the implementation and remove dependencies.

matthiaskrgr mentioned this pull request Oct 14, 2023

Rollup of 6 pull requests #116726

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 14, 2023

c410-f3r force-pushed the try branch from e4f3f3c to 6788aa3 Compare October 19, 2023 22:12

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 19, 2023

This comment has been minimized.

Sign in to view

Initiate the inner usage of cfg_match

6379013

c410-f3r force-pushed the try branch from 6788aa3 to 6379013 Compare October 19, 2023 23:19

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 21, 2023

matthiaskrgr mentioned this pull request Oct 21, 2023

Rollup of 7 pull requests #117030

Merged

bors merged commit d6ac149 into rust-lang:master Oct 21, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 21, 2023

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 22, 2023

Auto merge of rust-lang#116342 - c410-f3r:t3st3ss, r=Mark-Simulacrum

66ab7f4

Initiate the inner usage of `cfg_match` (Library) cc rust-lang#115585 Continuation of rust-lang#116312

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 18, 2024

Auto merge of rust-lang#116342 - c410-f3r:t3st3ss, r=Mark-Simulacrum

643f375

Initiate the inner usage of `cfg_match` (Library) cc rust-lang#115585 Continuation of rust-lang#116312

CKingX added a commit to CKingX/rust that referenced this pull request Feb 18, 2024

Rollup merge of rust-lang#116342 - c410-f3r:t3st3ss, r=Mark-Simulacrum

2a438a6

Initiate the inner usage of `cfg_match` (Library) cc rust-lang#115585 Continuation of rust-lang#116312

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 19, 2024

Auto merge of rust-lang#116342 - c410-f3r:t3st3ss, r=Mark-Simulacrum

b95bc4b

Initiate the inner usage of `cfg_match` (Library) cc rust-lang#115585 Continuation of rust-lang#116312

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initiate the inner usage of `cfg_match` (Compiler) #116312

Initiate the inner usage of `cfg_match` (Compiler) #116312

c410-f3r commented Oct 1, 2023

rustbot commented Oct 1, 2023

rustbot commented Oct 1, 2023

c410-f3r Oct 1, 2023

fbstj Oct 1, 2023

c410-f3r Oct 1, 2023

c410-f3r Oct 1, 2023

c410-f3r Oct 1, 2023

c410-f3r commented Oct 8, 2023

b-naber commented Oct 13, 2023

bors commented Oct 13, 2023

matthiaskrgr commented Oct 14, 2023

bors commented Oct 17, 2023

c410-f3r commented Oct 19, 2023

This comment has been minimized.

Mark-Simulacrum commented Oct 21, 2023

bors commented Oct 21, 2023

Initiate the inner usage of cfg_match (Compiler) #116312

Initiate the inner usage of cfg_match (Compiler) #116312

Conversation

c410-f3r commented Oct 1, 2023

rustbot commented Oct 1, 2023

rustbot commented Oct 1, 2023

c410-f3r Oct 1, 2023

Choose a reason for hiding this comment

fbstj Oct 1, 2023

Choose a reason for hiding this comment

c410-f3r Oct 1, 2023

Choose a reason for hiding this comment

c410-f3r Oct 1, 2023

Choose a reason for hiding this comment

c410-f3r Oct 1, 2023

Choose a reason for hiding this comment

c410-f3r commented Oct 8, 2023

b-naber commented Oct 13, 2023

bors commented Oct 13, 2023

matthiaskrgr commented Oct 14, 2023

bors commented Oct 17, 2023

c410-f3r commented Oct 19, 2023

This comment has been minimized.

Mark-Simulacrum commented Oct 21, 2023

bors commented Oct 21, 2023

Initiate the inner usage of `cfg_match` (Compiler) #116312

Initiate the inner usage of `cfg_match` (Compiler) #116312