Rollup of 4 pull requests #117041

matthiaskrgr · 2023-10-22T07:15:43Z

Successful merges:

Use gdb.ValuePrinter tag class #116985 (Use gdb.ValuePrinter tag class)
Skip test if Unix sockets are unsupported #116989 (Skip test if Unix sockets are unsupported)
Don't crash on empty match in the nonexhaustive_omitted_patterns lint #117034 (Don't crash on empty match in the nonexhaustive_omitted_patterns lint)
rustdoc book doc example error #117037 (rustdoc book doc example error)

r? @ghost
@rustbot modify labels: rollup

GDB 14 has a "gdb.ValuePrinter" tag class that was introduced to let GDB evolve the pretty-printer API. Users of this tag are required to hide any local attributes or methods. This patch makes this change to the Rust pretty-printers. At present this is just a cleanup, providing the basis for any future changes.

Fixes the second example in the Examples section of what-to-include.md by marking main as a function.

…mulacrum Use gdb.ValuePrinter tag class GDB 14 has a "gdb.ValuePrinter" tag class that was introduced to let GDB evolve the pretty-printer API. Users of this tag are required to hide any local attributes or methods. This patch makes this change to the Rust pretty-printers. At present this is just a cleanup, providing the basis for any future changes.

…rk-Simulacrum Skip test if Unix sockets are unsupported Fixes rust-lang#116683 (comment) The test will be skipped if `AF_UNIX` is not supported. In that case [`WSASocketW` returns `WSAEAFNOSUPPORT`](https://learn.microsoft.com/en-us/windows/win32/api/winsock2/nf-winsock2-wsasocketw#return-value). It will never skip the test when run in CI but maybe this is me being too defensive since the error code is narrowly scoped to just the af family parameter being unsupported? Also fixed a minor typo. r? `@Mark-Simulacrum`

Don't crash on empty match in the `nonexhaustive_omitted_patterns` lint Oops Fixes rust-lang#117033

…t_example, r=notriddle rustdoc book doc example error closes rust-lang#117036 This is the minimal change required to make the second what-to-include.md example valid. Another more modern solution could be considered: ``` /// Example /// ```rust /// let fortytwo = "42".parse::<u32>()?; /// println!("{} + 10 = {}", fortytwo, fortytwo+10); /// # Ok::<(), <u32 as std::str::FromStr>::Err>(()) /// ``` ```

matthiaskrgr · 2023-10-22T07:16:08Z

@bors r+ rollup=never p=4

bors · 2023-10-22T07:16:10Z

📌 Commit 77d8a73 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2023-10-22T08:09:43Z

⌛ Testing commit 77d8a73 with merge 724ba7f...

bors · 2023-10-22T10:03:46Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 724ba7f to master...

rust-timer · 2023-10-22T10:04:55Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#116985	Use gdb.ValuePrinter tag class	`52a0548ae0fb50680d503578dc9ea73474720b1d` (link)
#116989	Skip test if Unix sockets are unsupported	`9a4b045c665010144ccdb79a227ea3fab54be179` (link)
#117034	Don't crash on empty match in the `nonexhaustive_omitted_pa…	`b824f1d8f71ff1ea066d6b094498811b2a5e85e6` (link)
#117037	rustdoc book doc example error	`b37142cb900781df3a65ee4fe93d90a01855c9c2` (link)

previous master: 3932c87718

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-10-22T15:51:23Z

Finished benchmarking commit (724ba7f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.0%	[-1.0%, -1.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.0%	[-1.0%, -1.0%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 630.192s -> 631.246s (0.17%)
Artifact size: 304.05 MiB -> 304.08 MiB (0.01%)

tromey and others added 8 commits October 20, 2023 10:49

Skip test if Unix sockets are unsupported

46f68cc

Fix rust-lang#117033

a134f16

fix what-to-include doc example

6596270

Fixes the second example in the Examples section of what-to-include.md by marking main as a function.

Rollup merge of rust-lang#117034 - Nadrieril:fix-117033, r=cjgillot

4681eb6

Don't crash on empty match in the `nonexhaustive_omitted_patterns` lint Oops Fixes rust-lang#117033

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 22, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 22, 2023

bors merged commit 724ba7f into rust-lang:master Oct 22, 2023
12 checks passed

rustbot added this to the 1.75.0 milestone Oct 22, 2023

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

matthiaskrgr deleted the rollup-b18h0ln branch March 16, 2024 18:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 4 pull requests #117041

Rollup of 4 pull requests #117041

matthiaskrgr commented Oct 22, 2023

matthiaskrgr commented Oct 22, 2023

bors commented Oct 22, 2023

bors commented Oct 22, 2023

bors commented Oct 22, 2023

rust-timer commented Oct 22, 2023

rust-timer commented Oct 22, 2023

Rollup of 4 pull requests #117041

Rollup of 4 pull requests #117041

Conversation

matthiaskrgr commented Oct 22, 2023

matthiaskrgr commented Oct 22, 2023

bors commented Oct 22, 2023

bors commented Oct 22, 2023

bors commented Oct 22, 2023

rust-timer commented Oct 22, 2023

rust-timer commented Oct 22, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size