Print variadic argument pattern in HIR pretty printer #117147

DaniPopes · 2023-10-24T23:13:10Z

Variadic argument name/pattern was ignored during HIR pretty printing.
Could not figure out why it only works on normal functions (va2) and not in foreign ones (va1).

rustbot · 2023-10-24T23:13:18Z

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

compiler-errors · 2023-10-25T15:17:42Z

Could not figure out why it only works on normal functions (va2) and not in foreign ones (va1)

Please modify lower_fn_params_to_names in rustc_ast_lowering to stop skipping the c_variadic parameter name. I think that skipping logic is unnecessary.

compiler-errors · 2023-10-25T15:25:48Z

@rustbot author

DaniPopes · 2023-10-25T16:20:43Z

@rustbot ready

compiler-errors · 2023-10-29T19:21:55Z

@bors r+

bors · 2023-10-29T19:21:57Z

📌 Commit 6aead74 has been approved by compiler-errors

It is now in the queue for this repository.

Rollup of 8 pull requests Successful merges: - rust-lang#117147 (Print variadic argument pattern in HIR pretty printer) - rust-lang#117177 (Use ImageDataType for allocation type) - rust-lang#117205 (Allows `#[diagnostic::on_unimplemented]` attributes to have multiple) - rust-lang#117350 (coverage: Replace manual debug indents with nested tracing spans in `counters`) - rust-lang#117365 (Stabilize inline asm usage with rustc_codegen_cranelift) - rust-lang#117371 (Ignore RPIT duplicated lifetimes in `opaque_types_defined_by`) - rust-lang#117382 (Fail typeck for illegal break-with-value) - rust-lang#117385 (deduce_param_attrs: explain a read-only case) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#117147 - DaniPopes:pphir-fn-variadic, r=compiler-errors Print variadic argument pattern in HIR pretty printer Variadic argument name/pattern was ignored during HIR pretty printing. Could not figure out why it only works on normal functions (`va2`) and not in foreign ones (`va1`).

rustbot assigned cjgillot Oct 24, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 24, 2023

compiler-errors self-assigned this Oct 25, 2023

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2023

DaniPopes added 2 commits October 25, 2023 17:36

Print variadic argument pattern in HIR pretty printer

2c1dbed

Remove unnecessary CVarArgs name skipping logic

6aead74

DaniPopes force-pushed the pphir-fn-variadic branch from 94848f7 to 6aead74 Compare October 25, 2023 15:44

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 25, 2023

cjgillot removed their assignment Oct 25, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2023

fmease mentioned this pull request Oct 30, 2023

Rollup of 8 pull requests #117387

Merged

bors merged commit 2915707 into rust-lang:master Oct 30, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 30, 2023

DaniPopes deleted the pphir-fn-variadic branch October 30, 2023 15:09

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Print variadic argument pattern in HIR pretty printer #117147

Print variadic argument pattern in HIR pretty printer #117147

DaniPopes commented Oct 24, 2023

rustbot commented Oct 24, 2023

compiler-errors commented Oct 25, 2023

compiler-errors commented Oct 25, 2023

DaniPopes commented Oct 25, 2023

compiler-errors commented Oct 29, 2023

bors commented Oct 29, 2023

Print variadic argument pattern in HIR pretty printer #117147

Print variadic argument pattern in HIR pretty printer #117147

Conversation

DaniPopes commented Oct 24, 2023

rustbot commented Oct 24, 2023

compiler-errors commented Oct 25, 2023

compiler-errors commented Oct 25, 2023

DaniPopes commented Oct 25, 2023

compiler-errors commented Oct 29, 2023

bors commented Oct 29, 2023