Improve the warning messages for the #[diagnostic::on_unimplemented]
#116931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Urgau
reviewed
Oct 19, 2023
There was a problem hiding this comment.
Diagnostics should not start with a Upper case.
There is some guidelines on the rustc-dev-guide https://rustc-dev-guide.rust-lang.org/diagnostics.html#suggestion-style-guide but unfortunatly not enough.
This commit improves warnings emitted for malformed on unimplemented attributes by: * Improving the span of the warnings * Adding a label message to them * Separating the messages for missing and unexpected options * Adding a help message that says which options are supported
weiznich
force-pushed
the
improve_diagnostic_on_unimplemented_warnings
branch
from
6dfbcee to
9017b97
Compare
| LL | | note = "not used yet" | ||
| LL | | )] | ||
| | |__^ | ||
| | |__^ invalid option found here |
There was a problem hiding this comment.
Should be able to point at the if(Self = ()) here.
There was a problem hiding this comment.
I've pushed a "fix" to address this somewhat. The problem there is that if(Self = ()) doesn't parse as meta_item_list(). I'm not sure why that's the case or whether that's the right behavior. The pushed "fix" just turns the attribute into something that can be parsed (if(Self = "()") in that case).
|
@bors r+ |
bors
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves warnings emitted for malformed on unimplemented attributes by:
r? @compiler-errors
I'm happy to work on further improvements, so feel free to make suggestions.