-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contact Form not sending when email is updated #778
Comments
Under Settings -> Account -> Contact email and Contact email to. We've used
both because we're not sure what the difference is between them.
…On Mon, Oct 9, 2023, 3:24 PM Shana Moore ***@***.***> wrote:
@ndroark <https://github.com/ndroark> Could you confirm where you are
setting these contact emails?
—
Reply to this email directly, view it on GitHub
<#778 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4DJKR5RRN4CHL7W5MQL2B3X6RFOBAVCNFSM6AAAAAA4TTFVPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJTGU3DQMBVG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
tldr; this isn't a bug and is working as expected. We can't change the email from to anything we want, it must come from an approved list. Hi @ndroark We've since discovered that there is an allow list in aws's SES. This is the list of approved emails/domains that you can send emails from. If a tenant wants to send an email beyond any of these domains, we'd have to set it up in the backend and would need their SMTP configuration options. Unfortunately there is no UI for them to set this up themselves. |
So would the workflow simply be that when a user from a new domain (such as
anderson.edu) changes the contact email to their address, they contact us
(PALs) and we contact you (SoftServ) to make that change? Is any additional
information required beyond the domain of their email address?
<https://anderson.edu/>
NIC DON STANTON-ROARK
Archivist
Nicholson Library
o: 765.641.4285
He/Him
This message contains confidential information and is intended only for the
individual named. If you are not the named addressee you should not
disseminate, distribute or copy this email. Please notify the sender
immediately by email if you have received this email by mistake and delete
this email from your system.
…On Mon, Oct 9, 2023 at 4:24 PM Shana Moore ***@***.***> wrote:
Hi @ndroark <https://github.com/ndroark> We've since discovered that
there is an allow list in aws's SES. This is the list of approved
emails/domains. If a tenant wants to send an email beyond any of these
domains, we'd have to set it up in their console and would need the SMTP
configuration options.
[image: Image]
<https://user-images.githubusercontent.com/10081604/273690402-8040960a-f03e-4da7-8357-8cb2b717c403.png>
—
Reply to this email directly, view it on GitHub
<#778 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4DJKR73OTXG5BWOWKTI33LX6RMPXAVCNFSM6AAAAAA4TTFVPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJTG4ZDEMJRGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Or as a maintenance item, could we simply add all our current institutional
domains in one ticket, and then add new institutions as soon as they come
on board? Is there a possibility in the future that we could make this
configurable from the superadmin side so it doesn't require dev
intervention?
<https://anderson.edu/>
NIC DON STANTON-ROARK
Archivist
Nicholson Library
o: 765.641.4285
He/Him
This message contains confidential information and is intended only for the
individual named. If you are not the named addressee you should not
disseminate, distribute or copy this email. Please notify the sender
immediately by email if you have received this email by mistake and delete
this email from your system.
On Mon, Oct 9, 2023 at 4:29 PM Nic Stanton-Roark ***@***.***>
wrote:
… So would the workflow simply be that when a user from a new domain (such
as anderson.edu) changes the contact email to their address, they contact
us (PALs) and we contact you (SoftServ) to make that change? Is any
additional information required beyond the domain of their email address?
<https://anderson.edu/>
NIC DON STANTON-ROARK
Archivist
Nicholson Library
o: 765.641.4285
He/Him
This message contains confidential information and is intended only for
the individual named. If you are not the named addressee you should not
disseminate, distribute or copy this email. Please notify the sender
immediately by email if you have received this email by mistake and delete
this email from your system.
On Mon, Oct 9, 2023 at 4:24 PM Shana Moore ***@***.***>
wrote:
> Hi @ndroark <https://github.com/ndroark> We've since discovered that
> there is an allow list in aws's SES. This is the list of approved
> emails/domains. If a tenant wants to send an email beyond any of these
> domains, we'd have to set it up in their console and would need the SMTP
> configuration options.
>
> [image: Image]
> <https://user-images.githubusercontent.com/10081604/273690402-8040960a-f03e-4da7-8357-8cb2b717c403.png>
>
> —
> Reply to this email directly, view it on GitHub
> <#778 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/A4DJKR73OTXG5BWOWKTI33LX6RMPXAVCNFSM6AAAAAA4TTFVPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJTG4ZDEMJRGA>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
So would the workflow simply be that when a user from a new domain (such as anderson.edu) changes the contact email to their address, they contact us (PALs) and we contact you (SoftServ) to make that change?
Is any additional information required beyond the domain of their email address?
Or as a maintenance item, could we simply add all our current institutional domains in one ticket, and then add new institutions as soon as they come on board?
Is there a possibility in the future that we could make this configurable from the super admin side so it doesn't require dev intervention?
|
On the SMTP configurations, how would a user at an institution get any of
that information? Does that seem like something a university IT department
would have access to?
<https://anderson.edu/>
NIC DON STANTON-ROARK
Archivist
Nicholson Library
o: 765.641.4285
He/Him
This message contains confidential information and is intended only for the
individual named. If you are not the named addressee you should not
disseminate, distribute or copy this email. Please notify the sender
immediately by email if you have received this email by mistake and delete
this email from your system.
…On Mon, Oct 9, 2023 at 4:54 PM Shana Moore ***@***.***> wrote:
*So would the workflow simply be that when a user from a new domain (such
as anderson.edu <http://anderson.edu>) changes the contact email to their
address, they contact us (PALs) and we contact you (SoftServ) to make that
change?*
- yes
*Is any additional information required beyond the domain of their email
address?*
- yes, more would required. Take a look at these configurations
<https://github.com/scientist-softserv/palni-palci/blob/main/ops/production-deploy.tmpl.yaml#L157-L170>
to get an idea of what would be needed.
*Or as a maintenance item, could we simply add all our current
institutional domains in one ticket, and then add new institutions as soon
as they come on board?*
- Yes, that could be possible. Then any email from those domains would
be approved. ie: ***@***.***
*Is there a possibility in the future that we could make this configurable
from the super admin side so it doesn't require dev intervention?*
- maybe! Speak to @jillpe <https://github.com/jillpe> about getting an
estimate of work for it. This would be something that only super admins
(like yourself) should be able to configure.
—
Reply to this email directly, view it on GitHub
<#778 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4DJKRYHKYOTCM3ZRHVL3ZTX6RP7TAVCNFSM6AAAAAA4TTFVPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJTHAZTSMZRGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
That'd probably be a good place to start. |
@ndroark thinking more about it, I think your suggestion of setting up domains for the various universities (+ adding new ones as they onboard) sounds like a more straightforward plan. That way anyone with that domain can have a valid contact email set and there would be less back and forth types of communications/wait time. We'd prob still need info from their IT but still, it'd be a one time thing vs however many would be required if we did so individually. Let us know how you'd like to proceed. Is it ok to close this ticket? |
linking relevant slack convo for tracking purposes: https://assaydepot.slack.com/archives/C0313NKC08L/p1697487952830559 |
Re work - user can't save changes to contact_email on account settings form. |
Dev Note/ TODO: |
Modify that to "the site's domain" though |
@ndroark From production we confirmed that when we updated the contact_email_to to kirk's email, he was able to receive the email that was submitted via the contact form. PS: This can only be confirmed in production. Emails do not get sent out from staging environments. This also depends on code that needs to get deployed to test that non super admins can do this |
Which were resolved via the following PRs: - scientist-softserv/palni-palci#768 - scientist-softserv/palni-palci#786 - scientist-softserv/palni-palci#790 - scientist-softserv/palni-palci#807 - scientist-softserv/palni-palci#850 - scientist-softserv/palni-palci#781 - scientist-softserv/palni-palci#787 - scientist-softserv/palni-palci#795 - scientist-softserv/palni-palci#788 - scientist-softserv/palni-palci#793 - scientist-softserv/palni-palci#782 - scientist-softserv/palni-palci#798 - scientist-softserv/palni-palci#866 - scientist-softserv/palni-palci#846 - scientist-softserv/palni-palci#849 - scientist-softserv/palni-palci#868 - scientist-softserv/palni-palci#875 - scientist-softserv/palni-palci#884 - scientist-softserv/palni-palci#876 - scientist-softserv/palni-palci#952 Contribute back the following features: - scientist-softserv/palni-palci#125 - scientist-softserv/palni-palci#740 - scientist-softserv/palni-palci#742 - scientist-softserv/palni-palci#746 - scientist-softserv/palni-palci#772 - scientist-softserv/palni-palci#773 - scientist-softserv/palni-palci#774 - scientist-softserv/palni-palci#776 - scientist-softserv/palni-palci#778 - scientist-softserv/palni-palci#839 - scientist-softserv/palni-palci#840 - scientist-softserv/palni-palci#864 Co-authored-by: Shana Moore <shana@scientist.com> Co-authored-by: Kirk Wang <kirk.wang@scientist.com>
Summary
In multiple production tenants on hykucommons.org, contact emails will not send once the email address is changed from the default to anything else. This occurs with both the "Contact email" and "Contact to email," regardless of whether they're set to the same or different addresses.
Accepted Criteria
The text was updated successfully, but these errors were encountered: