Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact Form not sending when email is updated #778

Closed
1 task
Tracked by #903
ndroark opened this issue Sep 11, 2023 · 14 comments
Closed
1 task
Tracked by #903

Contact Form not sending when email is updated #778

ndroark opened this issue Sep 11, 2023 · 14 comments
Assignees

Comments

@ndroark
Copy link
Collaborator

ndroark commented Sep 11, 2023

Summary

In multiple production tenants on hykucommons.org, contact emails will not send once the email address is changed from the default to anything else. This occurs with both the "Contact email" and "Contact to email," regardless of whether they're set to the same or different addresses.

Accepted Criteria

  • Contact emails will send to the email address specified, regardless of if it has been changed from the default
@ndroark ndroark added the bug Something isn't working label Sep 11, 2023
@crisr15 crisr15 added the maintenance bills to maintenance label Sep 19, 2023
@jillpe jillpe added October Sprint and removed maintenance bills to maintenance labels Oct 6, 2023
@ndroark
Copy link
Collaborator Author

ndroark commented Oct 9, 2023 via email

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Oct 9, 2023

tldr; this isn't a bug and is working as expected. We can't change the email from to anything we want, it must come from an approved list.

Hi @ndroark We've since discovered that there is an allow list in aws's SES. This is the list of approved emails/domains that you can send emails from. If a tenant wants to send an email beyond any of these domains, we'd have to set it up in the backend and would need their SMTP configuration options. Unfortunately there is no UI for them to set this up themselves.

Image

@ndroark
Copy link
Collaborator Author

ndroark commented Oct 9, 2023 via email

@ndroark
Copy link
Collaborator Author

ndroark commented Oct 9, 2023 via email

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Oct 9, 2023

So would the workflow simply be that when a user from a new domain (such as anderson.edu) changes the contact email to their address, they contact us (PALs) and we contact you (SoftServ) to make that change?

  • yes

Is any additional information required beyond the domain of their email address?

  • yes, more info would be required. Take a look at these configurations to get an idea of what would be needed.

Or as a maintenance item, could we simply add all our current institutional domains in one ticket, and then add new institutions as soon as they come on board?

  • Yes, that could be possible. Then any email from those domains would be approved. ie: shana@anderson.edu

Is there a possibility in the future that we could make this configurable from the super admin side so it doesn't require dev intervention?

  • maybe! Speak to @jillpe about getting an estimate of work for it. This would be something that only super admins (like yourself) should be able to configure.

@ndroark
Copy link
Collaborator Author

ndroark commented Oct 9, 2023 via email

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Oct 9, 2023

On the SMTP configurations, how would a user at an institution get any of that information? Does that seem like something a university IT department would have access to?

That'd probably be a good place to start.

@ShanaLMoore ShanaLMoore removed the bug Something isn't working label Oct 10, 2023
@ShanaLMoore
Copy link
Contributor

@ndroark thinking more about it, I think your suggestion of setting up domains for the various universities (+ adding new ones as they onboard) sounds like a more straightforward plan. That way anyone with that domain can have a valid contact email set and there would be less back and forth types of communications/wait time. We'd prob still need info from their IT but still, it'd be a one time thing vs however many would be required if we did so individually.

Let us know how you'd like to proceed.

Is it ok to close this ticket?

@ShanaLMoore
Copy link
Contributor

linking relevant slack convo for tracking purposes: https://assaydepot.slack.com/archives/C0313NKC08L/p1697487952830559

@ShanaLMoore
Copy link
Contributor

Re work - user can't save changes to contact_email on account settings form.

@ShanaLMoore
Copy link
Contributor

Image

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Oct 16, 2023

Dev Note/ TODO:
make it generic and contribute back to hyku: the sites' domain

@ndroark
Copy link
Collaborator Author

ndroark commented Oct 16, 2023

Modify that to "the site's domain" though

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Oct 17, 2023

@ndroark From production we confirmed that when we updated the contact_email_to to kirk's email, he was able to receive the email that was submitted via the contact form.

PS: This can only be confirmed in production. Emails do not get sent out from staging environments. This also depends on code that needs to get deployed to test that non super admins can do this

Image

@jillpe jillpe closed this as completed Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

5 participants