Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 PDF.js looks better in other themes #786

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

kirkkwang
Copy link
Contributor

@kirkkwang kirkkwang commented Sep 12, 2023

Originally this was developed on only the default theme and the other themes looked weird. This commit will fix that.

Story

Refs #125

Expected Behavior Before Changes

image

Expected Behavior After Changes

image

Originally this was developed on only the default theme and the other
themes looked weird.  This commit will fix that.
Copy link
Contributor

@ShanaLMoore ShanaLMoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that we could clean this up by making a method vs littering @presenter.file_set_presenters.any?(&:pdf?) in all the views.

@kirkkwang kirkkwang merged commit c0d29a8 into main Sep 12, 2023
7 checks passed
@kirkkwang kirkkwang deleted the i125-pdf-js-now-with-themes branch September 12, 2023 19:33
jeremyf pushed a commit to samvera/hyku that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants