-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve file manager and PDF.js interaction #839
Comments
Can you provide more details here? What do you you want to see here? |
Currently, the file manager isn't selecting between PDFs for display in the viewer. If there are multiple PDFs, changing the representative media/thumbnail doesn't affect which one displays in the viewer. I think the viewer displays the first uploaded or the first identified PDF associated with the work, but that may not actually be what it is doing. If there is a non-pdf work (in this case, a jpeg), you can select it as representative and the system will load the IIIF viewer to display the image, but if afterward you select a pdf as representative, the system still displays the jpeg. Ideally, the file manager should dictate what file is displayed, both in cases with multiple PDFs and no other file type, and with mixed file types. Users should be able to use the file manager to toggle between a Jpeg as representative (with the UV loading) and a PDF as representative (with whatever PDF viewer is set as default loading). |
Hi @ndroark, when you say that you want the Users to be able to use the file manager, you mean public users? Not admins? |
No, only users with edit access to a work should be able to use the file manager for that work. That is the current functionality and we don't want to change that aspect of it. |
Currently, the file manager isn't selecting between PDFs for display in the viewer. If there are multiple PDFs, changing the representative media/thumbnail doesn't affect which one displays in the viewer. This commit will add the ability for the user to change which PDF is being displayed through the file manager. Ref: - #839
SoftServ QA: https://demo.commons-archive.org/concern/generic_works/1d23ff36-15c5-4450-bf95-e01e1f83fcca?locale=en
|
Which were resolved via the following PRs: - scientist-softserv/palni-palci#768 - scientist-softserv/palni-palci#786 - scientist-softserv/palni-palci#790 - scientist-softserv/palni-palci#807 - scientist-softserv/palni-palci#850 - scientist-softserv/palni-palci#781 - scientist-softserv/palni-palci#787 - scientist-softserv/palni-palci#795 - scientist-softserv/palni-palci#788 - scientist-softserv/palni-palci#793 - scientist-softserv/palni-palci#782 - scientist-softserv/palni-palci#798 - scientist-softserv/palni-palci#866 - scientist-softserv/palni-palci#846 - scientist-softserv/palni-palci#849 - scientist-softserv/palni-palci#868 - scientist-softserv/palni-palci#875 - scientist-softserv/palni-palci#884 - scientist-softserv/palni-palci#876 - scientist-softserv/palni-palci#952 Contribute back the following features: - scientist-softserv/palni-palci#125 - scientist-softserv/palni-palci#740 - scientist-softserv/palni-palci#742 - scientist-softserv/palni-palci#746 - scientist-softserv/palni-palci#772 - scientist-softserv/palni-palci#773 - scientist-softserv/palni-palci#774 - scientist-softserv/palni-palci#776 - scientist-softserv/palni-palci#778 - scientist-softserv/palni-palci#839 - scientist-softserv/palni-palci#840 - scientist-softserv/palni-palci#864 Co-authored-by: Shana Moore <shana@scientist.com> Co-authored-by: Kirk Wang <kirk.wang@scientist.com>
Story
Currently, the file manager isn't selecting between PDFs for display in the viewer. If there are multiple PDFs, changing the representative media/thumbnail doesn't affect which one displays in the viewer.
Add the ability for the user to change which PDF is being displayed through the file manager selection.
Screenshots / Video
Screen.Recording.10-9-2023.at.2.45.PM.mp4
Testing Instructions
The following must be true before you begin:
Click on the file manager
The text was updated successfully, but these errors were encountered: