🧹 update description of contact_email and contact_to #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laritakr
approved these changes
Oct 17, 2023
ShanaLMoore
force-pushed
the
i778-follow-up
branch
from
5f394b0
to
6c7b520
Compare
This commit will update the simple_form locales to match the en version. The i18n-tasks were not working so the translations were done semi-manually with the use of ChatGPT 4.
kirkkwang
force-pushed
the
i778-follow-up
branch
from
8047dbb
to
ef5d79d
Compare
jeremyf
pushed a commit
to samvera/hyku
that referenced
this pull request
Dec 19, 2023
Which were resolved via the following PRs: - scientist-softserv/palni-palci#768 - scientist-softserv/palni-palci#786 - scientist-softserv/palni-palci#790 - scientist-softserv/palni-palci#807 - scientist-softserv/palni-palci#850 - scientist-softserv/palni-palci#781 - scientist-softserv/palni-palci#787 - scientist-softserv/palni-palci#795 - scientist-softserv/palni-palci#788 - scientist-softserv/palni-palci#793 - scientist-softserv/palni-palci#782 - scientist-softserv/palni-palci#798 - scientist-softserv/palni-palci#866 - scientist-softserv/palni-palci#846 - scientist-softserv/palni-palci#849 - scientist-softserv/palni-palci#868 - scientist-softserv/palni-palci#875 - scientist-softserv/palni-palci#884 - scientist-softserv/palni-palci#876 - scientist-softserv/palni-palci#952 Contribute back the following features: - scientist-softserv/palni-palci#125 - scientist-softserv/palni-palci#740 - scientist-softserv/palni-palci#742 - scientist-softserv/palni-palci#746 - scientist-softserv/palni-palci#772 - scientist-softserv/palni-palci#773 - scientist-softserv/palni-palci#774 - scientist-softserv/palni-palci#776 - scientist-softserv/palni-palci#778 - scientist-softserv/palni-palci#839 - scientist-softserv/palni-palci#840 - scientist-softserv/palni-palci#864 Co-authored-by: Shana Moore <shana@scientist.com> Co-authored-by: Kirk Wang <kirk.wang@scientist.com>
This was referenced Dec 19, 2023
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The account setting's descriptions for contact_email and contact_email_to are confusing. This commit adds clarity to these configuration options. c/o Palni-Palci
TODO:
BEFORE
AFTER
ref: #841 (comment)