🎁 i740 - local controlled vocabulary properties should display dropdown #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of options On the advanced search page, the controlled vocab properties currently allows the user to input whatever they want. Instead, the user should have to select an option from a dropdown.
In this commit the internal logic has been extracted into smaller methods.
In this commit we rename method subauthority? to local_authority?, moved methods from the blacklight_helper_behavior.rb to the advanced_search_helper.rb, and wrote specs.
The yard doc comments explain the purpose and function of each method, as well as the expected types of the parameters and return values. Note that the fetch_service_for method was also marked as private, as it is an internal helper method not intended for external use.
ShanaLMoore
changed the title
kirkkwang
approved these changes
Sep 15, 2023
jeremyf
added a commit
to samvera/hyku
that referenced
this pull request
Dec 19, 2023
Contribute back the following features: - scientist-softserv/palni-palci#445 - scientist-softserv/palni-palci#659 - scientist-softserv/palni-palci#740 - scientist-softserv/palni-palci#748 - scientist-softserv/palni-palci#823 - scientist-softserv/palni-palci#843 - scientist-softserv/palni-palci#844 - scientist-softserv/palni-palci#911 Which were resolved via the following PRs: - scientist-softserv/palni-palci#920 - scientist-softserv/palni-palci#704 - scientist-softserv/palni-palci#706 - scientist-softserv/palni-palci#790 - scientist-softserv/palni-palci#867 - scientist-softserv/palni-palci#874 - scientist-softserv/palni-palci#893 - scientist-softserv/palni-palci#898 - scientist-softserv/palni-palci#824 - scientist-softserv/palni-palci#923 - scientist-softserv/palni-palci#939 - scientist-softserv/palni-palci#922 - scientist-softserv/palni-palci#926 - scientist-softserv/palni-palci#927 - scientist-softserv/palni-palci#928 - scientist-softserv/palni-palci#929 - scientist-softserv/palni-palci#930 - scientist-softserv/palni-palci#931 - scientist-softserv/palni-palci#943 - scientist-softserv/palni-palci#945 - scientist-softserv/palni-palci#954 Co-authored-by: Lea Ann Bradford <ltrammer@gmail.com> Co-authored-by: LaRita Robinson <larita@scientist.com> Co-authored-by: Kirk Wang <kirk.wang@scientist.com> Co-authored-by: Shana Moore <shana@scientist.com>
jeremyf
added a commit
to samvera/hyku
that referenced
this pull request
Dec 19, 2023
Contribute back the following features: - scientist-softserv/palni-palci#445 - scientist-softserv/palni-palci#659 - scientist-softserv/palni-palci#740 - scientist-softserv/palni-palci#748 - scientist-softserv/palni-palci#823 - scientist-softserv/palni-palci#843 - scientist-softserv/palni-palci#844 - scientist-softserv/palni-palci#911 Which were resolved via the following PRs: - scientist-softserv/palni-palci#920 - scientist-softserv/palni-palci#704 - scientist-softserv/palni-palci#706 - scientist-softserv/palni-palci#790 - scientist-softserv/palni-palci#867 - scientist-softserv/palni-palci#874 - scientist-softserv/palni-palci#893 - scientist-softserv/palni-palci#898 - scientist-softserv/palni-palci#824 - scientist-softserv/palni-palci#923 - scientist-softserv/palni-palci#939 - scientist-softserv/palni-palci#922 - scientist-softserv/palni-palci#926 - scientist-softserv/palni-palci#927 - scientist-softserv/palni-palci#928 - scientist-softserv/palni-palci#929 - scientist-softserv/palni-palci#930 - scientist-softserv/palni-palci#931 - scientist-softserv/palni-palci#943 - scientist-softserv/palni-palci#945 - scientist-softserv/palni-palci#954 Co-authored-by: Lea Ann Bradford <ltrammer@gmail.com> Co-authored-by: LaRita Robinson <larita@scientist.com> Co-authored-by: Kirk Wang <kirk.wang@scientist.com> Co-authored-by: Shana Moore <shana@scientist.com>
jeremyf
pushed a commit
to samvera/hyku
that referenced
this pull request
Dec 19, 2023
Which were resolved via the following PRs: - scientist-softserv/palni-palci#768 - scientist-softserv/palni-palci#786 - scientist-softserv/palni-palci#790 - scientist-softserv/palni-palci#807 - scientist-softserv/palni-palci#850 - scientist-softserv/palni-palci#781 - scientist-softserv/palni-palci#787 - scientist-softserv/palni-palci#795 - scientist-softserv/palni-palci#788 - scientist-softserv/palni-palci#793 - scientist-softserv/palni-palci#782 - scientist-softserv/palni-palci#798 - scientist-softserv/palni-palci#866 - scientist-softserv/palni-palci#846 - scientist-softserv/palni-palci#849 - scientist-softserv/palni-palci#868 - scientist-softserv/palni-palci#875 - scientist-softserv/palni-palci#884 - scientist-softserv/palni-palci#876 - scientist-softserv/palni-palci#952 Contribute back the following features: - scientist-softserv/palni-palci#125 - scientist-softserv/palni-palci#740 - scientist-softserv/palni-palci#742 - scientist-softserv/palni-palci#746 - scientist-softserv/palni-palci#772 - scientist-softserv/palni-palci#773 - scientist-softserv/palni-palci#774 - scientist-softserv/palni-palci#776 - scientist-softserv/palni-palci#778 - scientist-softserv/palni-palci#839 - scientist-softserv/palni-palci#840 - scientist-softserv/palni-palci#864 Co-authored-by: Shana Moore <shana@scientist.com> Co-authored-by: Kirk Wang <kirk.wang@scientist.com>
jeremyf
added a commit
to samvera/hyku
that referenced
this pull request
Dec 19, 2023
Contribute back the following features: - scientist-softserv/palni-palci#445 - scientist-softserv/palni-palci#659 - scientist-softserv/palni-palci#740 - scientist-softserv/palni-palci#748 - scientist-softserv/palni-palci#823 - scientist-softserv/palni-palci#843 - scientist-softserv/palni-palci#844 - scientist-softserv/palni-palci#911 Which were resolved via the following PRs: - scientist-softserv/palni-palci#920 - scientist-softserv/palni-palci#704 - scientist-softserv/palni-palci#706 - scientist-softserv/palni-palci#790 - scientist-softserv/palni-palci#867 - scientist-softserv/palni-palci#874 - scientist-softserv/palni-palci#893 - scientist-softserv/palni-palci#898 - scientist-softserv/palni-palci#824 - scientist-softserv/palni-palci#923 - scientist-softserv/palni-palci#939 - scientist-softserv/palni-palci#922 - scientist-softserv/palni-palci#926 - scientist-softserv/palni-palci#927 - scientist-softserv/palni-palci#928 - scientist-softserv/palni-palci#929 - scientist-softserv/palni-palci#930 - scientist-softserv/palni-palci#931 - scientist-softserv/palni-palci#943 - scientist-softserv/palni-palci#945 - scientist-softserv/palni-palci#954 Co-authored-by: Lea Ann Bradford <ltrammer@gmail.com> Co-authored-by: LaRita Robinson <larita@scientist.com> Co-authored-by: Kirk Wang <kirk.wang@scientist.com> Co-authored-by: Shana Moore <shana@scientist.com>
jeremyf
added a commit
to samvera/hyku
that referenced
this pull request
Dec 19, 2023
Contribute back the following features: - scientist-softserv/palni-palci#445 - scientist-softserv/palni-palci#659 - scientist-softserv/palni-palci#740 - scientist-softserv/palni-palci#748 - scientist-softserv/palni-palci#823 - scientist-softserv/palni-palci#843 - scientist-softserv/palni-palci#844 - scientist-softserv/palni-palci#911 Which were resolved via the following PRs: - scientist-softserv/palni-palci#920 - scientist-softserv/palni-palci#704 - scientist-softserv/palni-palci#706 - scientist-softserv/palni-palci#790 - scientist-softserv/palni-palci#867 - scientist-softserv/palni-palci#874 - scientist-softserv/palni-palci#893 - scientist-softserv/palni-palci#898 - scientist-softserv/palni-palci#824 - scientist-softserv/palni-palci#923 - scientist-softserv/palni-palci#939 - scientist-softserv/palni-palci#922 - scientist-softserv/palni-palci#926 - scientist-softserv/palni-palci#927 - scientist-softserv/palni-palci#928 - scientist-softserv/palni-palci#929 - scientist-softserv/palni-palci#930 - scientist-softserv/palni-palci#931 - scientist-softserv/palni-palci#943 - scientist-softserv/palni-palci#945 - scientist-softserv/palni-palci#954 Co-authored-by: Lea Ann Bradford <ltrammer@gmail.com> Co-authored-by: LaRita Robinson <larita@scientist.com> Co-authored-by: Kirk Wang <kirk.wang@scientist.com> Co-authored-by: Shana Moore <shana@scientist.com>
This was referenced Dec 19, 2023
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the advanced search page, the controlled vocab properties currently allows the user to input whatever they want. Instead, the user should have to select an option from a dropdown.
Story
Refs #740
Expected Behavior Before Changes
controlled vocab fields were inputs. the user could type in whatever they want.
Expected Behavior After Changes
the user must select an option provided by their local controlled vocab configuration.
Screenshots / Video
DEMO
controlled-vocab.mp4
Notes