Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 Restore <%= render... #954

Merged
merged 1 commit into from
Dec 18, 2023
Merged

🧹 Restore <%= render... #954

merged 1 commit into from
Dec 18, 2023

Conversation

jeremyf
Copy link
Contributor

@jeremyf jeremyf commented Dec 18, 2023

Prior to this commit, we had a case where <% render was called. The result would be that we would in fact not render the results.

In the file from PR 930 the render moved from <%= render to <% render

With this commit, we restore that rendering.

Related to:

@jeremyf
🧹 Restore <%= render...
851bf9d 
Prior to this commit, we had a case where `<% render` was called.  The
result would be that we would in fact not render the results.

In the [file from PR 930][1] the render moved from `<%= render` to `<%
render`

With this commit, we restore that rendering.

Related to:

- #930
- #911

[1]: https://github.com/scientist-softserv/palni-palci/pull/930/files#diff-521d4c52bd51d0f13962e2d0b09d2740a257187d4fbf7b1fd8cff53e36b1362e
@jeremyf jeremyf merged commit 8754556 into main Dec 18, 2023
6 of 7 checks passed
@jeremyf jeremyf deleted the restore-render-of-work-description branch December 18, 2023 16:56
jeremyf added a commit to samvera/hyku that referenced this pull request Dec 19, 2023
@jeremyf @labradford
@laritakr @kirkkwang @ShanaLMoore
🎁 Contributions from PALNI/PALCI
0d6dbe7 
Contribute back the following features:

- scientist-softserv/palni-palci#445
- scientist-softserv/palni-palci#659
- scientist-softserv/palni-palci#740
- scientist-softserv/palni-palci#748
- scientist-softserv/palni-palci#823
- scientist-softserv/palni-palci#843
- scientist-softserv/palni-palci#844
- scientist-softserv/palni-palci#911

Which were resolved via the following PRs:

- scientist-softserv/palni-palci#920
- scientist-softserv/palni-palci#704
- scientist-softserv/palni-palci#706
- scientist-softserv/palni-palci#790
- scientist-softserv/palni-palci#867
- scientist-softserv/palni-palci#874
- scientist-softserv/palni-palci#893
- scientist-softserv/palni-palci#898
- scientist-softserv/palni-palci#824
- scientist-softserv/palni-palci#923
- scientist-softserv/palni-palci#939
- scientist-softserv/palni-palci#922
- scientist-softserv/palni-palci#926
- scientist-softserv/palni-palci#927
- scientist-softserv/palni-palci#928
- scientist-softserv/palni-palci#929
- scientist-softserv/palni-palci#930
- scientist-softserv/palni-palci#931
- scientist-softserv/palni-palci#943
- scientist-softserv/palni-palci#945
- scientist-softserv/palni-palci#954

Co-authored-by: Lea Ann Bradford <ltrammer@gmail.com>
Co-authored-by: LaRita Robinson <larita@scientist.com>
Co-authored-by: Kirk Wang <kirk.wang@scientist.com>
Co-authored-by: Shana Moore <shana@scientist.com>
jeremyf added a commit to samvera/hyku that referenced this pull request Dec 19, 2023
@jeremyf @labradford
@laritakr @kirkkwang @ShanaLMoore
🎁 Contributions from PALNI/PALCI
707b447 
Contribute back the following features:

- scientist-softserv/palni-palci#445
- scientist-softserv/palni-palci#659
- scientist-softserv/palni-palci#740
- scientist-softserv/palni-palci#748
- scientist-softserv/palni-palci#823
- scientist-softserv/palni-palci#843
- scientist-softserv/palni-palci#844
- scientist-softserv/palni-palci#911

Which were resolved via the following PRs:

- scientist-softserv/palni-palci#920
- scientist-softserv/palni-palci#704
- scientist-softserv/palni-palci#706
- scientist-softserv/palni-palci#790
- scientist-softserv/palni-palci#867
- scientist-softserv/palni-palci#874
- scientist-softserv/palni-palci#893
- scientist-softserv/palni-palci#898
- scientist-softserv/palni-palci#824
- scientist-softserv/palni-palci#923
- scientist-softserv/palni-palci#939
- scientist-softserv/palni-palci#922
- scientist-softserv/palni-palci#926
- scientist-softserv/palni-palci#927
- scientist-softserv/palni-palci#928
- scientist-softserv/palni-palci#929
- scientist-softserv/palni-palci#930
- scientist-softserv/palni-palci#931
- scientist-softserv/palni-palci#943
- scientist-softserv/palni-palci#945
- scientist-softserv/palni-palci#954

Co-authored-by: Lea Ann Bradford <ltrammer@gmail.com>
Co-authored-by: LaRita Robinson <larita@scientist.com>
Co-authored-by: Kirk Wang <kirk.wang@scientist.com>
Co-authored-by: Shana Moore <shana@scientist.com>
jeremyf added a commit to samvera/hyku that referenced this pull request Dec 19, 2023
@jeremyf @labradford
@laritakr @kirkkwang @ShanaLMoore
🎁 Contributions from PALNI/PALCI
1342260 
Contribute back the following features:

- scientist-softserv/palni-palci#445
- scientist-softserv/palni-palci#659
- scientist-softserv/palni-palci#740
- scientist-softserv/palni-palci#748
- scientist-softserv/palni-palci#823
- scientist-softserv/palni-palci#843
- scientist-softserv/palni-palci#844
- scientist-softserv/palni-palci#911

Which were resolved via the following PRs:

- scientist-softserv/palni-palci#920
- scientist-softserv/palni-palci#704
- scientist-softserv/palni-palci#706
- scientist-softserv/palni-palci#790
- scientist-softserv/palni-palci#867
- scientist-softserv/palni-palci#874
- scientist-softserv/palni-palci#893
- scientist-softserv/palni-palci#898
- scientist-softserv/palni-palci#824
- scientist-softserv/palni-palci#923
- scientist-softserv/palni-palci#939
- scientist-softserv/palni-palci#922
- scientist-softserv/palni-palci#926
- scientist-softserv/palni-palci#927
- scientist-softserv/palni-palci#928
- scientist-softserv/palni-palci#929
- scientist-softserv/palni-palci#930
- scientist-softserv/palni-palci#931
- scientist-softserv/palni-palci#943
- scientist-softserv/palni-palci#945
- scientist-softserv/palni-palci#954

Co-authored-by: Lea Ann Bradford <ltrammer@gmail.com>
Co-authored-by: LaRita Robinson <larita@scientist.com>
Co-authored-by: Kirk Wang <kirk.wang@scientist.com>
Co-authored-by: Shana Moore <shana@scientist.com>
jeremyf added a commit to samvera/hyku that referenced this pull request Dec 19, 2023
@jeremyf @labradford
@laritakr @kirkkwang @ShanaLMoore
🎁 Contributions from PALNI/PALCI
6f9b88b 
Contribute back the following features:

- scientist-softserv/palni-palci#445
- scientist-softserv/palni-palci#659
- scientist-softserv/palni-palci#740
- scientist-softserv/palni-palci#748
- scientist-softserv/palni-palci#823
- scientist-softserv/palni-palci#843
- scientist-softserv/palni-palci#844
- scientist-softserv/palni-palci#911

Which were resolved via the following PRs:

- scientist-softserv/palni-palci#920
- scientist-softserv/palni-palci#704
- scientist-softserv/palni-palci#706
- scientist-softserv/palni-palci#790
- scientist-softserv/palni-palci#867
- scientist-softserv/palni-palci#874
- scientist-softserv/palni-palci#893
- scientist-softserv/palni-palci#898
- scientist-softserv/palni-palci#824
- scientist-softserv/palni-palci#923
- scientist-softserv/palni-palci#939
- scientist-softserv/palni-palci#922
- scientist-softserv/palni-palci#926
- scientist-softserv/palni-palci#927
- scientist-softserv/palni-palci#928
- scientist-softserv/palni-palci#929
- scientist-softserv/palni-palci#930
- scientist-softserv/palni-palci#931
- scientist-softserv/palni-palci#943
- scientist-softserv/palni-palci#945
- scientist-softserv/palni-palci#954

Co-authored-by: Lea Ann Bradford <ltrammer@gmail.com>
Co-authored-by: LaRita Robinson <larita@scientist.com>
Co-authored-by: Kirk Wang <kirk.wang@scientist.com>
Co-authored-by: Shana Moore <shana@scientist.com>
This was referenced Dec 19, 2023
Closed
Closed
This was referenced Jan 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laritakr laritakr laritakr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremyf @laritakr