Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎁 Video Embed Epic: Run translations #926

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

ShanaLMoore
Copy link
Contributor

@ShanaLMoore ShanaLMoore commented Dec 6, 2023

In this PR, hyrax.en.yml gets translated to the various locales for the recently added video_embed help text.

Story

Refs

Expected Behavior Before Changes

Switching from English to any other language would no longer display the help text for the video embed field:

ENGLISH

Screenshot 2023-12-06 at 09-21-18 Work __ Hyku Commons

German

Screenshot 2023-12-06 at 09-21-44 Arbeiten __ Hyku

Expected Behavior After Changes

GERMAN

Switching from English to other languages displays the translated help text:
Screenshot 2023-12-06 at 09-21-01 Arbeiten __ Hyku

In this PR, hyrax.en.yml gets translated to the various locales.
@ShanaLMoore ShanaLMoore merged commit 4ce94a5 into main Dec 6, 2023
6 of 7 checks passed
@ShanaLMoore ShanaLMoore deleted the i911-run-translations branch December 6, 2023 17:50
jeremyf added a commit to samvera/hyku that referenced this pull request Dec 19, 2023
jeremyf added a commit to samvera/hyku that referenced this pull request Dec 19, 2023
jeremyf added a commit to samvera/hyku that referenced this pull request Dec 19, 2023
jeremyf added a commit to samvera/hyku that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants