Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix misspelling on depositor #893

Merged
merged 1 commit into from
Oct 31, 2023
Merged

🐛 Fix misspelling on depositor #893

merged 1 commit into from
Oct 31, 2023

Conversation

laritakr
Copy link
Contributor

@laritakr laritakr commented Oct 31, 2023

Story

Fix misspelling of depositor so sort works

Refs

Expected Behavior Before Changes

Expected Behavior After Changes

Screenshots / Video

Notes

Requires a reindex of both works and collections

@ShanaLMoore ShanaLMoore changed the title 🐛 Fix misspelling on creator 🐛 Fix misspelling on depositor Oct 31, 2023
@ShanaLMoore
Copy link
Contributor

Do we still want to normalize the creator value, since we'll have to reindex anyways @laritakr ?

@laritakr
Copy link
Contributor Author

Do we still want to normalize the creator value, since we'll have to reindex anyways @laritakr ?

I don't know if it matters? The majority should be all lower case... very few people input email addresses with mixed case. I guess you can ask Nic, but I would probably not.

@laritakr laritakr merged commit 609b145 into main Oct 31, 2023
7 checks passed
@laritakr laritakr deleted the rework-creator-sort branch October 31, 2023 20:40
jeremyf added a commit to samvera/hyku that referenced this pull request Dec 19, 2023
jeremyf added a commit to samvera/hyku that referenced this pull request Dec 19, 2023
jeremyf added a commit to samvera/hyku that referenced this pull request Dec 19, 2023
jeremyf added a commit to samvera/hyku that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants