Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I748 sort works and collections on dashboard #867

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

kirkkwang
Copy link
Contributor

Story

🎁 Add sort on dashboard works

This commit will add the ability to sort on the dashboard works pages,
to include dashboard works and my works.

🎁 Add ability to sort dashboard collections

This commit will add the ability to sort collections on the dashboard.
The collections work differently than the works so we have to make sure
the sort field is added to the search builder. Because when you click
into a collection can view the works attached to the collection, we have
to approach it differently because otherwise the sort fields from the
dashboard index page will also be applied to the show page. We decorate
Blacklight helpers to check the controller action name as our
conditional.

Ref:

Screenshots / Video

Screen.Recording.2023-10-16.at.19.37.16.mp4

Note

Reindexing is needed to get sorting by depositor and creator working.

This commit will add the ability to sort on the dashboard works pages,
to include dashboard works and my works.
This commit will add the ability to sort collections on the dashboard.
The collections work differently than the works so we have to make sure
the sort field is added to the search builder.  Because when you click
into a collection can view the works attached to the collection, we have
to approach it differently because otherwise the sort fields from the
dashboard index page will also be applied to the show page.  We decorate
Blacklight helpers to check the controller action name as our
conditional.

Ref:
  - #748
Copy link
Contributor

@ShanaLMoore ShanaLMoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After exhausting many options, and in consideration of our deadline, we are saving adding additional specs for another time.

@kirkkwang kirkkwang force-pushed the i748-sort-works-and-collections-on-dashboard branch from 9264be2 to ab55b0d Compare October 17, 2023 22:29
This commit will refactor the helper methods.  We want to add tests to
ensure that the helper methods are working as expected but for now we
will skip it.

TODO: add tests
@kirkkwang kirkkwang force-pushed the i748-sort-works-and-collections-on-dashboard branch from ab55b0d to 785d73b Compare October 17, 2023 22:30
@ShanaLMoore ShanaLMoore merged commit ca3b901 into main Oct 18, 2023
6 of 7 checks passed
@ShanaLMoore ShanaLMoore deleted the i748-sort-works-and-collections-on-dashboard branch October 18, 2023 00:00
jeremyf added a commit to samvera/hyku that referenced this pull request Dec 19, 2023
jeremyf added a commit to samvera/hyku that referenced this pull request Dec 19, 2023
jeremyf added a commit to samvera/hyku that referenced this pull request Dec 19, 2023
jeremyf added a commit to samvera/hyku that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants