Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎁 I911 Video Embed: Image Work Type #928

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Conversation

ShanaLMoore
Copy link
Contributor

@ShanaLMoore ShanaLMoore commented Dec 6, 2023

This PR adds video embed to the Image model.

It also cleans up repetitive code found in GenericWork and CDL models and forms.

Screenshot 2023-12-06 at 10-41-56 Image video embed

Adds video embed to CDL work type.

Issue:
- #911
Adds video embed to CDL work type.

Issue:
- #911
CDL and GenericWork models inherits from VideoEmbedBehavior. This DRYs up identical code being repeated in various places.
This commit DRYs up repetitive code by creating a VideoEmbedFormBehavior module.
@ShanaLMoore ShanaLMoore merged commit 5fc39fc into main Dec 7, 2023
8 of 12 checks passed
@ShanaLMoore ShanaLMoore deleted the i911-video-embed-Image branch December 7, 2023 14:48
jeremyf added a commit to samvera/hyku that referenced this pull request Dec 19, 2023
jeremyf added a commit to samvera/hyku that referenced this pull request Dec 19, 2023
jeremyf added a commit to samvera/hyku that referenced this pull request Dec 19, 2023
jeremyf added a commit to samvera/hyku that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants