Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default for use iiif_print to false per client request #704

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Change default for use iiif_print to false per client request #704

merged 2 commits into from
Aug 17, 2023

Conversation

labradford
Copy link
Contributor

Story

Refs #659

Client would like default for using IIIF Print to be false

Expected Behavior Before Changes

Expected Behavior After Changes

Screenshots / Video

Notes

@labradford labradford merged commit fe9b0a6 into main Aug 17, 2023
6 of 7 checks passed
@labradford labradford deleted the i659-Allow-tenant-configuration-to-ignore-showing-PDFs-in-universal-viewer branch August 17, 2023 06:42
jeremyf added a commit to scientist-softserv/atla-hyku that referenced this pull request Nov 28, 2023
@jeremyf @ShanaLMoore @kirkkwang
🚧 Add conditional PDF split or PDF.js
6440307 
This is a preliminary commit to add conditional logic for either
rendering PDF.js or IIIF viewer for split pages.

This fails QA in one manner:

1. Set the Tenant to use UV
2. Create a work with a PDF (this will split the page)
3. Go to the work's page, you'll see the UV
4. Set the Tenant to use PDF.js
5. Go to the work page, and you should see PDF.js but at present see the
   UV.

Related to:

- scientist-softserv/palni-palci#666
- scientist-softserv/palni-palci#675
- scientist-softserv/palni-palci#704
- scientist-softserv/palni-palci#705
- #162

Co-authored-by: Shana Moore <shana@scientist.com>
Co-authored-by: Kirk Wang <kirk.wang@scientist.com>
jeremyf added a commit to scientist-softserv/atla-hyku that referenced this pull request Nov 28, 2023
@jeremyf @ShanaLMoore @kirkkwang
🎁 Add conditional PDF split or PDF.js
8d35981 
This is a preliminary commit to add conditional logic for either
rendering PDF.js or IIIF viewer for split pages.

There is a particular case where QA might appear to fail:

1. Set the Tenant to use UV
2. Create a work with a PDF (this will split the page)
3. Go to the work's page, you'll see the UV
4. Set the Tenant to use PDF.js
5. Refresh the work page, and you should see PDF.js but instead will see
   the UV.

To work around this (and realistically how most people will experience this):

1. Set the Tenant to use UV
2. Create a work with a PDF
3. Go to the Dashboard
4. Click the work's URL
5. You should see a UV for the PDF
6. Close the work's page
7. Change the tenant to use PDF.js
8. Go to the Dashboard
9. Click the work's URL

The conjecture is that there's some iframe and/or turbolinks caching.
Given that this is an edge case regarding toggling on and off a tenant
feature, we think the work around is adequate.

Related to:

- scientist-softserv/palni-palci#666
- scientist-softserv/palni-palci#675
- scientist-softserv/palni-palci#704
- scientist-softserv/palni-palci#705
- #162

Co-authored-by: Shana Moore <shana@scientist.com>
Co-authored-by: Kirk Wang <kirk.wang@scientist.com>
@jeremyf jeremyf mentioned this pull request Nov 28, 2023
Merged
jeremyf added a commit to scientist-softserv/atla-hyku that referenced this pull request Nov 29, 2023
@jeremyf @ShanaLMoore @kirkkwang
🎁 Add conditional PDF split or PDF.js
a2d1d36 
This is a preliminary commit to add conditional logic for either
rendering PDF.js or IIIF viewer for split pages.

There is a particular case where QA might appear to fail:

1. Set the Tenant to use UV
2. Create a work with a PDF (this will split the page)
3. Go to the work's page, you'll see the UV
4. Set the Tenant to use PDF.js
5. Refresh the work page, and you should see PDF.js but instead will see
   the UV.

To work around this (and realistically how most people will experience this):

1. Set the Tenant to use UV
2. Create a work with a PDF
3. Go to the Dashboard
4. Click the work's URL
5. You should see a UV for the PDF
6. Close the work's page
7. Change the tenant to use PDF.js
8. Go to the Dashboard
9. Click the work's URL

The conjecture is that there's some iframe and/or turbolinks caching.
Given that this is an edge case regarding toggling on and off a tenant
feature, we think the work around is adequate.

Related to:

- scientist-softserv/palni-palci#666
- scientist-softserv/palni-palci#675
- scientist-softserv/palni-palci#704
- scientist-softserv/palni-palci#705
- #162

Co-authored-by: Shana Moore <shana@scientist.com>
Co-authored-by: Kirk Wang <kirk.wang@scientist.com>
jeremyf added a commit to samvera/hyku that referenced this pull request Dec 19, 2023
@jeremyf @labradford
@laritakr @kirkkwang @ShanaLMoore
🎁 Contributions from PALNI/PALCI
0d6dbe7 
Contribute back the following features:

- scientist-softserv/palni-palci#445
- scientist-softserv/palni-palci#659
- scientist-softserv/palni-palci#740
- scientist-softserv/palni-palci#748
- scientist-softserv/palni-palci#823
- scientist-softserv/palni-palci#843
- scientist-softserv/palni-palci#844
- scientist-softserv/palni-palci#911

Which were resolved via the following PRs:

- scientist-softserv/palni-palci#920
- scientist-softserv/palni-palci#704
- scientist-softserv/palni-palci#706
- scientist-softserv/palni-palci#790
- scientist-softserv/palni-palci#867
- scientist-softserv/palni-palci#874
- scientist-softserv/palni-palci#893
- scientist-softserv/palni-palci#898
- scientist-softserv/palni-palci#824
- scientist-softserv/palni-palci#923
- scientist-softserv/palni-palci#939
- scientist-softserv/palni-palci#922
- scientist-softserv/palni-palci#926
- scientist-softserv/palni-palci#927
- scientist-softserv/palni-palci#928
- scientist-softserv/palni-palci#929
- scientist-softserv/palni-palci#930
- scientist-softserv/palni-palci#931
- scientist-softserv/palni-palci#943
- scientist-softserv/palni-palci#945
- scientist-softserv/palni-palci#954

Co-authored-by: Lea Ann Bradford <ltrammer@gmail.com>
Co-authored-by: LaRita Robinson <larita@scientist.com>
Co-authored-by: Kirk Wang <kirk.wang@scientist.com>
Co-authored-by: Shana Moore <shana@scientist.com>
jeremyf added a commit to samvera/hyku that referenced this pull request Dec 19, 2023
@jeremyf @labradford
@laritakr @kirkkwang @ShanaLMoore
🎁 Contributions from PALNI/PALCI
707b447 
Contribute back the following features:

- scientist-softserv/palni-palci#445
- scientist-softserv/palni-palci#659
- scientist-softserv/palni-palci#740
- scientist-softserv/palni-palci#748
- scientist-softserv/palni-palci#823
- scientist-softserv/palni-palci#843
- scientist-softserv/palni-palci#844
- scientist-softserv/palni-palci#911

Which were resolved via the following PRs:

- scientist-softserv/palni-palci#920
- scientist-softserv/palni-palci#704
- scientist-softserv/palni-palci#706
- scientist-softserv/palni-palci#790
- scientist-softserv/palni-palci#867
- scientist-softserv/palni-palci#874
- scientist-softserv/palni-palci#893
- scientist-softserv/palni-palci#898
- scientist-softserv/palni-palci#824
- scientist-softserv/palni-palci#923
- scientist-softserv/palni-palci#939
- scientist-softserv/palni-palci#922
- scientist-softserv/palni-palci#926
- scientist-softserv/palni-palci#927
- scientist-softserv/palni-palci#928
- scientist-softserv/palni-palci#929
- scientist-softserv/palni-palci#930
- scientist-softserv/palni-palci#931
- scientist-softserv/palni-palci#943
- scientist-softserv/palni-palci#945
- scientist-softserv/palni-palci#954

Co-authored-by: Lea Ann Bradford <ltrammer@gmail.com>
Co-authored-by: LaRita Robinson <larita@scientist.com>
Co-authored-by: Kirk Wang <kirk.wang@scientist.com>
Co-authored-by: Shana Moore <shana@scientist.com>
jeremyf added a commit to samvera/hyku that referenced this pull request Dec 19, 2023
@jeremyf @labradford
@laritakr @kirkkwang @ShanaLMoore
🎁 Contributions from PALNI/PALCI
1342260 
Contribute back the following features:

- scientist-softserv/palni-palci#445
- scientist-softserv/palni-palci#659
- scientist-softserv/palni-palci#740
- scientist-softserv/palni-palci#748
- scientist-softserv/palni-palci#823
- scientist-softserv/palni-palci#843
- scientist-softserv/palni-palci#844
- scientist-softserv/palni-palci#911

Which were resolved via the following PRs:

- scientist-softserv/palni-palci#920
- scientist-softserv/palni-palci#704
- scientist-softserv/palni-palci#706
- scientist-softserv/palni-palci#790
- scientist-softserv/palni-palci#867
- scientist-softserv/palni-palci#874
- scientist-softserv/palni-palci#893
- scientist-softserv/palni-palci#898
- scientist-softserv/palni-palci#824
- scientist-softserv/palni-palci#923
- scientist-softserv/palni-palci#939
- scientist-softserv/palni-palci#922
- scientist-softserv/palni-palci#926
- scientist-softserv/palni-palci#927
- scientist-softserv/palni-palci#928
- scientist-softserv/palni-palci#929
- scientist-softserv/palni-palci#930
- scientist-softserv/palni-palci#931
- scientist-softserv/palni-palci#943
- scientist-softserv/palni-palci#945
- scientist-softserv/palni-palci#954

Co-authored-by: Lea Ann Bradford <ltrammer@gmail.com>
Co-authored-by: LaRita Robinson <larita@scientist.com>
Co-authored-by: Kirk Wang <kirk.wang@scientist.com>
Co-authored-by: Shana Moore <shana@scientist.com>
jeremyf added a commit to samvera/hyku that referenced this pull request Dec 19, 2023
@jeremyf @labradford
@laritakr @kirkkwang @ShanaLMoore
🎁 Contributions from PALNI/PALCI
6f9b88b 
Contribute back the following features:

- scientist-softserv/palni-palci#445
- scientist-softserv/palni-palci#659
- scientist-softserv/palni-palci#740
- scientist-softserv/palni-palci#748
- scientist-softserv/palni-palci#823
- scientist-softserv/palni-palci#843
- scientist-softserv/palni-palci#844
- scientist-softserv/palni-palci#911

Which were resolved via the following PRs:

- scientist-softserv/palni-palci#920
- scientist-softserv/palni-palci#704
- scientist-softserv/palni-palci#706
- scientist-softserv/palni-palci#790
- scientist-softserv/palni-palci#867
- scientist-softserv/palni-palci#874
- scientist-softserv/palni-palci#893
- scientist-softserv/palni-palci#898
- scientist-softserv/palni-palci#824
- scientist-softserv/palni-palci#923
- scientist-softserv/palni-palci#939
- scientist-softserv/palni-palci#922
- scientist-softserv/palni-palci#926
- scientist-softserv/palni-palci#927
- scientist-softserv/palni-palci#928
- scientist-softserv/palni-palci#929
- scientist-softserv/palni-palci#930
- scientist-softserv/palni-palci#931
- scientist-softserv/palni-palci#943
- scientist-softserv/palni-palci#945
- scientist-softserv/palni-palci#954

Co-authored-by: Lea Ann Bradford <ltrammer@gmail.com>
Co-authored-by: LaRita Robinson <larita@scientist.com>
Co-authored-by: Kirk Wang <kirk.wang@scientist.com>
Co-authored-by: Shana Moore <shana@scientist.com>
This was referenced Dec 19, 2023
Closed
Closed
This was referenced Jan 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aprilrieger aprilrieger aprilrieger approved these changes

@orangewolf orangewolf orangewolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@labradford @orangewolf @aprilrieger