Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 rework: A user should see the parent work link if they can #875

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

ShanaLMoore
Copy link
Contributor

@ShanaLMoore ShanaLMoore commented Oct 18, 2023

This is rework to address user abilities regarding the parent linked in a child work. It considers what should happen when a user is logged out and in. When logged it, it considers the user's abilities and the visibility type of the parent work.

Issue:

Expected Behavior Before Changes

We misinterpreted the client's request. When logged out, the user could not see the parent link unless it also had a public collection 🙃

Expected Behavior After Changes

I created a parent work of all visibility types (public, private, institution and embargo)

When a super admin is logged in

  • They should see all parent works
  • The parent link should render without the presence of a collection
works only

Screenshot 2023-10-18 at 09-50-50 child work private parent

with collections

Screenshot 2023-10-18 at 10-41-20 child work private parent

When a non admin user is logged in

  • They should only see what they should be able to (institutional and public in this case)
  • The parent link should render without the presence of a collection
works only

Screenshot 2023-10-18 at 9 50 30 AM

with collections

image

When a user is logged out

  • They should only see the parent link if the parent work is public
  • The parent link should render without the presence of a collection
works only

Screenshot 2023-10-18 at 9 50 46 AM

with collections

Screenshot 2023-10-18 at 10 42 05 AM

…lity to

This is rework to address user abilities regarding the parent linked in a child work. It considers what should happen when a user is logged out and in. When logged it, it considers the user's abilities and the visibility type of the parent work.

Issue:
- #840
@ShanaLMoore ShanaLMoore marked this pull request as draft October 18, 2023 17:30
The logic was wrong, making the parent link still depend on the collection.
@ShanaLMoore ShanaLMoore marked this pull request as ready for review October 18, 2023 17:37
@ShanaLMoore ShanaLMoore merged commit df964ac into main Oct 18, 2023
6 of 7 checks passed
@ShanaLMoore ShanaLMoore deleted the i840-parent-link-with-ability-check branch October 18, 2023 18:22
jeremyf pushed a commit to samvera/hyku that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants