Release 5.5.0 #523
Merged
Release 5.5.0 #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix UNSUPPORTED_RESOURCE result code for images Make HMI to respond with the proper result code in case when STATIC image is received. Also removed redundant and commented code to make things cleaner. * Fix PerformInteraction image validation * Fix empty info message and params forwarding * Fix response params forwarding There was noticed a regression that HMI does not forward params in case of error. This is because of complicated and wrong logic of calculation of some corner cases. To avoid that, condition was reformatted as a more readable separate function. * Fix TTS.Speak empty chunks handling
* Fix success response code on jpeg images * Fix checking of relative paths Also make a proper deletion of key from imageCheckList * Add PerformInteraction choices image validation * Update validateImages() function
* Add UI element to display the mediaTrack text field * Update app/view/media/sdl/controllsView.js Co-authored-by: JackLivio <jack@livio.io> Co-authored-by: JackLivio <jack@livio.io>
* Add support for countRate param in SetMediaClockTimer
…nformation_vehicle_data Feature/sdl 0255 enhance body information vehicle data
* Implement media skip indicators * Implement seek indicator icon switching * Add separate properties for the for forward and back seek indicators * Change seek indicator icons * Apply suggestions from code review Co-authored-by: Collin <iCollin@users.noreply.github.com> * Change seek icon dimensions to match other control icons * Add default case for undefined seekIndicator params in request * Add changes to reset seekIndicator to TRACK if the app enters HMI_NONE Co-authored-by: Collin <iCollin@users.noreply.github.com>
* Add new structure SeatOccupancy into VehicleData * Make dynamic filling of seat occupancy Co-authored-by: yurii <ypostolov> Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
* add timeToDestination to capabilities, remove navigationText references, fix navigation template mainField assignment * add turnText to display capabilities * add turnText and timeToDestination to UI GetCapabilities response * add turnText and timeToDestination to defaultWindowCapability
Co-authored-by: yurii <ypostolov> Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
* Rename ccpu editor to versions editor * Added vehicle type editor * Add systemHardwareVersion according to revision Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
* Main Menu UI Updates * Update var to isSecondaryTemplate * CSS Fixes * Add missing capabilities * Update data capabilities
* Add numeric keyboard implementation * Add keyboard controller with internal logic * Align keyboard layouts and style with proposal * Set default app global properties * Add capabilities for new layouts and properties
…ignition cycle (#391) * Add VideoStreamingCapabilities view * Add video streaming functionality Add OnAppCapabilityUpdatedNotification support Fix SetVideoConfig RPC processing Add sendVideoStreamingCapabilities functionality * Update python server with streaming functionality * Update systemCapabilities with videoStreamingCapabilities * Update README * Added resolutions picker element Navi/projection view has been extended to display combobox suggesting available video streaming resolutions for the current app. Also, order of elements initialization has been updated to guarantee a proper bindindgs. * Add support of OnAppCapabilityUpdated HMI will update its internal capabilities with the information received from this notification. For this reason, internal capabilities structure has been changed from regular object to Ember object. This will also guarantee that all bounded fields will be updated correspondingly in all places. * Review fixes * fixup! Add support of OnAppCapabilityUpdated * fixup! Add video streaming functionality * fixup! Added resolutions picker element * fixup! Add support of OnAppCapabilityUpdated * fixup! Added resolutions picker element * fixup! Add support of OnAppCapabilityUpdated * fixup! fixup! Added resolutions picker element * Fix exceptions handling of pexpect command * Catch rejections of startStreamingAdapter() * Address review comments * Add audio streaming support and start/stop ffmpeg * Add parallel a/v streaming support * Fix OnTouchEvent calculations * Address review comments * fixup! Address review comments * fixup! fixup! Address review comments * Handle RTP streaming mode Co-authored-by: YarikMamykin <ymamykin@gmail.com> Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com> Co-authored-by: Aleksandr Kutsan <AKutsan@luxoft.com> Co-authored-by: Dmitriy Boltovskiy <dboltovskyi@luxoft.com>
"OnPhoneCall", "OnEmergencyEvent", and "OnDeactivateHMI" were replaced by "OnEventChanged" in SDL Core 4.1.0
* update ON/OFF toggles on SIVD SEAT * acknowledge falsy values
* kill running webengine app when it is uninstalled * apply even if uninstalled outside of editor
…eData notification (#490)
* draw haptic rectangles over video stream * fix rectangle starting height
There was noticed an issue that HMI captures ButtonUp and click events in case when button on the upper view was clicked, view closed and there is another button on the lower view. In that case, unexpected events for these buttons on the lower view will be raised. To fix that, buttonDown actions on the VR popup have been replaced with buttonUp action which prevents view closure before all events are captured.
* Fix sending of redundant notifications on app activation Looks like HMI sends redundant OnUpdateFile and onUpdateSubMenu notifications when application was deactivated and activated again. After clarifications, looks like it makes more sense to send such notifications just once for each submenu and for each image which was not loaded properly. Also, updated logic of sending OnUpdateSubMenu items to make a partial update only for visible part of menu. * Clear cache on subMenu deletion * fixup! Fix sending of redundant notifications on app activation
* Menu css tertiary text + secondary image alignment * Remove redunant notification for input mask
* fix Apps button sends deprecated OnFindApplications notification * fix Find New Apps button sends deprecated OnFindApplications notification * Remove OnFindApplications from BasicCommunicationRPC * fixup! fix Find New Apps button sends deprecated OnFindApplications notification Co-authored-by: yurii <ypostolov>
…st (#513) Co-authored-by: yurii <ypostolov>
Co-authored-by: Collin <co@ll.in>
This reverts commit 466c1f1.
* don't send activate app with null app id * Revert "don't send activate app with null app id" This reverts commit 466c1f1. * don't send activate app with null app id * Revert "don't send activate app with null app id" This reverts commit c92157d. * navigation app is not a audio source Co-authored-by: Collin <co@ll.in>
* Fix value check for EnabledData values * Fix massageMode array bounds check * Apply suggestions from code review Co-authored-by: Collin <iCollin@users.noreply.github.com> Co-authored-by: Collin <iCollin@users.noreply.github.com>
* fix tertiary text overflow Co-authored-by: Collin <co@ll.in>
…in case multiple apps (#537) * Fix HMI shows wrong resolutions in a drop-down list with resolutions in case multiple apps Co-authored-by: yurii <ypostolov> Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
* Fix input key mask enabled from set global properties * Only set model param if model exists * Remove redunant OnInputNotificaiton after showing keyboard * Revert "Remove redunant OnInputNotificaiton after showing keyboard" This reverts commit 08fc71b. * Prevent redundant notification on activate * Line break
* Implement custom response for RC.SetGlobalProperties * Fix SUCCESS result code
* Check valid model object * Apply suggestions from code review Co-authored-by: Collin <iCollin@users.noreply.github.com> Co-authored-by: Collin <iCollin@users.noreply.github.com>
* Fix HMI connection to Policy Manager during PTU There was noticed a timing issue when HMI is not fast enough to connect to Policy Manager backend after ignition off/on. As SDL starts before the Policy Manager, there might be an issue when SDL continues PTU however HMI is not connected to PM yet which causes an exception and breaks PTU sequence. Also, HMI is trying to perform PTU even if no any apps registered yet which makes no sense if PTU over internal modem is disabled. The following changes were done: - Postpone PTU sequence until at least one app is registered - Resume PTU sequence once app is registered and PTU was postponed - Postpone sending of messages to Policy Manager until socket is connected - Resume sending of postponed messages to PM once coonection is established
The issues is observed while working with multiple media applications registered. Once media indicators are changed for one application, second application shows also changed indicators instead of their own. To resolve that, propery binding was changed to active model which triggers callbacks properly and allows to display the correct seek indicators for each media application. Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
* Update resolution index if settings were changed Looks like video streaming resolution combobox is not affected by settings changed in code editor. This commit provides changes related to proper calculation of video streaming resolution index once user applies custom settings. * Update resolution index according to SetVideoConfig
…h settable resultCode (#551) * Fix HMI does not send AddSubMenu and SetGlobalProperties response with settable resultCode * fixup! Fix HMI does not send AddSubMenu and SetGlobalProperties response with settable resultCode Co-authored-by: yurii <ypostolov> Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
* Find correct preferred resolution with scale * Apply suggestions from code review Co-authored-by: Andrii Kalinich (GitHub) <AKalinich@luxoft.com> * Fix formatting Co-authored-by: Andrii Kalinich (GitHub) <AKalinich@luxoft.com>
Core was marking this invalid because it was sent as a string, preventing the app from receiving the notification
Make correct resolution switching for both editor and SetVideoConfig
Jack-Byrne
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
[SDL 0293] Enable OEM exclusive apps support
[SDL 0296] Possibility to update video streaming capabilities during ignition cycle
[SDL 0238] Keyboard Enhancements
[SDL 0267] Main Menu UI Updates
[SDL 0269] New vehicle data ClimateData
[SDL 0305] Homogenize TextFieldName
[SDL 0274] Add preferred FPS to VideoStreamingCapability
[SDL 0262] New vehicle data SeatOccupancy
[SDL 0198] Media Skip Indicators
[SDL 0255] Enhance BodyInformation vehicle data
[SDL 0244] Custom Playback Rates for SetMediaClockTimer
Implement TouchEvent type CANCEL
Implement SendHapticData
Bug Fixes / Enhancements
Add mediaTrack UI element
HMI unable to connect to Policy Manager after Ignition cycle (EXTERNAL_PROPRIETARY)
Show app submenu behavior issues
SeatModel not sending OnInteriorVehicleData for certain values
BasicCommunication.onReady notification send two times instead of one time from the web hmi
HMI aborts AlertManeuver, PerformInteraction requests with STATIC images
HMI responds with SUCCESS resultCode to Show/Alert/SendLocation request with .jpeg image and isTemplate=true
SUCCESS resultCode is returned from HMI to request with softButtons with .jpeg image and isTemplate=true
SUCCESS resultCode to PerformInteraction request that uses the ChoiseSet added with .jpeg image and isTemplate=true
HMI responds with SUCCESS result code instead of WARNINGS in case PerformInteraction is requested with not existed image in choiceSet
HMI responds with WARNINGS code in case core requests RPC with STATIC image type
HMI sends OnButtonEvent, OnButtonPress notifications on VR command
Prevent JS error when navigationText1 or 2 is not sent in ShowConstantTBT
Sending SIVD SEAT with heating/cooling/massage does not update UI
Remove references to outdated event functions
HMI does not de-activate app when it is uninstalled
HMI sends OnUpdateFile and OnUpdateSubMenu notifications on Activate App
Uncaught ReferenceError: fileName is not definederror on HMI during file deletingHMI sends deprecated OnFindApplications notification to SDL
OnVehicleData is sent with param name clusterModes instead of clusterModeStatus
HMI must put applications to HMI level "LIMITED"
HMI Sends ActivateApp with null appId
HMI is unable to send "RC.SetGlobalProperties" response with error resultCode
HMI Sends invalid
seatControlData.memory.idvalue in OnInteriorVehicleData for SEAT module