[Config] Fix QGLViewer find module on windows #4611
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [all] Fix warnings * revert change on scenes wrongly committed * Apply suggestions from code review Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com> * [all] Fix warnings * Fix runtime error due to useless destructor * take reviews into account: d_nbThreads back to int --------- Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
* [Haption] Partially fix the plugin CMake passes with SOFA-NG Fix some types and includes due to changes from SOFA-NG The plugin still does not compile * Add a readme file
…sofa-framework#4242) * Check that triangles index match the size of the triangleAroundVertexArray (Like it is done in EdgeSetTopologyContainer for EdgeAroundVertexArray) * Fix some typos
* Add option git_ref to specify which branch to checkout * forgot about the projects
…a-framework#4471) * find_package gtest or fetch gtest ; and use it for testing.Remove usage of the old one * fix compilation for newer gtest * remove source of the embedded gtest * update cmake message for SOFA_ALLOW_FETCH_DEPENDENCIES * fix define * apply suggestion by using GTest ; and remove CONFIG keyword * use cmake 3.20 version for gtest modules
* Replace tinyxml by external tinyxml2. * Customize TinyXML2 cmake module to use a find _package or fetch content mechanism. * Replace find or fetch mechanism by classical cmake find module. * Fix missed cmake target name change * Handle error if tinyxml2 package not found but required * Fix compilation with Dump Visitor activated * Install libtinyxml * FIX error checking * Actually fix... * FIX error loading VTU xml files * FIX scene test --------- Co-authored-by: bakpaul <bakpaul@hotmail.fr> Co-authored-by: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
* [VolumetricRendering] Fix the compilation But scenes crash * reflect changes from datatype change for vec3state (sofa-framework#6) * fix lots of stuff (sofa-framework#7) --------- Co-authored-by: Frederick Roy <fredroy@users.noreply.github.com> Co-authored-by: Hugo <hugo.talbot@sofa-framework.org>
* Add relative path to references files into regression-tests files * fix typo
…ofa-framework#4506) remove tinyXML find package in the common config file
* workaround when using volumetricrendering in batch mode * fix and clean computebbox
* Link dynamically with embedded metis to comply conda-forge rules * export all symbols (for MSVC) * Use external 5.1.0 metis or fallback to embedded code linked dynamically * fix comments in metis cmake module * ADD find or fetch mechanism * Remove embeded metis and put linkage to private * Fix metis dependency but still not the best fix * test * Put back public linkage * Revert "Put back public linkage" This reverts commit 71baa47. * Clean * cleaning sofa-framework#2 * Use SOFA_ALLOW_FETCH_DEPENDENCIES cmake option for metis * Add missing CImg to list of fetchable dependencies in doc * Update applications/plugins/SofaMatrix/CMakeLists.txt Co-authored-by: Frederick Roy <fredroy@users.noreply.github.com> --------- Co-authored-by: Frederick Roy <froy@lnrobo.com> Co-authored-by: Paul Baksic <30337881+bakpaul@users.noreply.github.com> Co-authored-by: bakpaul <bakpaul@hotmail.fr> Co-authored-by: Paul Baksic <paul.baksic@outlook.fr> Co-authored-by: Frederick Roy <fredroy@users.noreply.github.com>
…4525) Fix tinyXML install for windows Co-authored-by: Hugo <hugo.talbot@sofa-framework.org>
fix gtest headers install
* Add cxxopts cmake find module * fix case where cmake config file for cxxopts was found
Install FindTinyXML2 for OOT compilation using the binaries
Remove error and send warning when cxxopt is found but version mismatch
…e_to_tinyxml_guiqt [GUI.qt] Set link to tinyxml2 to PRIVATE and fix config file
…#4564) * Remove error and send warning when cxxopt is found but version mismatch * [all] Install FindTinyXML2 (sofa-framework#4545) Install FindTinyXML2 for OOT compilation using the binaries * [Visual] Fix cmake config (sofa-framework#4555) Remove the find_package(tinyxml2 REQUIRED) because the link is private * Set link to tinyxml2 to PRIVATE and fix config file * Check if version is specified before checking the version to avoid errors * Set cxx_opts_FOUND when the version is not required --------- Co-authored-by: Hugo <hugo.talbot@sofa-framework.org>
…4570) * handle cmake config files starting with uppercase for case sensitive OS * fix case where config cmake file is used and version defined by config files * do not fail on error if wrong version is installed and allow fetching
* Create real imported target instead o interface * test macos install tinyxml2 * fix tinyxml2 rpath --------- Co-authored-by: Hugo <hugo.talbot@sofa-framework.org>
olivier-roussel
added
pr: fix
olivier-roussel
added
the
pr: status to review
hugtalbot
removed
the
pr: status to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conda package of qglviewer on windows produces libraries prefixed QGLViewer2 instead of QGLViewer. This seems limited to the conda package on windows (does not appear on other OS). Also, the only other libqglviewer package I know for windows, which is vcpkg, is not affected neither (library is properly named QGLViewer).
I think this should be corrected on conda package side, but meanwhile it ever happens one day, this would solve the problem for now.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if