-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Both js and jsx or ts and tsx #10002
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as I have an exception when using yarn with npx i forced it to use npm instead by: ``` --use-npm ```
Update index.md
Fixed Angular button example story
Add BBC to list of examples
Fix CSF in MDX recipe
Typescript: Export IStory in `@storybook/angular`
Fix broken link to repo in empty knobs panel
Addon-docs: Fix TS false default value in prop table
L56 was missing an `=`, breaking `npm run storybook`
Added missing = in angular guide
Addon-docs: Revert breaking source indentation fix
Remove duplicate text
This may be intuitive enough to some, but it took me a minute to figure out so I think it'd be nice to have here.
Update Custom Body Documentation
Improve Typescript Configuration documentation page
chore: change rax link
FIX storybookjs#8504 - HTML elements get their classes dropped in MDX
…w-files Storyshots: Fix support for jsx/tsx config files
…-support Core: Use telejson for websockets channel
…values Props: Fix typescript unspecified default value
…r-addon-centered Centered: remove `typesVersions` attribute
docs: add example for more meaningful static storybookUrl file path
Fix custom webpack config docs
Updated Regex to accommodate both Js and JSX or ts and TSX.
thakursachin467
requested review from
ndelangen,
shilman and
stijnkoopal
as code owners
February 29, 2020 19:24
shilman
approved these changes
Mar 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
shilman
requested changes
Mar 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please target this PR to next
?
Target Branch changed to next. Closing this PR created a new one #10003 . I took the wrong base to create the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Regex to accommodate both Js and JSX or ts and TSX.
Issue:
What I did
Update default template generation in storybook cli to add jsx/ts/tsx file.