finish microcosm marketing site #506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We encountered an issue on an app using 12.12.x where we needed the payloads from `repo.parallel` when it completed. This commit upstreams that change.
This commit updates repo.parallel such that it can accept plain JavaScript objects. In this case, the return payload is an object who's keys match the shape provided. This also allows generator actions to yield objects
* trial 1 for locked scroll behavior * trying out two columns layout * experimenting with react-intersection-observer * set up IntersectionObserver and have it pull from json file * restructured base layout for new design and did basic styling * implementing intersection observer to change text on scroll * added functionality to change view by button and started refactoring * tweaked Intersection Observer to run smoother, added third section * removed unnecessary comments * remove comment * ran yarn format * fixed weird formatting by yarn * fixed more weird formatting by yarn * tweaking based on PR comments * finished refactoring to change classnames on rerender * refactored to rerender based on one state property only * changed var name to be more clear * got rid of unnecessary ids * ran yarn format * removed prettier as dev dependency and ran yarn format * Ch/bg color change (#456) * Ch/layout (#457) * Ch/qa scrolling (#458) * moved polyfill inside componentDidMount * trying new way to import polyfill
* trying out new design mobile * tweaked side nav to work on scroll * added correct file for arrow svg and tweaked padding * added arrow to graphic * refactored to export out side nav * ran yarn format * refactored to use state to add classname * refactored to store a map that holds DOM elements * refactored json file to be used for side nav
* refactored how we pull in images using gatsby docs * color for text and buttons change on scroll * added all dummy text. refactored how colors change * refactored color loops in scss * small tweaks * ran yarn format * add icons, minify images (#465) * add intro and conclusion sections (#466) * add browser graphic (#467)
* added lazy-sizes lib * added lazy loader styles and fixed some svg things that were causing console errors * trying new plugin * yarn format * removed other plugin, tweaked scss
* started refactoring to allow for adding classes on update * added functionality to fade graphics on scroll * refactored header to use same fade animation as content * made small tweaks and ran yarn format * renamed file * refactored animation * tweaked anim timing * refactored fade thresholds and scss * refactored how animations are done, animated subheadings and button * ran yarn format, refactored to use class instancence props * set up flip animations (#472)
This commit adds back patch and reset as deprecated API calls. This is for backwards compatability with Microcosm 12.x.
This commit allows Subjects to be completed with a payload. This improves ergonomics and compatability with usage in Microcosm 12.x. The drawback to this approach is that an extra action status is dispatched. I have alleviated that by adding a `filter` method to the Observable prototype that Domains use to avoid dispatch if an action update has no impact on their state. This actually ended up being a greater efficiency update than I anticipated, allowing me to unskip a few tests.
This commit adds back the max history option to Microcosm, a feature of 12.x that controls how many actions Microcosm's history should hold on to. This is zero by default in order to prevent memory leaks. However some apps (like email editors we have built in the past) may desire to hold on to a set number of actions for undo/redo and reporting features.
* Upgrade build dependencies * Bump CircleCI node image to 8.10 * Address minification bugs upgrading Uglify
The scheduler is a critical piece of Microcosm 13, and it didn't have any flow type coverage. Adding flow types uncovered a bug where Observable was accessing the scheduler's error handler from the wrong namespace.
The observable test to confirm proper error reporting uses an internal API. As such, it must be marked as a dev-only test.
This commit changes the way Subjects and Microcosm action resolution handle promises such that the error state is passed into the second argument of `promise.then()`. This prevents a case where callbacks following the success case could raise an exception, but it would be trapped by the `.catch()` API call.
leobauza
force-pushed
the
finalize-microcosm-site
branch
from
1bca0c4 to
53ad183
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easier to check out copy changes here: https://deploy-preview-506--inspiring-golick-b2d9e5.netlify.com/
Mostly need any feedback on copy, there is also some new CSS and some React code for the hamburger menu.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Fixes #493 : changing it up to get a first version up, we can revise it later to animate the checkmark and what not
Fixes #492 : Added copy
Fixes #491 : Added a nav