[Mobile] Display 'In-Person (POS)' for transactions from mobile POS #9802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…annel for individual transaction from Stripe charge and metadata, and getTransactionChannel for transaction list from transactions.
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +234 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
* develop: Wait for Stripe js to load before using it (#9770) Remove redundant stripe payment elements mount for pay for order (#9813) Enforce proper return types for methods get_order_from_event_body (#9761) Update phpcompatibility to develop version to get sniffs for PHP 8 (#9697) Enable ECE Tracks Events when WooPay is disabled (#9793) chore: rename PRB constants to ECE (#9768) Amend changelog entries for release 8.5.1 fix: remove 'test mode' badge from shortcode checkout (#9800) Update version and add changelog entries for release 8.5.1
6 tasks
* develop: Ensure ECE button load events are triggered for multiple buttons on the same page (#9845) Payouts: Add payout bank reference key to payout reports and CSV (#9832) Fix WooPay component spacing (#9748) Use paragraph selector instead of label for pmme appearance (#9840) Allow redirect to the settings page from WCPay connect (#9827) Update references to woocommerce_payments_server (#9824) Fix return types in DocBlocks (#9815) Fix WooPay trial subscriptions purchases (#9778)
* develop: Remove payout timing notice and update the help tooltip. (#9812) Fix styling on payment details page in mobile view. (#9790) Prevent browser error on dispute evidence submission (#9847) Update inquiry order notes to use inquiry specific content (#9828) Restrict Stripe Link to credit card payment method and improve cleanup (#9822)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of woocommerce/woocommerce-ios#14478
Changes proposed in this Pull Request
📝 This PR depends on the server-side changes in https://github.com/Automattic/transact-platform-server/pull/6898 that stores the new transaction channel value
in_person_pos.Why
More context about the changes: pdfdoF-5QB-p2.
In order to differentiate transactions from the mobile apps between POS and store management:
ipp_channel: mobile_pos|mobile_store_managementin the payment intent (iOS for now) that is recorded in the Stripe chargein_person_posis set to thechannelcolumn that indicates the transaction is from mobile POS (changes in https://github.com/Automattic/transact-platform-server/pull/6898)For the WooPayments plugin, the impact is on how we display the channel for transactions from POS and the channel filter. Based on the decision from pdfdoF-5UW-p2 (Option 1), the proposed changes are:
In-Person (POS)for the channel value in:How
The main changes in this PR are to separate the channel string getter from a
getChargeChannel( type: string ): stringto two functions because the data type is different from the transaction list and transaction details:getTransactionChannel = ( channel: string ): string: used for the channel value in the transaction list, where the transaction is the data sourcegetChargeChannel = ( type: string, metadata: Record< string, any > ): string: used for the channel value in transaction details, where a Stripe charge and metadata are the data source instead of a transactionTesting instructions
Prerequisites:
WCiOS
ipp_channelmetadata in payment intent from store management/POS use cases woocommerce/woocommerce-ios#14479Connect to reader--> it should proceed to connect to a simulated reader and make a simulated payment successfullyWooPayments side
In-Person (POS)for the POS order,In-Personfor the IPP order, andOnlinefor the online orderAll Transactions>Advanced filters>Add a filter>Channel--> the options should only haveOnlineandIn-PersonExample screenshots
Channel filter
Transaction list
Transaction details
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge