Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StaticAnalysis] CI ExampleAnalysis #18454

Merged
merged 47 commits into from
Jun 17, 2022
Merged

[StaticAnalysis] CI ExampleAnalysis #18454

merged 47 commits into from
Jun 17, 2022

Conversation

MoChilia
Copy link
Member

@MoChilia MoChilia commented Jun 9, 2022 •
edited
Loading

Description

Analyze the examples in src\ModuleName\**\help\*.md updated by each pull request.

Changed :

  1. Change phases for src\ModuleName\**\*.md from build: module to build:dependent-module in .ci-config.json
  2. Change the path of FilesChanged.txt from the root folder to the 'artifacts' folder (related codes are updated)

Added:

  1. build.proj : Add target StaticAnalysisExample
  2. tools\StaticAnalysis\ExampleAnalyzer includes
    • Measure-MarkdownOrScript.ps1, utils.ps1: A new tool used PSScriptAnalyzer and custom rules to check example issues
    • AnalyzeRules\CommandName.psm1, AnalyzeRules\ParameterNameAndValue.psm1: The custom rules
    • ExampleIssue.cs: Used to output error informations with issueChecker
  3. Add illustration for ExampleIssues in documentation\Debugging-StaticAnalysis-Errors.md

Test PR:
[StaticAnalysis] CI ExampleAnalysis (test for md)
Test all rules for only changing markdown files and suppress. Test succeeded.

[StaticAnalysis] CI ExampleAnalysis (test for dependent module)
Test for changing md with cmdlets in other module. Test failed with: invaild cmdlet.

[StaticAnalysis] CI ExampleAnalysis (test for cs)
Test for changing cs file. Test succeeded.

[StaticAnalysis] CI ExampleAnalysis (test for tools)
Test for changing files in tools folder. Test succeeded.

[StaticAnalysis] CI ExampleAnalysis (test for ChangeLog)
Test for changing ChangeLog.md. Test succeeded.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

MoChilia and others added 25 commits May 30, 2022 15:43
@MoChilia
add scriptAnalyzer
f24c629
@MoChilia
test for change cs
4de10ef
@MoChilia
test for change both .cs and .md
41e4d3d
@MoChilia
fix a bug: error when no changed file
7bc2b26
@MoChilia
fix output of result
143ef53
@MoChilia
test for wrong md
90dc8c7
@MoChilia
Merge branch 'shiying/ci-example' into shiying/test-ci-example
7aaa1d4
@MoChilia
fix import-module
60420cf
@MoChilia
Merge branch 'shiying/test-ci-example' of https://github.com/Azure/az…
be403db 
…ure-powershell into shiying/test-ci-example
@MoChilia
sync up with shiying/ci-example
05b8bac
@MoChilia
output by issueChecker
44ea809
@MoChilia
fix the bug for exceptionFilePath
a61081d
@MoChilia
Report errors according to the .csv
2eb38a3
@MoChilia
Test output of scriptAnalyzer
955c5be
@MoChilia
test
919c760
@MoChilia
restore
f3578f4
@MoChilia
fix bug for module name
22d693a
@MoChilia
fix bug for module name
3ab5bbc
@MoChilia
build dependent-module for md; complete csv; output in one ps1
e7b9b57
@MoChilia
illustration for example issue; add suppress; change problemId
0257709
@MoChilia
Update Program.cs
f11dbd7
@MoChilia
Update Measure-MarkdownOrScript.ps1
21d5d3f
@MoChilia
add suppress function
b7a0b7b
@MoChilia
Delete ExampleAnalyzer.cs
a1e11c9
@MoChilia
Update ParameterNameAndValue.psm1
26933bd 
fix a bug for not found module name
isra-fel
isra-fel reviewed Jun 14, 2022
View reviewed changes
.azure-pipelines/util/analyze-steps.yml Outdated Show resolved Hide resolved
tools/BuildPackagesTask/Microsoft.Azure.Build.Tasks/FilesChangedTask.cs Outdated Show resolved Hide resolved
build.proj Outdated Show resolved Hide resolved
build.proj Outdated Show resolved Hide resolved
documentation/Debugging-StaticAnalysis-Errors.md Outdated Show resolved Hide resolved
tools/StaticAnalysis/ExampleAnalyzer/AnalyzeRules/CommandName.psm1 Outdated Show resolved Hide resolved
tools/StaticAnalysis/ExampleAnalyzer/ExampleIssue.cs Show resolved Hide resolved
tools/StaticAnalysis/Exceptions/Az.Accounts/ExampleIssues.csv Outdated Show resolved Hide resolved
tools/StaticAnalysis/ProblemIDs.cs Show resolved Hide resolved
tools/StaticAnalysis/Exceptions/Az.Accounts/ExampleIssues.csv Outdated Show resolved Hide resolved
@MoChilia
Copy link
Member Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s), but failed to run 2 pipeline(s).

@MoChilia
Copy link
Member Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s), but failed to run 2 pipeline(s).

@MoChilia
Copy link
Member Author

/azp run azure-powershell - windows-powershell

@azure-pipelines
Copy link
Contributor

Azure Pipelines failed to run 1 pipeline(s).

@MoChilia MoChilia closed this Jun 16, 2022
@MoChilia MoChilia deleted the shiying/test-ci-example branch June 16, 2022 02:47
@MoChilia MoChilia restored the shiying/test-ci-example branch June 16, 2022 02:49
@MoChilia MoChilia reopened this Jun 16, 2022
@isra-fel
Copy link
Member

The PR LGTM (looks good to me) generally.
We can bring down the severity, merge it, and let the example analyzer run for a week to see the results.

@MoChilia MoChilia marked this pull request as ready for review June 17, 2022 02:50
@isra-fel isra-fel merged commit 2beb247 into main Jun 17, 2022
Nickcandy added a commit that referenced this pull request Jun 29, 2022
@Nickcandy @wyunchi-ms
@VeryEarly @azure-powershell-bot @mikefrobbins @BethanyZhou @AbhishekMallick-MS @CaptainFanZzz @RakeshMohanMSFT @Jingshu923 @isra-fel @ziyuezh576 @NaridaL @ostojicb @dolauli @v-yuzhichen @kr-santosh @imadan1996 @vidai-msft @Vishakha-Git @kaushik-ms @LukeSlev @grizzlytheodore @khkh-ms @blueww @MoChilia @dingmeng-xue @JulianePadrao @lilinvictorms @damodaravadhani @kceiw @lijinpei2008 @navba-MSFT @mgreenegit @PramodValavala-MSFT @ayeshurun @haagha @IliasKhan @iliaskha @nbnakano @thomasp98296
merge main to branch (#18815)
a03029b 
* [Aks]Update the logic for `-NodeImageOnly` (#18323)

* Update the logic for NodeImageOnly

* Update the test case of Aks

* [Aks]Added property PowerState for the output of Get-AzAksCluster (#18339)

* Added oroperty PowerState for the output of Get-AzAksCluster

* Update ChangeLog.md

Co-authored-by: Yabo Hu <yabhu@microsoft.com>

* [ApplicationInsights] Fixed parameters for Set-AzApplicationInsightsDailyCap (#18349)

* Move ApplicationInsights to main

* Update ChangeLog.md

* Update ChangeLog.md

Co-authored-by: azure-powershell-bot <65331932+azure-powershell-bot@users.noreply.github.com>

* Moved Aladdin example note outside of code block (#18357)

Co-authored-by: Mike F. Robbins <mikefrobbins@users.noreply.github.com>

* Provide detailed description for parameter CertificateString in Import-AzKeyVaultCertificate (#18348)

* Update Enable-AzRecoveryServicesBackupProtection.md (#18364)

* Update Enable-AzRecoveryServicesBackupProtection.md

Incorporated updates from PM.

* Update Enable-AzRecoveryServicesBackupProtection.md

* Update Enable-AzRecoveryServicesBackupProtection.md

* Update Enable-AzRecoveryServicesBackupProtection.md

Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>

* Move ADDomainServices to main (#18366)

* Move ADDomainServices to main

* Update Changelog.md

* Update SignatureIssues.csv

Co-authored-by: azure-powershell-bot <65331932+azure-powershell-bot@users.noreply.github.com>

* Corrected broken links from build warnings (#18380)

* Corrected broken links from build warnings

* Corrected additional broken links

Co-authored-by: Mike F. Robbins <mikefrobbins@users.noreply.github.com>

* Add ManagedIdentity support for Aks (#18385)

* Corrected broken links (#18395)

Co-authored-by: Mike F. Robbins <mikefrobbins@users.noreply.github.com>

* Add TestRunner and replace TestBase (#18399)

* {ApiManagement} | Add a sample to update an existing API (#18347)

* {ApiManagement} | Add a sample to update an existing API

Fixes #18296

* {API Management} | Updating example number

Fixes PR #18347

* Fixing a typo

Fixing a typo

* OOB release for GuestConfiguration/KubernetesConfiguration/SackHCI (#18326)

* bump version for Az.KubernetesConfiguration

* bump version for Az.StackHCI

* bump version for Az.GuestConfiguration

* update version in AzPreview.psd1

* [DataFactory]Updated ADF .Net SDK version to 6.2.0 (#18327)

* [DataFactory]Updated ADF .Net SDK version to 5.4.0

* [DataFactory]Updated ADF .Net SDK version to 6.0.0

* [DataFactory]Fixed Set-AzDataFactoryV2 -InputObject not correct with PublicNetworkAccess Parameter

* [DataFactory] Updated ADF .Net SDK version to 6.1.0

* [DataFactory]Updated ADF .Net SDK version to 6.2.0

* handle same env var name but different casing (#18312)

* Add StorageSyncTestRunner to replace TestController (#18351)

* Add StorageSyncTestRunner to replace TestController

* Add StorageSyncTestRunner to replace TestController

* Add SynapseTestRunner to replace SynapseTestBase (#18325)

* Add SynapseTestRunner to replace SynapseTestBase

* Add SynapseTestRunner to replace SynapseTestBase

* Add SynapseTestRunner to replace SynapseTestBase

* Add SynapseTestRunner to replace SynapseTestBase

* Edit ServiceBusTestRunner and remove TestController (#18404)

* Edit ServiceBusTestRunner and remove TestController

* remove RecordMatcher

* Remove unnecessary module

Co-authored-by: Ziyue Zheng <v-ziyzhe@microsoft.com>

* [KeyVault] Supported creating/updating key with release policy in a Managed HSM (#18374)

* Supported creating/updating key with release policy in a Managed HSM

* Refine codes

* Update update-azkeyvault.md

* add example for secure key

* upgrade Azure.Security.KeyVault.Keys to 4.3.0-beta.7

* [BotService] Migrate from generation branch. (#18397)

* Move BotService to main

* Fix the issue of location

Co-authored-by: azure-powershell-bot <65331932+azure-powershell-bot@users.noreply.github.com>

* fix typo beging -> begin in 3 files (#18391)

* Move ContainerInstance to main (#18428)

Co-authored-by: azure-powershell-bot <65331932+azure-powershell-bot@users.noreply.github.com>

* [SQL] Check if DB is created by log replay before dropping it (#18409)

* check if db created by log replay before dropping it

* Add test

* Bump err string

* Bump changelog

* [Doc] Internal guide for using config framework (#18443)

* Create using-config-framework.md

* Update using-config-framework.md

* Update using-config-framework.md

* Update using-config-framework.md

* Update using-config-framework.md

* Update using-config-framework.md

* Update using-config-framework.md

* Update using-config-framework.md

* Update using-config-framework.md

* Update using-config-framework.md

* Update using-config-framework.md

* Update using-config-framework.md

* Update using-config-framework.md

* Update using-config-framework.md

* Update using-config-framework.md

* Update using-config-framework.md

* autorest powershell docker file into auzre powershell repo (#18442)

* Fix Az.Aks Xml comments (#18361)

* Fix Az.Aks Xml comments

* Fix Az.Aks Xml comments

* Fix Az.Blueprint XML Comments (#18387)

* Fix Az.Blueprint XML Comments

* Fix Az.Blueprint XML Comments

* Fix Az.MachineLearning XML Comments (#18450)

* Fix Az.LogicApp XML Comments (#18447)

* fix for issue #18398 (#18452)

* [ConnectedMachine] Move ConnectedMachine to main (#18453)

* Move ConnectedMachine to main

* Update Changelog.md

Co-authored-by: azure-powershell-bot <65331932+azure-powershell-bot@users.noreply.github.com>

* [KeyVault] Supported accepting rotation policy in a JSON file (#18448)

* Supported accepting rotation policy in a JSON file

* suppress breaking change issues

* upgrade Azure.Security.KeyVault.Keys to 4.3.0

* Add SqlTestRunner to replace SqlTestsBase (#18352)

* Add SqlTestRunner to replace SqlTestsBase

* Add SqlTestRunner to replace SqlTestsBase

* Add SqlTestRunner to replace SqlTestsBase

* Update SqlTestRunner.cs

* Fix Az.ContainerRegistry Xml Comments (#18388)

* Fix Az.CosmosDB XML Comments (#18401)

* Fix Az.CosmosDB XML Comments

* Fix Az.CosmosDB XML Comments

* Update PSClientEncryptionPolicy.cs

Co-authored-by: Ziyue Zheng <v-ziyzhe@microsoft.com>

* Fix Az.DataBoxEdge XML Comments (#18402)

* Fix Az.Automation XML Comments (#18407)

* Fix Az.Automation XML Comments

* Fix Az.Automation XML Comments

* Update SourceControlSyncJobStream.cs

Co-authored-by: Ziyue Zheng <v-ziyzhe@microsoft.com>

* Fix Az.DataLakeAnalytics XML Comments (#18403)

* Fix Az.Compute XML Comments (#18408)

* Fix Az.Compute XML Comments

* Fix Az.Compute.Helpers XML Comments

* Fix Az.DataLakeStore XML Comments (#18421)

* Fix Az.DataLakeStore XML Comments

* Fix Az.DataLakeStore XML Comments

Co-authored-by: Ziyue Zheng <v-ziyzhe@microsoft.com>

* Fix Az.DataMigration XML Comments (#18422)

* Fix Az.EventHub XML Comments (#18429)

* Fix Az.EventHub XML Comments

* Update PSNetworkRuleSetAttributes.cs

Co-authored-by: Ziyue Zheng <v-ziyzhe@microsoft.com>

* Fix Az.HDInsight XML Comments (#18432)

* Fix Az.IotHub XML Comments (#18433)

* Fix Az.IotHub XML Comments

* Fix Az.IotHub XML Comments

Co-authored-by: Ziyue Zheng <v-ziyzhe@microsoft.com>

* [CosmosDB] Fixes issue with Update-AzCosmosDBSqlContainer command on containers with  Client Encryption Policy (#18480)

* Support client encryption policy during container creation

* Update SqlOperationsTests.ps1

* Update New-AzCosmosDBSqlContainer.md

* Update PSClientEncryptionPolicy.cs

* Update NewAzCosmosDBSqlContainer.cs

* Update ChangeLog.md

* Updated package.

* Update CosmosDB.Test.csproj

* Updated example, session records.

* updated session records.

* Fixes update container command on containers with client encryption policy.

* Update ChangeLog.md

* Update ChangeLog.md

* Bug fix for the Restore-AzSqlDatabase cmdlet (#18475)

* Pass Tags field in the Database model constructor

* Update change log

* Remove WebsitesController (#18469)

* Remove WebsitesController

* Update WebsitesTestRunner.cs

* Update WebsitesTestRunner.cs

* Fixed issue when mimicing long running operation for test in Playback mode. (#18490)

* [Az.DataProtection] OOB for Az.DataProtection (#18477)

* Move DataProtection to main

* Update Changelog.md

* bump version for Az.Dataprotection

* update version in AzPreview.psd1

Co-authored-by: azure-powershell-bot <65331932+azure-powershell-bot@users.noreply.github.com>

* Enable ARM to the Private Link connection Cmdlets (#18358)

* enable Private link support

* both set to true

* Add testcase

* Add recording

Co-authored-by: Vishakha Narvekar <vinarvek@microsoft.com>

* powershell changes for new ssl policies in appgw (#18287)

* {CosmosDB} | Getting location from the Resource Group Name (#18449)

* {CosmosDB} | Getting location from the Resource Group Name

Fixes #17978.
Though we say location parameter is optional we still expect it to be provided https://docs.microsoft.com/en-us/powershell/module/az.cosmosdb/new-azcosmosdbaccount?view=azps-8.0.0. This change will fix that issue.

* {CosmosDB} | adding missing semicolon

adding missing semicolon

* {CosmosDB} | Location is not required and can be null

Fixes #17978

* {CosmosDB} | Update change log

Though we say location parameter is optional we still expect it to be provided https://docs.microsoft.com/en-us/powershell/module/az.cosmosdb/new-azcosmosdbaccount?view=azps-8.0.0. This change will fix that issue.

* Add tag support to managed cluster cmdlets (#18473)

* Add tag support to managed cluster cmdlets

* Add changelog and examples

* Update ChangeLog.md

Co-authored-by: Yabo Hu <yabhu@microsoft.com>

* [ReceveryServices] Fix delay in long running operations (#18568)

* fix delay

* update changelog

* add param to Add-AzVhd, and New-AzHostGroup (#18333)

* add -DataAccessAuthMode to Snaptshot/Disk config/updateConfig

* trying DataAuth in Add-AzVhd

* progress save for Add-AzVhd

* updates to cmdlets

* fix NewGalleryImage instead of update, add md files, update changelog

* update last md

* remove add-azvhd stuff

* md files

* add update for Add-AzVhd DataAccessAuthMode

* add veryEarly's comments

* update

* update sdk package to 55.0.0

* add -enableUltraSSD to New-AzHostGroup

* update token. removing uneccesary "authorizerequest"

* suppress nonbreaking change

* Update ChangeLog.md

* a

* update to resolve failing tests. small object updated from swagger to address bug

* Update Compute.Automation.generated.format.ps1xml

* Update ResourceSkuListMethod.cs

Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>
Co-authored-by: Yabo Hu <yabhu@microsoft.com>

* Use an ordered hash table for generateInfo. (#18611)

Fixed the issue Azure/autorest.powershell#938

* Remove Storage TestController (#18470)

* Remove TestController

* Update StorageBlobTests.cs

* Update StorageTestRunner.cs

* Update StorageTestRunner.cs

* Add parameter CommandContextAttachmentZip to cmdlet Invoke-AzAksRunCommand (#18580)

* Zip Deployment: Return Fail Deployment if Zip Deployment endpoint doesn't return success result.  (#18593)

* adding check for zip deployment

* update the change log

* [tools] Fix issue when serialized json file is null (#18565)

* [Storage] Supported BaseBlob DaysAfterCreationGreaterThan in Management Policy (#18561)

* Fix Az.Monitor XML Comments (#18438)

* Fix Az.Monitor XML Comments

* remove changes on csproj

* fix //

* fix //

* add desc

* add desc

* [DataFactory]Updated ADF .Net SDK version to 6.3.0 (#18572)

* [DataFactory]Updated ADF .Net SDK version to 5.4.0

* [DataFactory]Updated ADF .Net SDK version to 6.0.0

* [DataFactory]Fixed Set-AzDataFactoryV2 -InputObject not correct with PublicNetworkAccess Parameter

* [DataFactory] Updated ADF .Net SDK version to 6.1.0

* [DataFactory]Updated ADF .Net SDK version to 6.2.0

* [DataFactory]Updated ADF .Net SDK version to 6.3.0

* [StaticAnalysis] CI ExampleAnalysis (#18454)

* add scriptAnalyzer

* test for change cs

* test for change both .cs and .md

* fix a bug: error when no changed file

* fix output of result

* test for wrong md

* fix import-module

* sync up with shiying/ci-example

* output by issueChecker

* fix the bug for exceptionFilePath

* Report errors according to the .csv

* Test output of scriptAnalyzer

* test

* restore

* fix bug for module name

* fix bug for module name

* build dependent-module for md; complete csv; output in one ps1

* illustration for example issue; add suppress; change problemId

* Update Program.cs

* Update Measure-MarkdownOrScript.ps1

* add suppress function

* Delete ExampleAnalyzer.cs

* Update ParameterNameAndValue.psm1

fix a bug for not found module name

* skip autogenerated example

* fix output; output missing errors for placeholders; fix description

* fix bugs

* Combine install platyPS and PSScriptAnalyzer together into a "Install PowerShell Dependencies"

* abandon Jenkins for CI

* Apply suggestions from code review

Co-authored-by: Yeming Liu <11371776+isra-fel@users.noreply.github.com>

* comment for problemID

* Update analyze-steps.yml

* use absolute path instead of relative path

* output unexcepted error

* fix a bug

* optimize writing

* Update tools/StaticAnalysis/ExampleAnalyzer/utils.ps1

Co-authored-by: Yeming Liu <11371776+isra-fel@users.noreply.github.com>

* change regular expression for exampletitle

* restore

* change severity

* change severity

* change comment

* match autogenerated examples

* fix getting function name

Co-authored-by: Yeming Liu <11371776+isra-fel@users.noreply.github.com>

* Feature/cplat add az vhd improve (#17999)

* update

* add PSDisk

* updates

* Differencing disk convert bug

* Update field names to match specification.

* update field to use current Size

* dynamic upload conversion on-the-fly

* update output methods, changelog

* remove shouldSupport

* update description, console output, and fix resizing.

* update output format, typos

* grammar

* suppress breaking change, no change in customer usage

* undo adding -keepConvertedResizedFile, and do not return PSDisk

* fix error

* Revert "fix error"

This reverts commit 1464d50.

* fix error

* change capitalization

* change variable name

* remove debug Console output

* resolve filePath to VHD File

* refactor/clean up code

* when synchronize fails, clean up resource then throw terminating error

* Add OS checking and warning before conversion/resizing

* adjust to follow conventions

* test and fix small error

* Update ChangeLog.md

* Update ChangeLog.md

Co-authored-by: Yabo Hu <yabhu@microsoft.com>

* export import configs (#18371)

* Update version of Microsoft.Identity.Client for .NET Framework (#18579)

* Update version of Microsoft.Identity.Client for .NET Framework

* update

* [SQL] fix for deprecated term (#18620)

* Fix an issue blocking CI during example analysis (#18626)

* Generalize input MarkdownPaths

* fix exampleIssues.csv

* fix a bug

* fix a bug

* change severity

* fix a bug

* fix csv

* restore

* Update Azure Batch private link registration (#18284)

* Update Azure Batch private link registration

Update Azure Batch private link registration to use latest RP API version 2022-06-01.

* Fix failed test due to updated api version

* add TestRunner and remove TestBase in RecoveryServices (#18617)

* add TestRunner and remove TestBase in RecoveryServices

* remove zip file and add intro

* remove some meaningless numbers

* Fix Az.FrontDoor XML Comments (#18575)

* Fix Az.NetWork XML Comments (#18461)

* Fix Az.NetWork XML Comments

* Fix Az.NetWork XML Comments

Co-authored-by: Ziyue Zheng <v-ziyzhe@microsoft.com>

* [Az.Accounts] Fixed incorrect access token (#18414)

* fixed incorrect access token

* fix

* Corrected typo in Get-AzAlert (#18646)

* fix for issue #18606

* fix for issue #18606

* Fix Az.keyVault XML Comments (#18446)

* Fix Az.keyVault XML Comments

* Fix Az.keyVault XML Comments

* Fix merge conflict marker

Co-authored-by: Ziyue Zheng <v-ziyzhe@microsoft.com>

* Fix Az.NetAppFiles XML Comments (#18460)

* Fix Az.NetAppFiles XML Comments

* Update PSNetAppFilesVolumeBackupProperties.cs

Co-authored-by: Ziyue Zheng <v-ziyzhe@microsoft.com>

* Fix Az.PrivateDns XML Comments (#18583)

* Fix Az.Relay XML Comments (#18485)

* Fix Az.RecoveryServices XML Comments (#18484)

* Fix Az.RecoveryServices XML Comments

* Fix Az.RecoveryServices XML Comments 1

* Remove KeyVaultManagementController.cs (#18618)

* Remove KeyVaultManagementController.cs

* Remove KeyVaultManagementController.cs

* Remove KeyVaultManagementController.cs

* Update KeyVault.Test.csproj

* Update KeyVaultTestRunner.cs

* Update KeyVaultManagementTests.cs

* Fix Az.ServiceBus XML Comments (#18500)

* Fix Az.ServiceBus XML Comments

* Fix Az.ServiceBus XML Comments

Co-authored-by: Ziyue Zheng <v-ziyzhe@microsoft.com>

* Fix Az.Peering XML Comments (#18649)

* Fix Az.Peering XML Comments

* Fix Az.Peering XML Comments

Co-authored-by: Ziyue Zheng <v-ziyzhe@microsoft.com>

* Fix Az.Resources XML Comments (#18486)

* Fix Az.Resources XML Comments

* Fix Az.Resources XML COmments

* Fix Az.Resources XML Comments

Co-authored-by: Ziyue Zheng <v-ziyzhe@microsoft.com>

* Fix Az.AnalysisServices XML Comments (#18648)

* Fix Az.Synapse XML comments (#18605)

* Fix Az.Support XML comments (#18604)

* Fix Az.StorageSync XML comments (#18603)

* Fix Az.Storage XML comments (#18601)

* Fix Az.ServiceFabric XML Comments (#18586)

* Fix Az.Security XML Comments (#18487)

* Fix Az.WebSites XML Comments (#18588)

* Fix Az.SqlVirtualMachine XML comments (#18582)

* Fix Az.Sql XML comments (#18576)

* Fix Az.Sql XML comments

* Fix Az.Sql XML comments

* Update DatabaseEditions.cs

* Update MoveFromGeneration2Master.ps1 (#18660)

* [EventHubs]: Application Group CmdLets (#18640)

* Application Groups cmdlets

* documentation

* documentation and testing

* fixes

* fixes

* upgrading other RP's that use EH

* Update SignatureIssues.csv

* pipeline fixes

* changelog

* fixes

* Update ChangeLog.md

Co-authored-by: Yabo Hu <yabhu@microsoft.com>

* format the help markdown file of Az.Automation (#18415)

* format the help markdown file of Az.Automation

* format the help markdown file of Az.Automation

* Update Get-AzAutomationSourceControlSyncJobOutput.md

Co-authored-by: Ziyue Zheng <v-ziyzhe@microsoft.com>

* format the help markdown files of Az.KeyVault (#18632)

* format the help markdown files of Az.IotHub (#18631)

* format the help markdown files of Az.LabServices (#18614)

* format the help markdown files of Az.LabServices

* delete space

* format the help markdown files of Az.EventHub (#18613)

* format the help markdown file of Az.EventHub

* format the help markdown files of Az.EventHub

Co-authored-by: Ziyue Zheng <v-ziyzhe@microsoft.com>

* format the help markdown files of Az.CosmosDB (#18602)

* format the help markdown file of Az.CosmosDB

* Update New-AzCosmosDBAccount.md

Co-authored-by: Ziyue Zheng <v-ziyzhe@microsoft.com>

* format the help markdown file of Az.Batch (#18596)

* format the help markdown file of Az.Batch

* Update New-AzBatchTask.md

Co-authored-by: Ziyue Zheng <v-ziyzhe@microsoft.com>

* format the help markdown file of Az.ServiceLinker (#18570)

* format the help markdown file of Az.ServiceFabric (#18566)

* format the help markdown file of Az.ServiceBus (#18560)

* format the help markdown file of Az.ServiceBus

* format the help markdown file of Az.ServiceBus

Co-authored-by: Ziyue Zheng <v-ziyzhe@microsoft.com>

* format the help markdown file of Az.Reservations (#18499)

* format the help markdown file of Az.Reservations

* Update Get-AzReservationQuote.md

* Update New-AzReservation.md

Co-authored-by: Ziyue Zheng <v-ziyzhe@microsoft.com>

* format the help markdown file of Az.NetAppFiles (#18455)

* format the help markdown file of Az.NetAppFiles

* format the help markdown file of Az.NetAppFiles

* format the help markdown file of Az.NetAppFiles

Co-authored-by: Ziyue Zheng <v-ziyzhe@microsoft.com>

* Update New-AzApiManagement for issue #18439 (#18451)

* fix for issue #18439

* change code in one line

* format

* format the help markdown file of Az.Security (#18437)

* format the help markdown file of Az.Security

* format az.security help markdown file

* format az.security help markdown file

* format the help markdown file of Az.Security

Co-authored-by: Ziyue Zheng <v-ziyzhe@microsoft.com>

* format the help markdown file of Az.EventGrid (#18436)

* format the help markdown file of Az.EventGrid

* format az.eventgrid help markdown file

* format the help markdown file of Az.Compute (#18434)

* format the help markdown file of Az.Compute

* format the help markdown file of Az.Compute

* format the help markdown file of Az.HealthcareApis (#18418)

* format the help markdown file of Az.Websites (#18416)

* format the help markdown file of Az.Websites

* format the help markdown file of Az.Websites

* format the help markdown file of Az.Websites

* Update Get-AzWebAppSlotTriggeredWebJobHistory.md

Co-authored-by: Ziyue Zheng <v-ziyzhe@microsoft.com>

* format the help markdown file of Az.ApiManagement (#18377)

* format the help markdown file of Az.ApiManagement

* update New-AzApiManagementUserToken

* format the help markdown file of Az.AlertsManagement (#18376)

* format the help markdown file of Az.AlertsManagement

* Update Set-AzAlertProcessingRule

* format the help markdown file of Az.AlertsManagement

* format the help markdown file of Az.AlertsManagement

Co-authored-by: Ziyue Zheng <v-ziyzhe@microsoft.com>

* format the help markdown file of Az.Relay (#18498)

* Fix Az.Accounts XML Comments (#18663)

* Update PrepareAutorestModule.ps1 (#18665)

* Trigger Az.Predictor CI (#18067)

* Trigger Az.Predictor CI

* Fix the issue when running the unit tests (#18300)

* Fix the issue in unit tests.

- In the module we create a minimum runspace for PowerShell, and use it to parse the command line.
  The mini runspace contains the built-in core modules for PowerShell. We don't need them when we
  package and publish our module because the runtime will have them. That'll reduce the module size.
  So in the module project we exclude `contentfiles` when we referece Microsoft.PowerShell.SDK.
- The issue in the unit tests is that it doesn't find the built-in core module when we create the runspace.
  So we have a reference to Microsoft.PowerShell.SDK in the test project to include `contentfiles` to provide
  the built-in core modules. The unit tests can run successfully.

* Test

* Update the data in the test cases (#18496)

* Fix the unit tests.

- Parsing the command parameter requires the module to be loaded. On the machine (e.g. build machine) where the Az modules are not installed, the
  parsing doesn't return the parameters names as expected. Some test cases thus fail. The fix is to remove Az cmdlets from the test cases. Instead, we
  use the cmdlet from the built-in modules in the test cases.

* Replace the way of getting the data.

- We used to zip the whole model and read from it. Since we don't need to use Az cmdlet in the test cases, we don't really need to zip the model.
  So we use the json file with crafted built-in PowerShell cmdlet as the data used in the test cases. With that, it's also clear to show the changes
  to the test cases and the data.

Add Dotnet Core 6 in pipeline.

Add logic for global.json

Add logic for global.json

* Move AzPredictor from msbuild to task

* Revert empty lines

Co-authored-by: kceiw <mahuang@microsoft.com>

* Move App to main (#18661)

* Move App to main

* Create SignatureIssues.csv

Co-authored-by: azure-powershell-bot <65331932+azure-powershell-bot@users.noreply.github.com>
Co-authored-by: lijinpei2008 <v-jinpel@microsoft.com>

* Fix Az.Attestation XML Comments (#18687)

* Fix Az.AlertsManagement XML Comments (#18686)

* UserAssignedIdentities  (#18682)

* update sdk to latest

* update add-azvm/vmss GalleryApplicationVersion

* update

* update

* changelog

Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>

* {AzureCXP} fixes #18607 (#18647)

* {AzureCXP} fixes #18607

This documentation says "Registers an Azure provider feature in your account." which is vague and makes it sound like its ties to a user account. 

The below REST API docs clearly mentions that it registers feature to the current subscription context.
https://docs.microsoft.com/en-us/rest/api/resources/features/register

fixes #18607

* {AzureCXP} fixes #18607

This documentation says "Registers an Azure provider feature in your account." which is vague and makes it sound like its ties to a user account.

The below REST API docs clearly mentions that it registers feature to the current subscription context.
https://docs.microsoft.com/en-us/rest/api/resources/features/register

fixes #18607

* clear MinimalVersion.csv after bumping version (#18657)

* Add example for Az.KeyVault.Extension in secret related commands (#18636)

* format the help markdown file of Az.Purview (#18573)

* format the help markdown file of Az.Purview

* format docs

* format the help markdown file of Az.Purview

* Win2022 azure edition core alias (#18331)

* Update Images.json

* Update New-AzVM.md

* Update NewAzureVMCommand.cs

* Update ChangeLog.md

* Update ChangeLog.md

* Update ChangeLog.md

Co-authored-by: Yabo Hu <yabhu@microsoft.com>

* Move ConfidentialLedger to main (#18695)

* Move ConfidentialLedger to main

* update changelog

Co-authored-by: azure-powershell-bot <65331932+azure-powershell-bot@users.noreply.github.com>

* Move the select module logic to variable (#18683)

* Fix Az.RecoveryServices XML Comments (#18666)

* Fix Az.RecoveryServices XML Comments

* Fix Az.RecoveryServices XML Comments

* Fix Az.Accounts XML Comments (#18692)

* Support generating XML documentation file for each assembly file (#18719)

* Add Az.Post.props

* Update all csproj files

* fix the config of md file in pipeline (#18725)

* Update CreateMappings_rules.json and GeneratedModuleList.txt (#18726)

* Update CreateMappings_rules.json

* Update GeneratedModuleList.txt

* Update GeneratedModuleList.txt

Co-authored-by: Dingmeng Xue <dixue@microsoft.com>

* update (#18706)

* [EventHubs]: Fixing Get-AzEventHubNamespace to return all namespaces for subscriptions and resource groups that have more than 100 of them. (#18672)

* accounting for pagination in code

* fixes

* changelog

* fixes

* changelog update

* suggest user to select default subscription using azconfig cmdlet (#18610)

* upadte message when >1 sub

* Update src/Accounts/Accounts/Models/RMProfileClient.cs

Co-authored-by: Mike F. Robbins <mike.robbins@microsoft.com>

Co-authored-by: Mike F. Robbins <mike.robbins@microsoft.com>

* Fix typo in example description (#18635)

* [CosmosDB] Adds support to allow partition key and id paths to be part of client encryption policy. (#18633)

* Support client encryption policy during container creation

* Update SqlOperationsTests.ps1

* Update New-AzCosmosDBSqlContainer.md

* Update PSClientEncryptionPolicy.cs

* Update NewAzCosmosDBSqlContainer.cs

* Update ChangeLog.md

* Updated package.

* Update CosmosDB.Test.csproj

* Updated example, session records.

* updated session records.

* Fixes update container command on containers with client encryption policy.

* Update ChangeLog.md

* Update ChangeLog.md

* Support partition key and id paths to be part of client encryption policy

* Update ChangeLog.md

* Update New-AzCosmosDBSqlContainer.md

* Update PSClientEncryptionPolicy.cs

* Update src/CosmosDB/CosmosDB/ChangeLog.md

Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>

Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>
Co-authored-by: Yabo Hu <yabhu@microsoft.com>

* Update SKU allowed values for PowerBI Embedded capacities (#18670)

* Update sku allowed values and doc files

* update tests with large skus

* update changelog

* Update ChangeLog.md

* fix large sku scale test and revert sln

* eol

* revert

* removing client side checks (#18698)

* [EventHubs]: Adding cmdlets to support manual approval of private endpoints (#18724)

* Adding cmdlets for private endpoints and private links

* Fixes and tests

* fixes

* Documentation

* making updates changelog

* fixes to XML

* test additions

* fix

* Upgrade common to 1.3.59 (#18745)

* Upgrade version of NewtonJson (#18732)

* Add parameter AvailabilityZone for AvailabilityZone (#18733)

* Move Cdn to main (#18735)

* Move Cdn to main

* Add exceptions

* Add exceptions

Co-authored-by: azure-powershell-bot <65331932+azure-powershell-bot@users.noreply.github.com>

* First preview release for module Az.NetworkFunction (#18734)

* Move NetworkFunction to main

* First preview release for module Az.NetworkFunction

* First preview release for module Az.NetworkFunction

* Update GeneratedModuleList.txt

Co-authored-by: azure-powershell-bot <65331932+azure-powershell-bot@users.noreply.github.com>

* Added isManagedIdentityInUse get parameter for `Get-AzSqlServerAudit` and `Get-AzSqlDatabaseAudit` (#18703)

* added isManagedIdentityInUse get parameter

* added changes to changelog

Co-authored-by: Ilias Khan <iliaskhan@microsoft.com>

* [ServiceBus]: Manual approval cmdlets for private endpoints (#18730)

* adding private endpoint and private link cmdlets

* fixes, testing and documentation

* changelog update

* test records pushing

* Upgrading SB SDK version in eventgrid

* adding eventGrid to ignore RP list

* adding eventGrid to ignore RP list

* format the help markdown files of Az.Resources (#18693)

* format the help markdown files of Az.Resources

* Update Set-AzManagedApplication.md

Co-authored-by: Ziyue Zheng <v-ziyzhe@microsoft.com>

* format the help markdown files of Az.LogicApp (#18662)

* format the help markdown files of Az.LogicApp

* format the help markdown files of Az.LogicApp

Co-authored-by: Ziyue Zheng <v-ziyzhe@microsoft.com>

* format the help markdown files of Az.Kusto (#18637)

* format the help markdown files of Az.Kusto

* format the help markdown files of Az.Kusto

Co-authored-by: Ziyue Zheng <v-ziyzhe@microsoft.com>

* format the help markdown files of Az.HDInsight in generation (#18630)

* Route with Service Tag has already been GA. (#18755)

Route with Service Tag has already been Generally available, not preview.

* OOB release for Az.Compute (#18629)

* OOB release for Az.Compute

* Update ChangeLog.md

* [CosmosDB]OOB release for CosmosDB (#18612)

* OOB release for CosmosDB

* upgrade az.cosmosdb in azpreview.psd1

* [Resources] Fix role assignment latency for New-AzADServicePrincipal (#18757)

* Move Resources to main

* Update ChangeLog.md

Co-authored-by: azure-powershell-bot <65331932+azure-powershell-bot@users.noreply.github.com>

* Update azure-powershell-modules.md for Az.App (#18753)

* Update AzPreview.psd1

* Update azure-powershell-modules.md

* Update AzPreview.psd1

* [ApplicationInsights] Fix parameter DocumentType and ResourceId (#18756)

* Move ApplicationInsights to main

* Update ChangeLog.md

* Create BreakingChangeIssues.csv

Co-authored-by: azure-powershell-bot <65331932+azure-powershell-bot@users.noreply.github.com>

* Resolved disallowed-html-tag build warnings from docs repo (#18761)

Co-authored-by: Mike F. Robbins <mikefrobbins@users.noreply.github.com>

* Fix the path of (#18769)

* Update warning message when multiple subscriptions (#18768)

* upadte message when >1 sub

* Update src/Accounts/Accounts/Models/RMProfileClient.cs

Co-authored-by: Mike F. Robbins <mike.robbins@microsoft.com>

* update warning message

Co-authored-by: Mike F. Robbins <mike.robbins@microsoft.com>

* Fix Importing Az in Parallel (#18483)

* use mutex to protect config init

* Fix ConfigKeys reference

* Removed some properties' default values during the process of key vault creation (#18767)

* Removed default value for key vault creation

* Update New-AzKeyVault.md

* Changed default access policies for Key Vault secret, certificate and storage as All

* update change log

* Update src/KeyVault/KeyVault/ChangeLog.md

* [KeyVault] Supported importing pem certificate by Import-AzKeyVaultCertificate (#18644)

* [KeyVault] Supported importing pem certificate by Import-AzKeyVaultCertificate

* explicitly specify content type though unnessary

* Update Az.KeyVault.psd1

* Update src/KeyVault/KeyVault/Az.KeyVault.psd1

* Add an optional parameter called 'Location' to create/update action group cmdls (#18678)

* Task 14768687: AzNS || Powershell and SDK - Action Groups RP API's support for location

* Add help and change log

Co-authored-by: Thomas Pham <thompham@microsoft.com>

* fix typo (#18770)

Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>
Co-authored-by: Yabo Hu <yabhu@microsoft.com>
Co-authored-by: azure-powershell-bot <65331932+azure-powershell-bot@users.noreply.github.com>
Co-authored-by: Mike F. Robbins <mike.robbins@microsoft.com>
Co-authored-by: Mike F. Robbins <mikefrobbins@users.noreply.github.com>
Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>
Co-authored-by: Abhishek Mallick <77153376+v-amallick@users.noreply.github.com>
Co-authored-by: Yufan Yang <95342181+CaptainFanZzz@users.noreply.github.com>
Co-authored-by: RakeshMohan-MSFT <49954584+RakeshMohanMSFT@users.noreply.github.com>
Co-authored-by: Jingshu923 <52914166+Jingshu923@users.noreply.github.com>
Co-authored-by: Yeming Liu <11371776+isra-fel@users.noreply.github.com>
Co-authored-by: Ziyue Zheng <v-ziyzhe@microsoft.com>
Co-authored-by: Adrian Leonhard <adrianleonhard@gmail.com>
Co-authored-by: Bogdan Ostojic <49651629+ostojicb@users.noreply.github.com>
Co-authored-by: Xiaogang <xidi@microsoft.com>
Co-authored-by: v-yuzhichen <96757176+v-yuzhichen@users.noreply.github.com>
Co-authored-by: Santosh Kulkarni <66682828+kr-santosh@users.noreply.github.com>
Co-authored-by: Ishan Rajesh Madan <99760799+imadan1996@users.noreply.github.com>
Co-authored-by: Vincent Dai <23257217+vidai-msft@users.noreply.github.com>
Co-authored-by: Vishakha-Git <61336316+Vishakha-Git@users.noreply.github.com>
Co-authored-by: Vishakha Narvekar <vinarvek@microsoft.com>
Co-authored-by: kaushik-ms <103559254+kaushik-ms@users.noreply.github.com>
Co-authored-by: Luke Slevinsky <luslevin@microsoft.com>
Co-authored-by: Theodore Chang <thchan@microsoft.com>
Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>
Co-authored-by: Khuram Khan <64149947+khkh-ms@users.noreply.github.com>
Co-authored-by: Wei Wei <weiwei@microsoft.com>
Co-authored-by: Shiying Chen <72982571+MoChilia@users.noreply.github.com>
Co-authored-by: Dingmeng Xue <dixue@microsoft.com>
Co-authored-by: JulianePadrao <93286303+JulianePadrao@users.noreply.github.com>
Co-authored-by: Victor Li <victorli@microsoft.com>
Co-authored-by: damodaravadhani <91929893+damodaravadhani@users.noreply.github.com>
Co-authored-by: kceiw <mahuang@microsoft.com>
Co-authored-by: lijinpei2008 <v-jinpel@microsoft.com>
Co-authored-by: navba-MSFT <57353862+navba-MSFT@users.noreply.github.com>
Co-authored-by: Michael Greene <mgreenegit@users.noreply.github.com>
Co-authored-by: Pramod Valavala <43602528+PramodValavala-MSFT@users.noreply.github.com>
Co-authored-by: ayeshurun <98805507+ayeshurun@users.noreply.github.com>
Co-authored-by: haagha <64601174+haagha@users.noreply.github.com>
Co-authored-by: Ilias <iliaskhan57@gmail.com>
Co-authored-by: Ilias Khan <iliaskhan@microsoft.com>
Co-authored-by: nbnakano <99308889+nbnakano@users.noreply.github.com>
Co-authored-by: thomasp98296 <thomaspham@outlook.com>
Co-authored-by: Thomas Pham <thompham@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MoChilia @isra-fel