Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EASI-4635] Discussions API tests #2908

Merged
merged 3 commits into from
Dec 6, 2024
Merged

[EASI-4635] Discussions API tests #2908

merged 3 commits into from
Dec 6, 2024

Conversation

mynar7
Copy link
Contributor

@mynar7 mynar7 commented Dec 3, 2024

EASI-4635

Description

  • Adds unit/integration resolver tests for the discussions API.

How to test this change

  • Run the test suite!

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@mynar7 mynar7 changed the base branch from main to feature/EASI-4614_grb_discussions December 3, 2024 21:54
@mynar7 mynar7 marked this pull request as ready for review December 4, 2024 17:05
@mynar7 mynar7 requested a review from a team as a code owner December 4, 2024 17:05
@mynar7 mynar7 requested review from samoddball and removed request for a team December 4, 2024 17:05
ClayBenson94
ClayBenson94 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@ClayBenson94 ClayBenson94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good! Thanks for tackling this!

@mynar7 mynar7 merged commit 6b1363c into feature/EASI-4614_grb_discussions Dec 6, 2024
12 checks passed
@mynar7 mynar7 deleted the EASI-4635/discussions-api-tests branch December 6, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClayBenson94 ClayBenson94 ClayBenson94 approved these changes

@samoddball samoddball Awaiting requested review from samoddball samoddball is a code owner automatically assigned from CMS-Enterprise/easi-backend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mynar7 @ClayBenson94