Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EASI-4645] send emails #2910

Merged
merged 50 commits into from
Dec 10, 2024

Conversation

samoddball
Copy link
Contributor

@samoddball samoddball commented Dec 4, 2024

EASI-4645

Description

  • connect resolvers to sending emails

How to test this change

  • create a system intake locally
  • add a user of your choice as a GRB reviewer
  • open postman (EASI/System Intake/GRB Meeting (Async)/Create GRB Discussion Group Tags)
  • enter the created system intake id as well as the user's uuid in the tag span
  • send the request
  • confirm an email goes out

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@samoddball samoddball marked this pull request as ready for review December 10, 2024 16:44
@samoddball samoddball requested a review from a team as a code owner December 10, 2024 16:44
@samoddball samoddball requested review from downeyn-cms and removed request for a team December 10, 2024 16:44
@ClayBenson94 ClayBenson94 requested a review from mynar7 December 10, 2024 17:45
Copy link

EKS Ingress URLs

@samoddball
Copy link
Contributor Author

EKS Ingress URLs

* [EASi](http://k8s-easi2910-easiingr-42e41921b4-614762738.us-west-2.elb.amazonaws.com)

* [Mailcatcher](http://k8s-easi2910-emailing-3a7f849503-696994186.us-west-2.elb.amazonaws.com)

* [Minio Console](http://k8s-easi2910-miniocon-eaae656b54-1477551703.us-west-2.elb.amazonaws.com)

@Jdwoodson this is SO COOL - thank you so much

Copy link
Contributor

@mynar7 mynar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with postman and everything seems to work!

Some good catches/corrections as well, nice work.

@samoddball samoddball merged commit 9a50dd9 into feature/EASI-4614_grb_discussions Dec 10, 2024
14 checks passed
@samoddball samoddball deleted the EASI-4645/send_emails branch December 10, 2024 21:18
@samoddball samoddball changed the title Easi 4645/send emails [EASI-4645] send emails Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants