-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update main with latest dev #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removed two functions that are not used * removed 2nd split plane function * removed split_p_planes_org * removed gen_torus_annex_u_planes_org * removed more unused code * returned docs to dev status * format
* more concise install with conda-forge * added conda badges * corrected badge url
* renamed functions with __ * removed random commit * Revert "removed random commit" This reverts commit f35b217.
* moving decompose solid into class * lower_case_enclosure_list_added_to_attributes
* moved two methods out of start * removed unnecessary logger line
* moved two methods out of start * removed unnecessary logger line * calculating bb if still None * improved comment * private method for now
* removed os.path and os.mkdir * format * defined folder * passing str to exportStep * format * corrected argmument name
Co-authored-by: AlvaroCubi <55387701+AlvaroCubi@users.noreply.github.com>
* moved two methods out of start * removed unnecessary logger line * added from json example
…194) * moved two methods out of start * removed unnecessary logger line * added UCARD null to missing parts * full step files list * added check for ucard above 1 * Apply suggestions from code review
* testing new theme for versioning * moved version to navbar start * keeping gh-pages files * docs * removed if push * publish dev sub dir * added dev version * pointing to dev repo * added more versions * removed comment * updated versions * using version match * added version to title * general tidy * added github link * corrected url * format * Typo fix
* moved two methods out of start * removed unnecessary logger line * added dev docs * removed random commit file
… loading geometry (#205) * moved two methods out of start * removed unnecessary logger line * changed cellRange to skip_solids * improved doc string * lowercase args pep8
* moved two methods out of start * removed unnecessary logger line * changes while working therough the install
* Patch for #203 * Responding to comments on #206 * Update core.py Add missing space to call to UF.get_box() * Replace all get_box calls to have options.enlargeBox, change get_box to refer only to enlargeBox instead of options.enlargeBox --------- Co-authored-by: AlvaroCubi <55387701+AlvaroCubi@users.noreply.github.com> Co-authored-by: Grammer, Kyle <grammerkb@ornl.gov>
* removed config ini code * format
* moved two methods out of start * removed unnecessary logger line * started CsgToCad class definition * added class * added cli for csgtocad method * restructure docs * adding csgtocad to docs * improved csg to cad examples * format * corrected json path * moved doc string to method * corrected file path * quotes used in dict * removed old code
* removed old scripts * retrigger ci
psauvan
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
3rd time is the charm, trying to update the main with the latest dev. last time the status checks were not registering for the actions so the merge was blocked
Fixes issue
Please link to any issues that this PR fixes
Checklist