Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merges branch 'master' into jib_skaffold. #1088

Merged

Conversation

coollog
Copy link
Contributor

@coollog coollog commented Oct 3, 2018

To help keep jib_skaffold branch up-to-date.

r2d4 and others added 30 commits September 26, 2018 11:08
…ainerTools#1061)

* Revert "Rename kustomize.KustomizePath to kustomize.Path"

This reverts commit ceeb247.

* Revert other issues

Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Print out help messages for configs too new or too old for the current
version of skaffold.
Signed-off-by: David Gageot <david@gageot.net>
Fixes GoogleContainerTools#1049

Signed-off-by: David Gageot <david@gageot.net>
Fixes GoogleContainerTools#1050

Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Fixes GoogleContainerTools#1052

Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Fixes GoogleContainerTools#247

Signed-off-by: David Gageot <david@gageot.net>
Fixes GoogleContainerTools#1032

Signed-off-by: David Gageot <david@gageot.net>
Rename some fields in artifact config and kustomize config.
Signed-off-by: David Gageot <david@gageot.net>
 This PR adds a test phase to the runner. If any tests are specified,
 they will always be executed after the build phase but before the deploy
 phase, and if any tests fail the deploy phase will be skipped. In the
 dev loop, only newly built images will be tested; any artifacts that
 were not modified by new changes will be skipped.

 A 'test' section is added to the config, where users can add all of
 their test configuration. Each test is specified at the artifact level,
 matched up by image names specified in the build artifacts.

 The test executor is designed to be pluggable, similar to the builders
 and deployers. The main exception is that any number of testers can be
 executed in a single run; a failure in any of them counts as a failure
 of the entire test run. This PR implements running structure tests,
 but adds the infrastructure to easily add more test types in the future.
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Oct 3, 2018

Codecov Report

Merging #1088 into jib_skaffold will increase coverage by 1.7%.
The diff coverage is 67.26%.

Impacted file tree graph

@@               Coverage Diff               @@
##           jib_skaffold    #1088     +/-   ##
===============================================
+ Coverage         41.55%   43.25%   +1.7%     
===============================================
  Files                77       78      +1     
  Lines              3148     3299    +151     
===============================================
+ Hits               1308     1427    +119     
- Misses             1715     1739     +24     
- Partials            125      133      +8
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/cmd.go 0% <ø> (ø) ⬆️
pkg/skaffold/deploy/kubectl/cli.go 0% <ø> (ø) ⬆️
pkg/skaffold/build/gcb/cloud_build.go 0% <0%> (ø) ⬆️
pkg/skaffold/build/local/jib.go 0% <0%> (ø) ⬆️
pkg/skaffold/build/gcb/types.go 0% <0%> (ø) ⬆️
pkg/skaffold/build/local/bazel.go 0% <0%> (ø) ⬆️
pkg/skaffold/deploy/kustomize.go 36.23% <0%> (ø) ⬆️
cmd/skaffold/app/cmd/runner.go 0% <0%> (ø) ⬆️
cmd/skaffold/app/cmd/fix.go 0% <0%> (ø) ⬆️
cmd/skaffold/app/cmd/init.go 0% <0%> (ø) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 412101b...4e5435f. Read the comment docs.

@balopat balopat merged commit 352217a into GoogleContainerTools:jib_skaffold Oct 3, 2018
@coollog coollog deleted the jib_skaffold_merge_master branch October 3, 2018 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants