October 19, 2022

Time/Place

This meeting is held virtually via Zoom, with an open channel for chatter on Slack. Anyone is welcome to join. The hosting can be claimed by anybody with the host ID. The Host ID is in the header of the TAG slack channel.

• Time: Wednesday, 1:00pm Eastern Time US (UTC-5)
• Zoom link: https://zoom.us/j/97345581392
• Passcode: 919241
• Join us on the Slack Islandora Channel https://islandora.slack.com/archives/CM5PPAV28

Chair Roster

These are the core members of TAG and will take on chair of the meeting if there are no volunteers, and will support volunteers who are chairing for the first time:

• Don
• Seth
• Rosie
• Willow 🪑

Attendees

• Willow Gillingham (Chair)
• Don Richards
• Jordan Dukart
• Alexander O'Neill
• Seth Shaw
• Yamil Suarez
• Rosie Le Faive
• Annie Oelschlager
• Adam Vessey
• Kevin Fletcher
• Isabella Nikolaidis (notes)

Agenda

Note that links are to the document repository only. New issues in other repositories or organizations will not appear in this list, and should be added by interested parties directly to the agenda.

1. PR Roundup- Link sorted by recently updated
2. Issue Roundup - Link sorted by recently updated
3. Review of mailing list
4. Feel free to add more, or add something from Islandora Discussions

Minutes

PR Roundup

https://github.com/Islandora/Crayfish-Commons/pull/57

• Willow: Looks like Crayfish was supposed to be returning a 400 but in this case wasn't doing that.
• Jordan: Ready for review.
• Adam: Tests fail but it's not actually running the tests.
• Adam: There's another PR getting things running the tests, so this can be updated after the other one is merged.
  • https://github.com/Islandora/Crayfish-Commons/pull/56 merged first.
• Alexander to test.

https://github.com/Islandora/Crayfish-Commons/pull/56

• Allow homarus to use fast start.
• Jordan: Seth had pointed out potential issues/oversight in additional ticket on the 2sx branch so there's some back and forth.
  • Making the directory to which homarus writes its files to configurable.

https://github.com/Islandora/islandora/pull/897

• Willow to test with more than one media use at the same time.

https://github.com/Islandora/documentation/pull/2184

• Don: We need up to update the version of Docker compose we say is needed.
• Merged!

https://github.com/Islandora-Devops/islandora-playbook/pull/234

• Seth: We had done all this work previously, and then it looks like someone had done a PR that accidentally brought some of this back
  • Verbiage in README will probably also need to be updated.
• Adam: Should be referencing Drupal 8.
• This is ready to merge, but if there are any other edits on documentation, make them.

https://github.com/Islandora/Crayfish/pull/170

• Discussion in thread - agreed to make it configurable.

https://github.com/Islandora/.github/pull/2

• Yamil: To add a new issue type addressing security reports.
• Don: We can merge, any additions can be a new PR.

https://github.com/Islandora/islandora-starter-site/pull/12

• Complaining about plugin stuff. Failing but if we run it it may work.
• Can somebody spin these up and get crayfish to rebuild?
• Seth: To test, you would spin up a site and then pull in the PR composer install. Prompting for plugin authorization, and then make sure your derivatives are still working.

Dependabot PRs

• Seth to follow up.

https://github.com/Islandora/islandora/pull/896

• Fix batch/upload children - introduces ctools dependency.
• Willow to follow up.
• Adam: Had mentioned ctools version 4 - widen the spec to allow it?

https://github.com/Islandora/documentation/pull/2105

• Isabella to follow up on Rosie's comment.

Issue Roundup

https://github.com/Islandora-Devops/isle-buildkit/issues/225

• Nigel and Gavin working on this.

https://github.com/Islandora-Devops/isle-buildkit/issues/220

• Also has to do with buildkit along with above.
• Conversation around removing Recast.

https://github.com/Islandora/islandora-starter-site/issues/13

• Seth: Islandora FITS module - if you install it and it doesn't find a FITS term, it will add it. And will then add the URI to it. At that point of installing from config, the taxonomy fields don't exist yet. So it saves a FITS term but it fails to save the URI.
  • You have to after the fact, after configs have been imported, re-add it.
  • The islandora FITS module assumes you've done the install of the configs of other frameworks. It assumes those configs are there, which wen you do the install site from config is not necessarily true.
  • Asking mark if we can get rid of that part of the install hook?
• Alexander: Maybe it could check before in its own code if it needs to do anything?
• Seth: It searches for a term with that URI which doesn't exist yet on install.
  • Check to see if the configs that set the field exist at all.
• Rosie: we're trying to refer to a content item in an islandora way - by URI on taxonomy term.
  • Islandora doesn't use install hooks to install content. When this module was developed we thought this may work
  • If a migration is better way to do it - when you do install FITS module, says to install me.
  • Potentially add a dependency on migrate.
• Seth: For ISLE would want to adjust the composer so it says all migrations and not just islandora ones.
  • Anything within islandora tagged migration.
  • Currently we just do individual migrations.
  • Anything tagged islandora - run those.
• Rosie: Current existing islandora model migration just uses PCDM stuff, should we add this or is it extraneous?
• Adam: It's a migration in the FITS module, it just has to be run.

https://github.com/roblib/islandora_fits/blob/f03b4eeff3598a9b81aad614f8aecd62cf14d81d/migrations/islandora_fits_tags.yml#L3-L4

• Willow: Switch order of operations before fits gets to do anything?
• Seth: This is how Drupal installs things.
  • We can close it now it's resolved, but the starter site needs to update this.
• Rosie: Nigel reported on starter site possibly because starter site has old commit reference (maybe in ISLE we didn't include the FITS migration?)
• Leave issue open while doing these checks.

https://github.com/Islandora/islandora/issues/903

• Adam: This doesn't need to be part of hocr testing,
  • Triggers bug if you upload a file (in my case a tiff file) as file media and then for media use if you check both service file and original file there was some context action that seemed to be activating itself.
  • Don't know if there's an offending context or what to prevent this error happening in the future - needs more investigation.
• Willow: When you're attaching an image or file it can't be a radio group, you could select all of them on the checklist.
• Seth: And we want to keep it multiple select.
• Alexander: With large images, the default is to generate a medium resolution jpg as a service file but the most straightforward conceptually is to click both service and original file.
  • Not a bug in contexts, but possibility that context lets happen reaction to something that modifies the media, that triggers the reaction again.
• Seth: We have the option of triggering an action to overwrite an existing original file.
  • If you put in original and service, you're updating and creating a looping problem.
• Rosie: When a derivative is about to fire should it check that the destination is not the same as the source?
• Seth: Agreed. AKA don't update this file as the original file would be in the derivative action code.
• Rosie: It would need to be evaluated at the time that it's being fired because in the action code you're saying, in your original file may be set to be your service file and have both tags.
• Seth: The action is emitting the event, you want to shortcircuit that event.
• Rosie: Media could be child media in some way of the thing they were generated from. Media would know whether it's a source or a target and what it's a source or target from.
  • This would require extra field on all media, lots of modelling.
• Willow: Could it be associated with referring action instead of a built in field?
• Seth: Think we need to start with the self-reference, get that fixed. Then decide if we have the use case if we want to push it further.

https://github.com/Islandora/documentation/issues/2185

• Seth: they want more instructions on optimizing use of Cantaloupe for large image viewing
• Alexander: Cachewarming - would need external script that crawls your site.
• Reflects need for more practical documentation about running islandora in production.
• Don: Zoom levels, translating to URL, guessing that this is specifically to pipe through a machine learniing model.
• Willow: Is this outside the scope of islandora? E.g., refer to Cantaloupe documentation?
• Don to gather context on this use and see if ready for discussion next week.

https://github.com/Islandora/documentation/issues/2117

• Seth: It's about the libraries we're using how they are packaged, and how we are pulling in different libraries.
• Rosie to test.

https://github.com/Islandora-Devops/isle-dc/issues/298

• Alexander: ISLE seems to hide JP2 files when it comes to creating derivative images, but the image that has the build of tesseract on it doesn't seem to have JP2 support.
• Seth: Tesseract would inherit the image that the other crayfish ones are using?
• Alexander: Ubuntu for the playbook - it would need a JP2 library to decode JP2 files in Ubuntu, that's the liv-jp2(?).

https://github.com/Islandora/documentation/issues/2182

• Seth: We might want to think about discarding the manual install instructions. I don't know that anyone is going through and actively doing manual installs on a regular basis that could keep it up to date.
  • But it's a useful document in that it outlines the pieces and how they're connected to each other.
  • The details about this is the library you want are problematic.
• Rosie: Scary to take this out - because then we won't have an understanding of the relationships between all our component bits.
  • If we have to, we should push to make it really clear in every module what it expects and provide documentation to go install it.
  • If a module requires a library, make sure that is clear in the README.
  • If it requires a microservice externally, or cantaloupe server, need to link to examples.
  • ex. Our code talks about IIIF server, we talk about it as cantaloupe - this can be confusing to others.