October 5, 2022

Time/Place

This meeting is held virtually via Zoom, with an open channel for chatter on Slack. Anyone is welcome to join. The hosting can be claimed by anybody with the host ID. The Host ID is in the header of the TAG slack channel.

Time: Wednesday, 1:00pm Eastern Time US (UTC-5)
Zoom link: https://zoom.us/j/97345581392
Passcode: 919241
Join us on the Slack Islandora Channel https://islandora.slack.com/archives/CM5PPAV28

Chair Roster

These are the core members of TAG and will take on chair of the meeting if there are no volunteers, and will support volunteers who are chairing for the first time:

Don
Seth 🪑
Rosie
Willow

Attendees

Seth Shaw (Chair)
Alexander O'Neill
Willow Gillingham
Don Richards
Annie Oelschlager
Adam Vessey
Jordan Dukart
Rebel Cummings-Sauls
Isabella Nikolaidis (notes)

Agenda

Note that links are to the document repository only. New issues in other repositories or organizations will not appear in this list, and should be added by interested parties directly to the agenda.

Issue Roundup - Link sorted by recently updated
PR Roundup- Link sorted by recently updated
Review of mailing list
Feel free to add more, or add something from Islandora Discussions

Minutes

Willow: We want to incorporate the Born Digital oral histories solution into the standard release for ISLE.
- Seth: Islandora Defaults is under code freeze right now. This is what ISLE-DC uses.

Pull Request Roundup

https://github.com/Islandora/Crayfish/pull/162

Approved among discoverygarden folks.
Jordan: We need another external review but this is ready to be tested.

https://github.com/Islandora-Devops/isle-dc/pull/287

Adam: Ready to be tested.
- Getting the new starter site invoked from isle.

https://github.com/Islandora-Devops/isle-dc/pull/295

Edge case oultined in this PR.
To test: Spin it up, make demo 2 or more times, apply patch and then run it again.
Alexander to test.

https://github.com/Islandora/islandora/pull/896

Adam: Turned out in ctools they had changed the signature of a class.
- Applied that change and made the update hook install ctools.
Seth: Do we have any problems with including ctools as a dependency?
- Willow: We had issues with ctools 4.0.0.
- Adam: 3.7 and 3.8 is where the change in signature took place.
Adam: Could be an issue if you are using ctools anywhere, because that would be incompatible with this pull presently.
Seth: Question out to islandora slack or TAG? Hesitant to add a dependecy without checking, esp if incompatible.
Adam: Out of previous discussions, adding the dependency seemed to get the go ahead - ctools is a staging ground for new drupal features conceptually.
Jordan: Think this was discussed in a previously tech call.
Seth: Willow - could you check with Born Digital folks to see if there's a particular version of ctools that can or can't be used?
Adam: The update hook is in the composer.json that would prevent you from updating.
Seth: If you have a composer where ctools 4 is already locked in, instead of 3 and 4, it would not go.
Willow: Might be able to set ours to 3 and 4, and will bring it up at Born Digital call.
Seth: Could you check if this would work with your composer either 3 or 4?
Adam: Is there a stable release of 4 yet?
Alexander: Yes, 4.0.1.
Adam: https://www.drupal.org/project/ctools says dependent modules should rely on the 3.x module.
Alexander: Could check if directly incompatible or not so it can be left open.
Seth: Don't push the requirement up to 4, make it 3 and 4. And check if there are limitations to doing that.

https://github.com/Islandora/.github/pull/2

Could point towards https://github.com/Islandora/islandora-community/wiki/security

https://github.com/Islandora/islandora_solution_pack_newspaper/pull/171

Willow to review.

https://github.com/Islandora/documentation/pull/2177

Isabella to review the wording changes.

https://github.com/Islandora/islandora/pull/897

Willow and Alex to follow up.

https://github.com/Islandora-Devops/isle-buildkit/pull/241

Willow: Any comments or feedback from others?
Seth may be able to test later this week.
- Waiting for Gavin's response to Nigel's changes.

Issue Roundup

https://github.com/Islandora-Devops/isle-buildkit/issues/246

Log cleanup.
Seth: Probably something to do with how the setup scripts are set up for it.
Nigel has self-assigned.

https://github.com/Islandora/islandora_mirador/issues/6

Alex: Create contributor file to make configurable.

https://github.com/Islandora/islandora_ci/issues/17

From Rosie - testing scripts should be updated to match Drupal best practices.

Other

Alexander: In the codebase there's a block that seems to be used in the context reactions to show the viewer and also a field formatter. Does anyone know if the field formatter is used?
- Jordan: I think the formatter is used for individual objects and the block is supposed to be used for paged content.
Seth: Working on migrating our stuff to isle, but we've already pushed to php 8 so I've been working off a branch for isle dc on the buildkit which is php based.
- Bringing in line multisite, riprap, ...
Seth: There's a roblib repo that was specifically for PHP 8 for one of the repositories - CrayFits.
- Would be nice to get this pr tested for PHP 8.
- https://github.com/roblib/CrayFits/pull/10
  - holdup to get buildkit up to 10
Alexander: Would like to get rid of crayfits entirely. Alan may be able to speak to it also.
Rebel: Problem with migrate_7x_claw - media will not run successfully, file and object will run successfully but not media so everything is coming in split with out the type associated.
- Alexander: Are there any error messages you can point to?
- Rebel: Not error messages. It's running the media thing but it's not processing, so numbers come up 0.
- Rebel: If I run a file or object by itself it runs with the correct amount coming through.
- Alex: Log plugin you can put anywhere in the migrate yaml files. and you can just insert those in places to inspect where it fails.