[RNMobile] Fix for history stack that's is not empty on a fresh start of the editor #15055
Conversation
…rnmobile/887-History-stack-is-not-empty-on-a-fresh-start-of-the-editor * 'master' of https://github.com/WordPress/gutenberg: Reset embed mocks on every request, stop request to instagram (#15046) Refactor core blocks to have save and transforms in their own files (part 2) (#14899) Fix pullquote import (#15036) Refactor core blocks to have save and transforms in their own files (part 4) (#14903) Refactor core blocks to have save and transforms in their own files (part 3) (#14902) Refactor core blocks to have deprecated extracted to their ownf files (p.1) (#14979) Test transform from media to embed blocks (#13997) If a more recent revision/autosave exists, store its state on editor setup (#7945) chore(release): publish
|
I tested this, and it does fix the issue, as described. See this comment on the related gutenberg-mobile PR for additional details: wordpress-mobile/gutenberg-mobile#892 (comment). |
|
👋 @daniloercoli and @mkevins , can you also check that the test cases in wordpress-mobile/gutenberg-mobile#885 are still performing OK? This change here could be relating to how the text/state is updated when Aztec trims the text so, let's make sure no regression happens there. |
|
I have tested the cases described here: wordpress-mobile/gutenberg-mobile#885 (comment), and have found that cases A and B are still working as expected. For case C, I found some inconsistent results when testing the original issue, which I've described here: wordpress-mobile/gutenberg-mobile#885 (comment). Testing the same case here, I observed that when the period was created after two spaces, the caret position was before the period, and the third space was inserted there. Here is a screenshot of the behavior:
|
|
I'm going to merge this PR since case C. does already have inconsistent results with AOSP Keyboard in the original PR, and this PR doesn't change the way set the caret. @mkevins Would you mind to open an issue for your findings reported in the comment in the original PR? |
There was a problem hiding this comment.
This change fixes the undo issue for the case described. The issue described above (caret position before the period) can be addressed in a separate PR.
Edit:
I have found that the above described issue where the caret precedes the auto-punctuate period also occurs on paragraph and heading blocks after these changes.
…rnmobile/887-History-stack-is-not-empty-on-a-fresh-start-of-the-editor * 'master' of https://github.com/WordPress/gutenberg: Avoid running hasMetaBoxes on each subscribe (#15041) Avoid passing down isFirst and isLast props (#15043) Add "Roadmap" document with an overview of projects in consideration. (#14907) Testing: Update tests to use Escape press to activate block toolbar (#15063) Testing: Skip unreliable end-to-end tests (#15059)
|
I've updated this PR, and it should work as expected on lists, and para blocks, when double tapping the space bar on software keyboard. Ready for another round @mkevins |
There was a problem hiding this comment.
The additional commit fixes the issue with the caret preceding the auto-punctuate period. Also, I tested the original issue that this fixes, and that is working well. 🎉 The undo button becoming "enabled" in the italicized block still happens, but as discussed, can be addressed in a separate PR. The undo of a new block once in that "state" is much smoother after this fix.
…rnmobile/887-History-stack-is-not-empty-on-a-fresh-start-of-the-editor * 'master' of https://github.com/WordPress/gutenberg: 'string' misspelled as 'srting' (#15118) [Mobile] Improving accessibility on Post title (#15106) Fix 13776: Format is already registered to handle class name (#15072) Add wpDataSelect WordPress end 2 end test util (#15052) Block Editor: move selection state from RichText to the store (#14640) chore: Fix: Lint error that makes unit tests (and CI tests) fail. (#15073) Set ownProps.onFocus when context.onFocus is undefined. (#15069)
… of the editor (#15055) * Do not reset the content in onSelectionChange * Make sure there are changes made to the content before upgrading it upward * Refactor: Introduce a local variable and DRY the code a bit * Fix lint
youknowriad
deleted the
rnmobile/887-History-stack-is-not-empty-on-a-fresh-start-of-the-editor
branch
This PR does fix a problem where opening a post in GB mobile (without modify it) does result on having the
Undobutton already available/enabled in the toolbar.It also fixes the other problem where removing a new block with Undo/Redo was not possible without fast clicking on the the Undo button.
In this PR i've just removed the call that refreshes the content into the store in
onSelectChange. Not quite sure why we're sending back the content if it was not modified. In factthis.lastContentwas set with the actual content to avoid a refresh of the component.Testing steps in the GB Mobile PR here: wordpress-mobile/gutenberg-mobile#892