Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ops — Create Pull Request template #113

Closed
jshom opened this issue Apr 21, 2020 · 0 comments · Fixed by #114, #569, #607, #619 or #625
Closed

Ops — Create Pull Request template #113

jshom opened this issue Apr 21, 2020 · 0 comments · Fixed by #114, #569, #607, #619 or #625
Assignees
@jshom
Labels
Feature Request New Feature Request

Comments

@jshom
Copy link
Contributor

jshom commented Apr 21, 2020

Job
When we are merging pull requests we want to notify all important changes so that the team can work faster to merge new features.

Describe a possible solution
Create a pull request template

Context
A few issues that affected the front end did not have a clear test plan, in affect, we though it is a great idea to create a template that prompts people to provide such test plan.
@jshom jshom added the Feature Request New Feature Request label Apr 21, 2020
@jshom jshom self-assigned this Apr 21, 2020
jshom added a commit that referenced this issue Apr 21, 2020
@jshom
created pull request template to close #113
fa4386c 
**Related Issue**

closes #113

**Database Changes/Migrations**

N/A

**Added/Altered API Routes***

N/A

**Test Modifications**
N/A

**Test Procedure**

1. Create a branch
2. Commit a change to that branch
3. Push branch
4. Create Pull Request and fill in PR template
@jshom jshom mentioned this issue Apr 21, 2020
Merged
jshom added a commit that referenced this issue Apr 21, 2020
@jshom
Pull Request Template (#114)
f44d422 
* created pull request template to close #113

**Related Issue**

closes #113

**Database Changes/Migrations**

N/A

**Added/Altered API Routes***

N/A

**Test Modifications**
N/A

**Test Procedure**

1. Create a branch
2. Commit a change to that branch
3. Push branch
4. Create Pull Request and fill in PR template

* Standardized Formatting (#115)

* Update pull_request_template.md

* Update pull_request_template.md
@DarknessUnder DarknessUnder mentioned this issue Jun 20, 2020
Closed
@123joshuawu 123joshuawu mentioned this issue Sep 15, 2020
Closed
@mrpeterli mrpeterli mentioned this issue Oct 10, 2020
Merged
@123joshuawu 123joshuawu mentioned this issue Oct 27, 2020
Merged
@shrutig27 shrutig27 mentioned this issue Nov 9, 2020
Open
@gizzon gizzon mentioned this issue Feb 22, 2021
Merged
@gizzon gizzon mentioned this issue Mar 8, 2021
Merged
@EthanTuttle EthanTuttle mentioned this issue Nov 16, 2021
Closed
@jaw12346 jaw12346 mentioned this issue Feb 15, 2022
Closed
@hhdtc hhdtc mentioned this issue Feb 18, 2022
Merged
@YTWTY YTWTY mentioned this issue Mar 6, 2022
Merged
@hhukkj hhukkj mentioned this issue Mar 8, 2022
Closed
@lhain08 lhain08 mentioned this issue Mar 15, 2022
Merged
@PhoenixTamaoki PhoenixTamaoki mentioned this issue Mar 18, 2022
Merged
@PhoenixTamaoki PhoenixTamaoki mentioned this issue Apr 8, 2022
Merged
@lhain08 lhain08 mentioned this issue Apr 11, 2022
Merged
This was referenced Oct 8, 2022
Closed
Closed
This was referenced Nov 1, 2022
Merged
Merged
@jonathanadotey77 jonathanadotey77 mentioned this issue Nov 8, 2022
Open
@jemanp jemanp mentioned this issue Nov 22, 2022
Open
@charleschae12 charleschae12 mentioned this issue Nov 26, 2022
Merged
@DarknessUnder DarknessUnder mentioned this issue Jan 30, 2023
Merged
@YCK03 YCK03 mentioned this issue Feb 17, 2023
Open
@charleschae12 charleschae12 mentioned this issue Feb 18, 2023
Merged
@NickWang8 NickWang8 mentioned this issue Mar 3, 2023
Closed
@skyjune0824 skyjune0824 mentioned this issue Apr 7, 2023
Merged
@Yixuan-Shen Yixuan-Shen mentioned this issue Apr 7, 2023
Open
@charleschae12 charleschae12 mentioned this issue Apr 9, 2023
Open
@Kagiri2 Kagiri2 mentioned this issue Apr 11, 2023
Closed
@doinglin doinglin mentioned this issue Jun 30, 2023
Open
@jonha1 jonha1 mentioned this issue Jul 14, 2023
Merged
@c-jimmy1 c-jimmy1 mentioned this issue Sep 26, 2023
Open
@Kagiri2 Kagiri2 mentioned this issue Oct 20, 2023
Open
@bnavac bnavac mentioned this issue Nov 28, 2023
Merged
@sillyguy29 sillyguy29 mentioned this issue Feb 6, 2024
Open
@maggietrebilcock maggietrebilcock mentioned this issue Nov 5, 2024
Merged
@Tevetron Tevetron mentioned this issue Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshom jshom

Labels
Feature Request New Feature Request
Projects
None yet
Milestone
No milestone
1 participant
@jshom