Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize Ruby and Rust packages #1056

Merged
merged 11 commits into from
Feb 28, 2024
Merged

Reorganize Ruby and Rust packages #1056

merged 11 commits into from
Feb 28, 2024

Conversation

imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Feb 27, 2024

Since we started to build Agama, we have introduced a lot of changes. Initially, it was just Ruby code, but then we introduced the Agama CLI, moved some code to Rust, etc. So, it is time to reorganize our packages.

This PR includes the following changes:

  • A new agama package that contains agama-dbus-server and agama-web-server binaries. You don't need to keep them separated.
  • A new agama-cli package, which is a subpackage of agama.
  • Renamed the rubygem-agama package to rubygem-agama-yast package as, in the short term, it should only contain YaST-specific bits to Agama.
  • Additionally, it re-enable some tests and fixes some warnings.

You can (temporarily) see the results in my home project.

Todo

  • Rename rubygem-agama to rubygem-agama-yast
  • Reorganize Rust-based packages
  • Update the documentation
  • Update the changes files

Links

@coveralls
Copy link

coveralls commented Feb 27, 2024

Coverage Status

coverage: 74.682%. remained the same
when pulling 3bbfbb2 on packaging
into c26d4d3 on master.

@imobachgs imobachgs changed the title Packaging Reorganize Ruby and Rust packages Feb 27, 2024
@imobachgs imobachgs marked this pull request as ready for review February 27, 2024 15:59
services](https://openbuildservice.org/help/manuals/obs-user-guide/cha.obs.source_service.html).
The process to build each package is slightly different depending on the
technology we are using. While the Ruby-based one (`rubygem-agama-yast`) is
built as any other YaST package, Agama server (`agama`), the CLI (`agama-cli`),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, it is kind of misleading as we do not build other YaST packages as rubygems...so I would say as we package it similar to other YaST packages and builds it as common rubygem.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but on other hand we do not publish that rubygem..so I am not sure what can cause more confusion

PACKAGING.md Outdated Show resolved Hide resolved
Co-authored-by: Josef Reidinger <jreidinger@suse.cz>
@imobachgs imobachgs merged commit 0951b8c into master Feb 28, 2024
3 checks passed
@imobachgs imobachgs deleted the packaging branch February 28, 2024 17:46
imobachgs added a commit that referenced this pull request Feb 29, 2024
After merging #1056 we detected that a runtime dependency on
`python-langtable-data` is needed. This PR fixes the problem.
joseivanlopez added a commit to joseivanlopez/agama that referenced this pull request Mar 4, 2024
- agama.gemspec was renamed, see
  agama-project#1056.
- The file name was not updated in the rubocop config.
joseivanlopez added a commit to joseivanlopez/agama that referenced this pull request Mar 5, 2024
- agama.gemspec was renamed, see
  agama-project#1056.
- The file name was not updated in the rubocop config.
joseivanlopez added a commit to joseivanlopez/agama that referenced this pull request Mar 6, 2024
- agama.gemspec was renamed, see
  agama-project#1056.
- The file name was not updated in the rubocop config.
joseivanlopez added a commit to joseivanlopez/agama that referenced this pull request Mar 6, 2024
- agama.gemspec was renamed, see
  agama-project#1056.
- The file name was not updated in the rubocop config.
ancorgs pushed a commit to ancorgs/agama that referenced this pull request Mar 8, 2024
- agama.gemspec was renamed, see
  agama-project#1056.
- The file name was not updated in the rubocop config.
ancorgs pushed a commit to ancorgs/agama that referenced this pull request Mar 8, 2024
- agama.gemspec was renamed, see
  agama-project#1056.
- The file name was not updated in the rubocop config.
@imobachgs imobachgs mentioned this pull request May 17, 2024
imobachgs added a commit that referenced this pull request May 17, 2024
Prepare for releasing Agama 8. It includes the following pull requests:

* #884
* #886
* #914
* #918
* #956
* #957
* #958
* #959
* #960
* #961
* #962
* #963
* #964
* #965
* #966
* #969
* #970
* #976
* #977
* #978
* #979
* #980
* #981
* #983
* #984
* #985
* #986
* #988
* #991
* #992
* #995
* #996
* #997
* #999
* #1003
* #1004
* #1006
* #1007
* #1008
* #1009
* #1010
* #1011
* #1012
* #1014
* #1015
* #1016
* #1017
* #1020
* #1022
* #1023
* #1024
* #1025
* #1027
* #1028
* #1029
* #1030
* #1031
* #1032
* #1033
* #1034
* #1035
* #1036
* #1038
* #1039
* #1041
* #1042
* #1043
* #1045
* #1046
* #1047
* #1048
* #1052
* #1054
* #1056
* #1057
* #1060
* #1061
* #1062
* #1063
* #1064
* #1066
* #1067
* #1068
* #1069
* #1071
* #1072
* #1073
* #1074
* #1075
* #1079
* #1080
* #1081
* #1082
* #1085
* #1086
* #1087
* #1088
* #1089
* #1090
* #1091
* #1092
* #1093
* #1094
* #1095
* #1096
* #1097
* #1098
* #1099
* #1100
* #1102
* #1103
* #1104
* #1105
* #1106
* #1109
* #1110
* #1111
* #1112
* #1114
* #1116
* #1117
* #1118
* #1119
* #1120
* #1121
* #1122
* #1123
* #1125
* #1126
* #1127
* #1128
* #1129
* #1130
* #1131
* #1132
* #1133
* #1134
* #1135
* #1136
* #1138
* #1139
* #1140
* #1141
* #1142
* #1143
* #1144
* #1145
* #1146
* #1147
* #1148
* #1149
* #1151
* #1152
* #1153
* #1154
* #1155
* #1156
* #1157
* #1158
* #1160
* #1161
* #1162
* #1163
* #1164
* #1165
* #1166
* #1167
* #1168
* #1169
* #1170
* #1171
* #1172
* #1173
* #1174
* #1175
* #1177
* #1178
* #1180
* #1181
* #1182
* #1183
* #1184
* #1185
* #1187
* #1188
* #1189
* #1190
* #1191
* #1192
* #1193
* #1194
* #1195
* #1196
* #1198
* #1199
* #1200
* #1201
* #1203
* #1204
* #1205
* #1206
* #1207
* #1208
* #1209
* #1210
* #1211
* #1212
* #1213
* #1214
* #1215
* #1216
* #1217
* #1219
* #1220
* #1221
* #1222
* #1223
* #1224
* #1225
* #1226
* #1227
* #1229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants