Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Live ISO sources to Git #1160

Merged
merged 7 commits into from
Apr 23, 2024
Merged

Add Live ISO sources to Git #1160

merged 7 commits into from
Apr 23, 2024

Conversation

lslezak
Copy link
Contributor

@lslezak lslezak commented Apr 22, 2024

Problem

The Live ISO sources are not maintained at GitHub, that makes the development complicated:

  • Cannot track the changes easily, working with history in OBS is limited and more complicated than with Git
  • Changing files in tarballs is difficult, you have to unpack it, modify a file and then manually compress back with correct parameters
  • Building the Live ISO locally is not trivial

Solution

  • Move the sources into the /live subdirectory
  • Add GitHub action for automatic submission from master to the systemsmanagement:Agama:Staging OBS project
  • Allow running the ISO build locally via make build

Changes

The individual files were not touched, I just copied them from the current OBS project. I only moved the fw_cleanup.rb script to the /tmp directory as the script is temporary and it is deleted at the end of the ISO build.

  • All Kiwi tarballs were unpacked to Git
  • Simple make builds the sources to the dist subdirectory and builds the tarballs
  • The ISO can be built locally using make build
  • Updated/extended the documentation in README.md (There are two README.md files, the main in /live which documents the details and the /live/src/README.md which is copied to OBS. Mostl importantly it says "do not touch this in OBS, use GitHub".)

Testing

Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great. Thanks!

It would be even better if we update (or remove) the following references:

to the OBS project
- [root](root) subdirectory contains files which are added to the Live ISO root
system (inside the squashfs image)
- [root-ALP-PXE](root-ALP-PXE) subdirectory contains specific files for the ALP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we will need to drop this ALP reference at some point. But it is out of scope of this PR.

live/README.md Outdated Show resolved Hide resolved
@@ -0,0 +1 @@
add_drivers+=" brd "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment, ALP is dead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @imobachgs mentioned above, let's solve that separately later.

Extract the Linux kernel and the initrd from the archive:

```shell
osc getbinaries images x86_64 -M ALP-PXE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ALP -> FO? Or call it ... call it something else?

@lslezak
Copy link
Contributor Author

lslezak commented Apr 22, 2024

  • Updated documentation. IMHO https://github.com/openSUSE/agama/blob/master/doc/live_iso.md still makes sense, I just added a link to the sources in Git.
  • Updated the Makefile to use UTC for the time stamps in the tarballs, that should be more consistent and reproducible (the local time zone should not matter now).
  • Removed IMAGE.md, that's actually now included in the live/README.md file.

Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some Kiwi capitalization... otherwise, LGTM! (feel free to merge).

live/README.md Outdated Show resolved Hide resolved
live/README.md Outdated Show resolved Hide resolved
live/README.md Outdated Show resolved Hide resolved
live/README.md Outdated Show resolved Hide resolved
live/README.md Outdated Show resolved Hide resolved
lslezak and others added 5 commits April 23, 2024 09:58
Co-authored-by: Imobach González Sosa <igonzalezsosa@suse.com>
Co-authored-by: Imobach González Sosa <igonzalezsosa@suse.com>
Co-authored-by: Imobach González Sosa <igonzalezsosa@suse.com>
Co-authored-by: Imobach González Sosa <igonzalezsosa@suse.com>
Co-authored-by: Imobach González Sosa <igonzalezsosa@suse.com>
@lslezak lslezak merged commit d4f44b8 into agama-project:master Apr 23, 2024
@imobachgs imobachgs mentioned this pull request May 17, 2024
imobachgs added a commit that referenced this pull request May 17, 2024
Prepare for releasing Agama 8. It includes the following pull requests:

* #884
* #886
* #914
* #918
* #956
* #957
* #958
* #959
* #960
* #961
* #962
* #963
* #964
* #965
* #966
* #969
* #970
* #976
* #977
* #978
* #979
* #980
* #981
* #983
* #984
* #985
* #986
* #988
* #991
* #992
* #995
* #996
* #997
* #999
* #1003
* #1004
* #1006
* #1007
* #1008
* #1009
* #1010
* #1011
* #1012
* #1014
* #1015
* #1016
* #1017
* #1020
* #1022
* #1023
* #1024
* #1025
* #1027
* #1028
* #1029
* #1030
* #1031
* #1032
* #1033
* #1034
* #1035
* #1036
* #1038
* #1039
* #1041
* #1042
* #1043
* #1045
* #1046
* #1047
* #1048
* #1052
* #1054
* #1056
* #1057
* #1060
* #1061
* #1062
* #1063
* #1064
* #1066
* #1067
* #1068
* #1069
* #1071
* #1072
* #1073
* #1074
* #1075
* #1079
* #1080
* #1081
* #1082
* #1085
* #1086
* #1087
* #1088
* #1089
* #1090
* #1091
* #1092
* #1093
* #1094
* #1095
* #1096
* #1097
* #1098
* #1099
* #1100
* #1102
* #1103
* #1104
* #1105
* #1106
* #1109
* #1110
* #1111
* #1112
* #1114
* #1116
* #1117
* #1118
* #1119
* #1120
* #1121
* #1122
* #1123
* #1125
* #1126
* #1127
* #1128
* #1129
* #1130
* #1131
* #1132
* #1133
* #1134
* #1135
* #1136
* #1138
* #1139
* #1140
* #1141
* #1142
* #1143
* #1144
* #1145
* #1146
* #1147
* #1148
* #1149
* #1151
* #1152
* #1153
* #1154
* #1155
* #1156
* #1157
* #1158
* #1160
* #1161
* #1162
* #1163
* #1164
* #1165
* #1166
* #1167
* #1168
* #1169
* #1170
* #1171
* #1172
* #1173
* #1174
* #1175
* #1177
* #1178
* #1180
* #1181
* #1182
* #1183
* #1184
* #1185
* #1187
* #1188
* #1189
* #1190
* #1191
* #1192
* #1193
* #1194
* #1195
* #1196
* #1198
* #1199
* #1200
* #1201
* #1203
* #1204
* #1205
* #1206
* #1207
* #1208
* #1209
* #1210
* #1211
* #1212
* #1213
* #1214
* #1215
* #1216
* #1217
* #1219
* #1220
* #1221
* #1222
* #1223
* #1224
* #1225
* #1226
* #1227
* #1229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants