Adapt agama-live to work with the new architecture #1119

imobachgs · 2024-03-26T12:18:21Z

Changes summary

Adds a --generate-token option to agama-web-server. Using such a token you can skip the authentication (given that you have access to the token).
Adds a new Firefox start-up script that injects the token, skipping the authentication when running locally.
Defines an agama-web-server systemd service.
Temporarily disables the no-unused-vars linter.
Fixes agama-web-ui.spec.
Adjusts the KIWI definition.

To do

Replace the sqlite3 hack with support in the backend.
Use standard HTTP and HTTPS ports.
Add uncompressed version of the files to the package.

agama-live sources in the repo

In the future, we plan to move the source we use to build agama-live to this repository.

coveralls · 2024-03-26T12:26:27Z

coverage: 71.896% (-0.09%) from 71.981%
when pulling 86afb33 on agama-live-update
into 11cda28 on architecture_2024.

lslezak · 2024-04-02T12:05:36Z

live/startup

+VALUE=$(cat $TOKEN_FILE)
+EXPIRATION=$(date --date '1 day' +%s)
+
+sqlite3 $COOKIES_DB "INSERT INTO moz_cookies \


I do not like hacking the internal Firefox cookies database directly. That's very fragile and works only with Firefox.

What about creating a /run/agama/token.html file with root-only permissions with content like

<!DOCTYPE html> <html> <body> <script> document.location = "http://localhost/login?token=" + <JS-escaped-token-value>; </script> </body> </html>

and implement /login endpoint which would set the agamaToken cookie and redirect to /.

And then use that file in the firefox command below like

firefox --kiosk --profile $HOME/.mozilla/firefox/profile /run/agama/token.html

That special file would avoid exposing the token in the process list (in contrast when using the token directly in the firefox command).

The advantage would not hacking the SQLite internals and would be generic for all browsers.

Note: Originally I wanted to put something like

document.cookie = "agamaToken=" + tokenValue + ";domain=localhost;path=/api";

into that HTML file. But for security reasons it is not possible to set cookie for a different domain and it is not possible to set an httpOnly cookie...

Of course, I am open to other approaches and I see your point. However bear in mind that we only need to support Firefox and, if something changes, we can detect soon enough in our CI.

To be honest, I would rather prefer some kind of API to import the cookie and do not have to extend the backend (and add a redirection). But I am not against this solution.

Thinking about your proposal we can get rid of the token.html file. The startup script would be the responsible for reading and injecting the token in the URL.

In the server side, the following code seems to work:

pub async fn get_cookie( State(state): State<ServiceState>, Query(params): Query<GetCookieParams>, ) -> impl IntoResponse { let decoding = DecodingKey::from_secret(state.config.jwt_secret.as_ref()); let mut headers = HeaderMap::new(); if jsonwebtoken::decode::<TokenClaims>(&params.token, &decoding, &Validation::default()).is_ok() { let cookie = format!("agamaToken={}; HttpOnly", params.token); headers.insert( SET_COOKIE, cookie.parse().expect("could not build a valid cookie"), ); } headers.insert(LOCATION, "/".parse().unwrap()); (StatusCode::PERMANENT_REDIRECT, headers) }

If it is OK for you, I will clean-up the code a bit (removing some duplication) and update the PR.

rust/agama-server/src/web/service.rs

imobachgs · 2024-04-03T11:28:08Z

I have update the PR to follow @lslezak's approach (thanks!) removing the ugly sqlite3 hack. About automating this process, we already have a card for it: https://trello.com/c/1G6TeRzy/337-agama-put-agama-live-sources-in-a-github-repository. Perhaps it is something to plan for in the following sprint.

lslezak

Just some minor questions and suggestions...

rust/agama-server/src/web/http.rs

lslezak · 2024-04-03T12:12:06Z

live/startup

+TOKEN_FILE=/run/agama/token
+TOKEN=$(cat $TOKEN_FILE)
+
+firefox --kiosk --profile $HOME/.mozilla/firefox/profile "http://localhost/login?token=$TOKEN"


The code is simpler without using a helper token.html file. On the other hand the token is then visible in the ps output. I'm not sure how serious is this problem... 🤔

Well, you might need to access to the system (as root, as it is the only user in the ISO) and, at that point, you can read the token from the file anyway. Alternatively, we could set the URL as the homepage for the browser (we are doing other tweaks anyway), so we do not need to specify any URL.

Yes, once you are root you can do everything...

The problem is that for running simple ps you do not need to be root. If e.g. the avahi daemon running as avahi user is vulnerable and allows arbitrary code execution then you could still get the root token if you force it to run ps and get the output although it's not running as root.

BTW setting the home page looks like a good trick...

OK, let's give the homepage setting a try.

lslezak

LGTM

Thanks, that looks much better than the SQLite hack! 👍

imobachgs · 2024-04-04T12:38:25Z

Yes, you are right. Now the next step is to submit all this stuff automatically. But that's another story. 😄

After a few months of work, it is time to merge the `architecture_2024` branch into `master`. It is still a work-in-progress, but all the efforts should be go now against that branch. ## Pull requests * #1061 * #1064 * #1073 * #1074 * #1080 * #1089 * #1091 * #1092 * #1094 * #1095 * #1099 * #1100 * #1102 * #1103 * #1112 * #1114 * #1116 * #1117 * #1119 * #1120 * #1123 * #1126 * #1129 * #1130 * #1131 * #1132 * #1133 * #1134 * #1136 * #1139 * #1140 * #1143 * #1146 ## Other commits * 8efa41f * 9e2dec0

Prepare for releasing Agama 8. It includes the following pull requests: * #884 * #886 * #914 * #918 * #956 * #957 * #958 * #959 * #960 * #961 * #962 * #963 * #964 * #965 * #966 * #969 * #970 * #976 * #977 * #978 * #979 * #980 * #981 * #983 * #984 * #985 * #986 * #988 * #991 * #992 * #995 * #996 * #997 * #999 * #1003 * #1004 * #1006 * #1007 * #1008 * #1009 * #1010 * #1011 * #1012 * #1014 * #1015 * #1016 * #1017 * #1020 * #1022 * #1023 * #1024 * #1025 * #1027 * #1028 * #1029 * #1030 * #1031 * #1032 * #1033 * #1034 * #1035 * #1036 * #1038 * #1039 * #1041 * #1042 * #1043 * #1045 * #1046 * #1047 * #1048 * #1052 * #1054 * #1056 * #1057 * #1060 * #1061 * #1062 * #1063 * #1064 * #1066 * #1067 * #1068 * #1069 * #1071 * #1072 * #1073 * #1074 * #1075 * #1079 * #1080 * #1081 * #1082 * #1085 * #1086 * #1087 * #1088 * #1089 * #1090 * #1091 * #1092 * #1093 * #1094 * #1095 * #1096 * #1097 * #1098 * #1099 * #1100 * #1102 * #1103 * #1104 * #1105 * #1106 * #1109 * #1110 * #1111 * #1112 * #1114 * #1116 * #1117 * #1118 * #1119 * #1120 * #1121 * #1122 * #1123 * #1125 * #1126 * #1127 * #1128 * #1129 * #1130 * #1131 * #1132 * #1133 * #1134 * #1135 * #1136 * #1138 * #1139 * #1140 * #1141 * #1142 * #1143 * #1144 * #1145 * #1146 * #1147 * #1148 * #1149 * #1151 * #1152 * #1153 * #1154 * #1155 * #1156 * #1157 * #1158 * #1160 * #1161 * #1162 * #1163 * #1164 * #1165 * #1166 * #1167 * #1168 * #1169 * #1170 * #1171 * #1172 * #1173 * #1174 * #1175 * #1177 * #1178 * #1180 * #1181 * #1182 * #1183 * #1184 * #1185 * #1187 * #1188 * #1189 * #1190 * #1191 * #1192 * #1193 * #1194 * #1195 * #1196 * #1198 * #1199 * #1200 * #1201 * #1203 * #1204 * #1205 * #1206 * #1207 * #1208 * #1209 * #1210 * #1211 * #1212 * #1213 * #1214 * #1215 * #1216 * #1217 * #1219 * #1220 * #1221 * #1222 * #1223 * #1224 * #1225 * #1226 * #1227 * #1229

imobachgs added 11 commits March 26, 2024 12:17

Add a Firefox startup script

2e6c2c2

Optionally write the token when starting the server

469a92c

Add the agama-web-server service

8936558

Disable @typescript-eslint/no-unused-vars

b8ef5f5

Update the agama-web-ui.spec to the new code

4bc5a75

Serve precompressed (gz) files if they are available

ec1ad7b

Remove the extra slash from HTTP methods

2fe7df5

Drop cockpit.socket dependency in agama.service

4b8410a

Add modified agama-live KIWI files

51c0ff4

Add a temporary README to the 'live' directory

1650fc6

Add a README.md to the live/ directory

a6507db

lslezak reviewed Apr 2, 2024

View reviewed changes

rust/agama-server/src/web/service.rs Show resolved Hide resolved

imobachgs added 7 commits April 3, 2024 11:16

Add support to login from the query string

4bdcceb

Use the login endpoint to start the local browser

22f5174

Update the list of packages in the KIWI image

cd270da

Merge branch 'architecture_2024' into agama-live-update

c1d93cf

Keep uncompressed assets when building the UI

78d595d

Minor formatting change

8ac6eb4

Keep uncompressed files in agama-web-ui RPM package

68cd286

lslezak reviewed Apr 3, 2024

View reviewed changes

rust/agama-server/src/web/http.rs Outdated Show resolved Hide resolved

rust/agama-server/src/web/http.rs Outdated Show resolved Hide resolved

rust/agama-server/src/web/http.rs Outdated Show resolved Hide resolved

Make the login redirection temporary

ff670b0

lslezak reviewed Apr 3, 2024

View reviewed changes

imobachgs added 5 commits April 3, 2024 13:41

Move the token creation to a function

9f8c7b2

Add root.tar contents to agama-live directory

5dfe0d5

Inject the token in Firefox's preferences

be2b5ef

Remove the startup script from the old location

ce1f5ff

Fix sed invocation

512e444

imobachgs added 3 commits April 3, 2024 16:38

Fix Firefox start-up

16b36e0

Fix agama-web-server dependency

bd5549b

Merge branch 'architecture_2024' into agama-live-update

86afb33

lslezak approved these changes Apr 4, 2024

View reviewed changes

imobachgs merged commit 94c46bc into architecture_2024 Apr 4, 2024
3 checks passed

imobachgs deleted the agama-live-update branch April 4, 2024 12:37

imobachgs mentioned this pull request Apr 25, 2024

A few sentences about how agama deals with security #1170

Merged

imobachgs mentioned this pull request May 3, 2024

Merge architecture_2024 branch into master #1177

Merged

imobachgs mentioned this pull request May 17, 2024

Update to release 8 #1232

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adapt agama-live to work with the new architecture #1119

Adapt agama-live to work with the new architecture #1119

imobachgs commented Mar 26, 2024 •

edited

Loading

coveralls commented Mar 26, 2024 •

edited

Loading

lslezak Apr 2, 2024 •

edited

Loading

imobachgs Apr 2, 2024

imobachgs Apr 2, 2024 •

edited

Loading

imobachgs commented Apr 3, 2024 •

edited

Loading

lslezak left a comment

lslezak Apr 3, 2024 •

edited

Loading

imobachgs Apr 3, 2024

lslezak Apr 3, 2024

lslezak Apr 3, 2024

imobachgs Apr 3, 2024

lslezak left a comment

imobachgs commented Apr 4, 2024

Adapt agama-live to work with the new architecture #1119

Adapt agama-live to work with the new architecture #1119

Conversation

imobachgs commented Mar 26, 2024 • edited Loading

Changes summary

To do

agama-live sources in the repo

coveralls commented Mar 26, 2024 • edited Loading

lslezak Apr 2, 2024 • edited Loading

Choose a reason for hiding this comment

imobachgs Apr 2, 2024

Choose a reason for hiding this comment

imobachgs Apr 2, 2024 • edited Loading

Choose a reason for hiding this comment

imobachgs commented Apr 3, 2024 • edited Loading

lslezak left a comment

Choose a reason for hiding this comment

lslezak Apr 3, 2024 • edited Loading

Choose a reason for hiding this comment

imobachgs Apr 3, 2024

Choose a reason for hiding this comment

lslezak Apr 3, 2024

Choose a reason for hiding this comment

lslezak Apr 3, 2024

Choose a reason for hiding this comment

imobachgs Apr 3, 2024

Choose a reason for hiding this comment

lslezak left a comment

Choose a reason for hiding this comment

imobachgs commented Apr 4, 2024

imobachgs commented Mar 26, 2024 •

edited

Loading

coveralls commented Mar 26, 2024 •

edited

Loading

lslezak Apr 2, 2024 •

edited

Loading

imobachgs Apr 2, 2024 •

edited

Loading

imobachgs commented Apr 3, 2024 •

edited

Loading

lslezak Apr 3, 2024 •

edited

Loading