[web] Move information about transactional system to the top of the storage page

[ancorgs]

Problem

Agama shows a message in the storage screen if the product being installed uses a transactional Btrfs as root file-system (ie. read-only root subvolume and Btrfs snapshots as a mechanism to perform updates). But that message was displayed in the middle of the "Settings" section taking the place usually occupied by the Btrfs snapshots switch. Having it there didn't make much sense.

Moreover, the sentence was a bit complicated and it was not so clear how the statement was related to other settings in the same page.

Solution

The message is now displayed at the top of the page and the wording has been slightly modified to, hopefully, explain why some of the usual configuration options (like disabling Btrfs snapshots or changing the file-system type for "/") are not available.

If the system is not transactional, everything looks as before, as displayed in the following screenshots.

Testing

• Tested manually
• Updated unit tests

Note

This is broken into many small commits to ease collaboration during development. The plan is to squash when merging.

[coveralls]

coverage: 74.427% (+0.03%) from 74.401%
when pulling 338b8e5 on ancorgs:transactional_on_top
into 987e8f7 on openSUSE:master.

[dgdavid]

Note for future change: this is actually "not working". If you add the @ts-check comment directive to the file and then run the npm run check-types task it will complain because

src/components/storage/ProposalTransactionalInfo.jsx:34:42 - error TS2694: Namespace '"/src/client/storage"' has no exported member 'ProposalManager'.

34  * @typedef {import ("~/client/storage").ProposalManager.ProposalSettings} ProposalSettings
                            

And it is right. The ProposalManager class is actually not exported. I think there will be changes in the clients soon, not sure. But in any case, I'll move all the type definitions to the top of the file, avoiding to have them name spaced unless it make sense. @imobachgs, friendly ping.

[dgdavid]

I prefer the warning at the top because transactional products actually have implications in several sections. For example, if the system wouldn't be transactional, very likely there would be a "Btrfs Snapshots" toggle at the "Settings" section. Users who have already installed a non-transactional system may be wondering where it went.

Just for future reference, we had a short meeting to clarify this and as result a follow-up task was created. Find it at https://trello.com/c/ynFUHahV/353-agama-better-transactional-explanations-at-storage (internal link).

[dgdavid]

Not sure if this should from now on live at src/components/product/Transactional{Info|Reminder}.jsx, but it is something that I'd evaluate, if needed, in the context of https://trello.com/c/ynFUHahV/353-agama-better-transactional-explanations-at-storage.

Looks related to the product itself... but actually it checks the storage settings.

[joseivanlopez]

LGTM