-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge master to the new server branch #1129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use either the cerfificate specified via command line arguments or generate a self-signed certificate - Redirect external HTTP requests to HTTPS - Allow HTTP for internal connections (http://localhost) - Optionally listen on a secondary address (to allow listening on both HTTP/80 and HTTPS/433 ports)
- agama.gemspec was renamed, see #1056. - The file name was not updated in the rubocop config.
## Problem The current result of the storage proposal is presented as a list of actions, which could make a bit complex to understand the overall picture of the resulting devices. That list of actions is going to be replaced by a more visual representation of the devices. To make this possible, more information about the devices has to be exported on D-Bus. * Part of https://trello.com/c/7TTVVquM. ## Solution Add the following information to D-Bus: * The list of actions includes the SID of the affected device. * The partition table exports the unused slots. * The LVM devices (volume groups, physical volumes and logical volumes) are exported. * The block devices includes their start block and also indicates whether the device is encrypted. * The staging devices are exported. NOTE: This PR goes to a feature branch instead of master. ## Testing * Added unit tests * Tested manually
## Problem More information is required to properly represent the storage proposal result: * Device description * Filesystem label This is a follow-up of #1071. ## Solution Add new D-Bus interfaces `Device` , `Partition`, `LVM.LogicalVolume` and adapt `Filesystem` interface. This changes require yast/yast-storage-ng#1373. NOTE: This PR goes to a feature branch instead of master. ## Testing * Added unit tests * Tested manually
Agama-weblate commit: 6e40e55f095086ac0577a8737169f99cde56c88c
Agama-weblate commit: 6e40e55f095086ac0577a8737169f99cde56c88c
Agama-weblate commit: 6e40e55f095086ac0577a8737169f99cde56c88c
## Problem The storage D-Bus API was extended to provide all the information required for a better representation of the proposal result, see #1071 and #1082. The JS storage client has to be adapted. ## Solution Adapt the storage client to the changes in the D-Bus API and adapt `ProposalPage` component to read the information about the devices if needed. NOTE: This PR goes to a feature branch instead of master. ## Testing * Added new unit tests * Tested manually
## Problem - Continue with dropping the Cockpit dependency ## Solution - Do not use the Cockpit manifest for storing the list of supported languages - Use a separate `languages.json` file instead of the `manifest.json` - Import the JSON file directly into the JS code - The workflow is not changed, the update script just generates a different file - The change is backward compatible, works with both Cockpit and the new server ## Testing - Updated unit tests - Tested manually, the language selection still works fine
## Problem No infiniband in network model ## Solution Add infiniband to network model ## Testing - *Added a new unit test* - *Tested manually* - *Tested using the migration jcronenberg#74
Co-authored-by: Ancor Gonzalez Sosa <ancorgs@gmail.com>
Co-authored-by: Ancor Gonzalez Sosa <ancorgs@gmail.com>
Co-authored-by: Ancor Gonzalez Sosa <ancorgs@gmail.com>
Co-authored-by: Ancor Gonzalez Sosa <ancorgs@gmail.com>
Co-authored-by: David Díaz González <dgonzalez@suse.de>
Co-authored-by: David Díaz González <dgonzalez@suse.de>
Co-authored-by: David Díaz González <dgonzalez@suse.de>
Co-authored-by: Ancor Gonzalez Sosa <ancorgs@gmail.com> Co-authored-by: David Díaz González <dgonzalez@suse.de>
Co-authored-by: Ancor Gonzalez Sosa <ancorgs@gmail.com> Co-authored-by: David Díaz González <dgonzalez@suse.de>
Co-authored-by: Ancor Gonzalez Sosa <ancorgs@gmail.com>
This PR implements the new UI selectors for the target installation device and for the boot device, see https://github.com/openSUSE/agama/blob/master/doc/storage_ui.md. For the installation device it offers the following options: * Select a target disk (the file systems are created over new partitions). * Create a new LVM volume group (the file systems are crated over logical volumes). * The option for reusing LVM volume groups is not offered yet. For the boot device it offers the following options: * To use the selected disk for installation. * To use a different disk. * To not configure boot partitions. ## Screenshots <details> <summary>Toggle</summary> ![localhost_8080_ (33)](https://github.com/openSUSE/agama/assets/1112304/63828e27-b3b1-4312-a14a-0435a86d3347) ![localhost_8080_ (32)](https://github.com/openSUSE/agama/assets/1112304/b79b84b9-d543-4558-af79-4b7cfd0d8bc7) </details>
imobachgs
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
imobachgs
added a commit
that referenced
this pull request
May 6, 2024
After a few months of work, it is time to merge the `architecture_2024` branch into `master`. It is still a work-in-progress, but all the efforts should be go now against that branch. ## Pull requests * #1061 * #1064 * #1073 * #1074 * #1080 * #1089 * #1091 * #1092 * #1094 * #1095 * #1099 * #1100 * #1102 * #1103 * #1112 * #1114 * #1116 * #1117 * #1119 * #1120 * #1123 * #1126 * #1129 * #1130 * #1131 * #1132 * #1133 * #1134 * #1136 * #1139 * #1140 * #1143 * #1146 ## Other commits * 8efa41f * 9e2dec0
Merged
imobachgs
added a commit
that referenced
this pull request
May 17, 2024
Prepare for releasing Agama 8. It includes the following pull requests: * #884 * #886 * #914 * #918 * #956 * #957 * #958 * #959 * #960 * #961 * #962 * #963 * #964 * #965 * #966 * #969 * #970 * #976 * #977 * #978 * #979 * #980 * #981 * #983 * #984 * #985 * #986 * #988 * #991 * #992 * #995 * #996 * #997 * #999 * #1003 * #1004 * #1006 * #1007 * #1008 * #1009 * #1010 * #1011 * #1012 * #1014 * #1015 * #1016 * #1017 * #1020 * #1022 * #1023 * #1024 * #1025 * #1027 * #1028 * #1029 * #1030 * #1031 * #1032 * #1033 * #1034 * #1035 * #1036 * #1038 * #1039 * #1041 * #1042 * #1043 * #1045 * #1046 * #1047 * #1048 * #1052 * #1054 * #1056 * #1057 * #1060 * #1061 * #1062 * #1063 * #1064 * #1066 * #1067 * #1068 * #1069 * #1071 * #1072 * #1073 * #1074 * #1075 * #1079 * #1080 * #1081 * #1082 * #1085 * #1086 * #1087 * #1088 * #1089 * #1090 * #1091 * #1092 * #1093 * #1094 * #1095 * #1096 * #1097 * #1098 * #1099 * #1100 * #1102 * #1103 * #1104 * #1105 * #1106 * #1109 * #1110 * #1111 * #1112 * #1114 * #1116 * #1117 * #1118 * #1119 * #1120 * #1121 * #1122 * #1123 * #1125 * #1126 * #1127 * #1128 * #1129 * #1130 * #1131 * #1132 * #1133 * #1134 * #1135 * #1136 * #1138 * #1139 * #1140 * #1141 * #1142 * #1143 * #1144 * #1145 * #1146 * #1147 * #1148 * #1149 * #1151 * #1152 * #1153 * #1154 * #1155 * #1156 * #1157 * #1158 * #1160 * #1161 * #1162 * #1163 * #1164 * #1165 * #1166 * #1167 * #1168 * #1169 * #1170 * #1171 * #1172 * #1173 * #1174 * #1175 * #1177 * #1178 * #1180 * #1181 * #1182 * #1183 * #1184 * #1185 * #1187 * #1188 * #1189 * #1190 * #1191 * #1192 * #1193 * #1194 * #1195 * #1196 * #1198 * #1199 * #1200 * #1201 * #1203 * #1204 * #1205 * #1206 * #1207 * #1208 * #1209 * #1210 * #1211 * #1212 * #1213 * #1214 * #1215 * #1216 * #1217 * #1219 * #1220 * #1221 * #1222 * #1223 * #1224 * #1225 * #1226 * #1227 * #1229
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
Testing
/api/ping
still works 😃