Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gzip (.gz) instead of bzip2 (.bz2) to compress logs #1408

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

mvidner
Copy link
Contributor

@mvidner mvidner commented Jun 28, 2024

Problem

Quoting #1378:

GitHub does not allow attaching bzip2 files. In order to make error reporting easier, agama logs store should use a different format (e.g., .gz and .tgz are supported). Otherwise, you need to uncompress and compress the logs again before submitting them.

Solution

Use gzip and .gz instead.

Testing

  • Tested manually

Screenshots

If the fix affects the UI attach some screenshots here.

so that they can be attached to GitHub issues.

Note that bzip2 is still used for source tarballs and PO tarballs
at *development* time,
but AFAIK no longer used at *run* time,
so the dependency is kept in .github/workflows but not in .spec
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Please, add a changelog entry referencing the original bug. Otherwise, it looks good to me!

PS: thanks for the ripgrep fix too :-)

@mvidner mvidner merged commit accf894 into master Jun 28, 2024
2 checks passed
@mvidner mvidner deleted the use-gzip-not-bzip2 branch June 28, 2024 07:22
@imobachgs imobachgs mentioned this pull request Sep 20, 2024
imobachgs added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants