JSON schema: improve non-storage parts #1437
Conversation
mvidner
force-pushed
the
schema-nonstorage
branch
from
7403c0c
to
945c670
Compare
| } | ||
| } | ||
| } | ||
| }, | ||
| "user": { | ||
| "title": "First user settings", | ||
| "type": "object", | ||
| "additionalProperties": false, |
There was a problem hiding this comment.
feature request: I am surprised that we don't allow hashed passwords in the profile
There was a problem hiding this comment.
Yes, you are right, that's something we need to implement. I have created a placeholder card in Trello.
- disallow additional properties - more specific type than string
mvidner
force-pushed
the
schema-nonstorage
branch
from
945c670
to
557372a
Compare
| @@ -576,7 +605,8 @@ | |||
| "sizeString": { | |||
| "title": "Human readable size (e.g., '2 GiB')", | |||
| "type": "string", | |||
| "pattern": "^[0-9]+(\\.[0-9]+)?(\\s*([KkMmGgTtPpEeZzYy][iI]?)?[Bb])?$" | |||
| "pattern": "^[0-9]+(\\.[0-9]+)?(\\s*([KkMmGgTtPpEeZzYy][iI]?)?[Bb])?$", | |||
| "examples": ["2 GiB", "1.5 TB", "1TIB", "1073741824 b", "1073741824"] | |||
There was a problem hiding this comment.
BTW, here the examples feature really shines because it provides an alternative to the dense regexp
Unfortunately, agama profile validate does not check whether the schema is internally consistent and uses only valid examples. Like, I could use a number here and it would not notice.
| @@ -117,7 +129,8 @@ | |||
| "type": "string" | |||
| }, | |||
| "security": { | |||
| "type": "string" | |||
| "type": "string", | |||
| "examples": ["? maybe this is actually an enum"] | |||
There was a problem hiding this comment.
FIXME, need to look up in the code what is valid here
There was a problem hiding this comment.
@teclator can you advise please?
service/test/agama/autoyast/wireless_reader_test.rb and
web/src/components/network/WifiConnectionForm.jsx seem to have different sets of values
otherwise npm run fails after the requirements change and we keep working with an outdated environment: "Cannot find module react-refresh-typescript"
mvidner
force-pushed
the
schema-nonstorage
branch
from
557372a
to
cee1b6f
Compare
| } | ||
| } | ||
| } | ||
| }, | ||
| "user": { | ||
| "title": "First user settings", | ||
| "type": "object", | ||
| "additionalProperties": false, |
There was a problem hiding this comment.
Yes, you are right, that's something we need to implement. I have created a placeholder card in Trello.
| "type": "string" | ||
| "title": "System language ID", | ||
| "type": "string", | ||
| "examples": ["en_US"] |
There was a problem hiding this comment.
We support specifying the whole locale (en_US.UTF-8). If no encoding is given (e.g., en_US), we fall back to UTF-8.
Prepare for releasing Agama 10· * #1263 * #1330 * #1407 * #1408 * #1410 * #1411 * #1412 * #1416 * #1417 * #1419 * #1420 * #1421 * #1422 * #1423 * #1424 * #1425 * #1428 * #1429 * #1430 * #1431 * #1432 * #1433 * #1436 * #1437 * #1438 * #1439 * #1440 * #1441 * #1443 * #1444 * #1445 * #1449 * #1450 * #1451 * #1452 * #1453 * #1454 * #1455 * #1456 * #1457 * #1459 * #1460 * #1462 * #1464 * #1465 * #1466 * #1467 * #1468 * #1469 * #1470 * #1471 * #1472 * #1473 * #1475 * #1476 * #1477 * #1478 * #1479 * #1480 * #1481 * #1482 * #1483 * #1484 * #1485 * #1486 * #1487 * #1488 * #1489 * #1491 * #1492 * #1493 * #1494 * #1496 * #1497 * #1498 * #1499 * #1500 * #1501 * #1502 * #1503 * #1504 * #1505 * #1506 * #1507 * #1508 * #1510 * #1511 * #1512 * #1513 * #1514 * #1515 * #1516 * #1517 * #1518 * #1519 * #1520 * #1522 * #1523 * #1524 * #1525 * #1526 * #1527 * #1528 * #1529 * #1530 * #1531 * #1532 * #1533 * #1534 * #1535 * #1536 * #1537 * #1540 * #1541 * #1543 * #1544 * #1545 * #1546 * #1547 * #1548 * #1549 * #1550 * #1552 * #1553 * #1554 * #1555 * #1556 * #1557 * #1558 * #1559 * #1560 * #1562 * #1563 * #1565 * #1566 * #1567 * #1568 * #1569 * #1570 * #1571 * #1572 * #1573 * #1574 * #1575 * #1576 * #1577 * #1578 * #1579 * #1580 * #1581 * #1583 * #1584 * #1585 * #1586 * #1587 * #1588 * #1589 * #1590 * #1591 * #1592 * #1593 * #1596 * #1597 * #1598 * #1600 * #1602 * #1605 * #1606 * #1607 * #1608 * #1610 * #1611 * #1612 * #1613 * #1614 * #1619 * #1620 * #1621
Problem
While reviewing #1263 I read the whole schema and saw room for improvement. Small things
Solution
Testing
Minimal, just making sure the schema itself is valid, by